Issue metadata
Sign in to add a comment
|
Regression: Spacing issue is seen between the Add WiFi..button and WiFi toggle button in chrome://settings/networks |
||||||||||||||||||||||
Issue descriptionChrome Version:67.0.3369.0/10487.0.0 dev channel Daisy,Kip,Reks OS:Chrome OS What steps will reproduce the problem? (1)Open chrome://settings/networks?type=WiFi and Observe the Add WiFi..button and the WiFi toggle button. Actual: Add WiFi button and toggle button are seen very near to each other without any gap such that focus of one button falls on other. Expected: There should be proper spacing between the buttons as expected This is a Regression issue as same is working fine in 67.0.3362.0/10463.0.0 dev Note: Issue is not seen in Linux,Windows OS Attached the screencast for reference.. @stevenjb: Please confirm the issue.
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/847d71ea4c41026dbb0ae4450abba98e7cc240b1 commit 847d71ea4c41026dbb0ae4450abba98e7cc240b1 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Mar 14 21:09:56 2018 Network settings: Layout fixes This includes a handful of minor layout fixes after close examination of the network settings UI. * Spacing issue introduced with paper button changes: https://chromium-review.googlesource.com/907856 * Alignment issue introdiced when fixing click targets: https://chromium-review.googlesource.com/952033 * ip-config JS console error causing details page to be incorrect initially (old issue, but probably exposed with recent refactoring) * Network security icon bug in detail page that has existed since 64 (no bug filed that I could find) Only the security icon bug impacts 66 and it's confusing but minor. Bug: 821733 , 821720 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I877aeb93a232f6c656d73ac7c345f63e00cbf125 Reviewed-on: https://chromium-review.googlesource.com/963303 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543196} [modify] https://crrev.com/847d71ea4c41026dbb0ae4450abba98e7cc240b1/chrome/browser/resources/settings/internet_page/internet_subpage.html [modify] https://crrev.com/847d71ea4c41026dbb0ae4450abba98e7cc240b1/chrome/browser/resources/settings/internet_page/network_summary_item.html [modify] https://crrev.com/847d71ea4c41026dbb0ae4450abba98e7cc240b1/ui/webui/resources/cr_components/chromeos/network/network_ip_config.js [modify] https://crrev.com/847d71ea4c41026dbb0ae4450abba98e7cc240b1/ui/webui/resources/cr_elements/chromeos/network/cr_network_icon.js
,
Mar 15 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Mar 14 2018