New issue
Advanced search Search tips

Issue 821688 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Button icon for 'Add accessibility features' is not seen in chrome://settings/accessibility page

Reported by khushal....@etouch.net, Mar 14 2018 
Chrome Version: 67.0.3370.0 (Official Build) Revision: 540244ed4952574c2bb88ac553397e47e5f03c4e-refs/heads/master@{#542909} (32/64 bit)
 	
OS: Win(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS) 

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/accessibility and observe the icon.

Actual Result: Button icon for 'Add accessibility features' is not seen.

Expected Result: Button icon for 'Add accessibility Features' should be seen.

This is a regression issue, broken in M-67 series, and will soon update other info.

Good Build: 67.0.3368.0
Bad Build:  67.0.3369.0

Thank You!
Actual Video.mp4
290 KB View Download
Expected Video.mp4
233 KB View Download

Comment 1 by khushal....@etouch.net, Mar 14 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 series, Using the per-revision bisect providing the bisect results,

Good Build:67.0.3368.0(Revision:542341)
Bad Build:67.0.3369.0(Revision:542817)

You are probably looking for a change made after 542361 (known good), but no later than 542362 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/feb3b5d8fc0436f4ae83736f450544142e9a21f1..b6477fef9acbe00a3e8b58b6963b518b57575ed3

Suspect: https://chromium.googlesource.com/chromium/src/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3

@hcarmona :Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
   
Thank You!

Comment 2 by hcarmona@chromium.org, Mar 21 2018

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/018b457108b049d89a9af894f597307211eee487

commit 018b457108b049d89a9af894f597307211eee487
Author: Hector Carmona <hcarmona@chromium.org>
Date: Wed Mar 21 22:15:00 2018

Make paper-icon-buttons actionable to show icon.

cr-shared-style hides any .subpage-arrow or .icon-external that isn't
actionable. Making the paper-icon-button light actionable makes these
icons visible again.

Bug:  821688 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I91b2063530a70efe8a8781f9df888883e4221dde
Reviewed-on: https://chromium-review.googlesource.com/972580
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544866}
[modify] https://crrev.com/018b457108b049d89a9af894f597307211eee487/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/018b457108b049d89a9af894f597307211eee487/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/018b457108b049d89a9af894f597307211eee487/chrome/browser/resources/settings/people_page/sync_page.html
[modify] https://crrev.com/018b457108b049d89a9af894f597307211eee487/chrome/browser/resources/settings/printing_page/cloud_printers.html
[modify] https://crrev.com/018b457108b049d89a9af894f597307211eee487/chrome/browser/resources/settings/privacy_page/privacy_page.html

Comment 4 by hcarmona@chromium.org, Mar 21 2018

Status: Fixed (was: Started)

Comment 5 by khushal....@etouch.net, Mar 22 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3378.0
Rechecked the above issue on latest Canary build #67.0.3378.0 for Windows OS (7, 8, 8.1, 10), Mac OS (10.12.6, 10.13.1, 10.13.4) & Linux OS (14.04 LTS) and the issue is fixed. Please refer the attached screencast.
Fixed Video.mp4
234 KB View Download
►

Sign in to add a comment