New issue
Advanced search Search tips

Issue 821686 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Mar 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Focus highlight appears misplaced in 'Add Languages' dialog.

Reported by avsha...@etouch.net, Mar 14 2018 
Chrome Version : 67.0.3370.0 (Official Build) 540244ed4952574c2bb88ac553397e47e5f03c4e-refs/heads/master@{#542909} 32/64-bit
OS : Windows(7,8,8.1,10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.4)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/languages and click on 'Add Languages' link in 'Languages' section.
2. In 'Add Languages' dialog, enter any query in seach box and hit 'Tab' key to bring focus on 'Clear' (X) icon.
3. Observe the focus.

Actual Result : 'Clear'(X) icon focus highlight appears misplaced in 'Add Languages' dialog.

Expected Result : Focus highlight on 'Clear'(X) icon should appears properly.

This is a regression issue, broken in M-67 and will soon update remaining info.
Actual_Focus.mp4
280 KB View Download
Expected_focus.mp4
283 KB View Download

Comment 1 by avsha...@etouch.net, Mar 14 2018

Labels: hasbisect-per-revision RegressedIn-67 Target-67 FoundIn-67 ET-MUM-Reported
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-67 and providing the bisect using per-revision script:
Good Build : 67.0.3368.0 (Revision : 542341)
Bad Build : 67.0.3369.0 (Revision : 542817)

You are probably looking for a change made after 542361 (known good), but no later than 542362 (first known bad).

CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/feb3b5d8fc0436f4ae83736f450544142e9a21f1..b6477fef9acbe00a3e8b58b6963b518b57575ed3

Suspect : https://chromium.googlesource.com/chromium/src/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3

@hcarmona : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank you..!

Comment 2 by hcarmona@chromium.org, Mar 21 2018

Status: Started (was: Assigned)
+Screenshot of fix.

Ripple in screenshot is clipped, see  Issue 815358
Screen Shot 2018-03-20 at 5.07.06 PM.png
119 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80a5b7265ef0ff0a1dbff620706f7cdf8614ecac

commit 80a5b7265ef0ff0a1dbff620706f7cdf8614ecac
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Mar 22 01:53:36 2018

MD Settings: Fix misaligned ripple.

See screenshot in bug.

Bug:  821686 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iddc5c0bc3e2eddc5d1e7d06f30f996191560fba6
Reviewed-on: https://chromium-review.googlesource.com/972548
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544942}
[modify] https://crrev.com/80a5b7265ef0ff0a1dbff620706f7cdf8614ecac/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Comment 4 by avsha...@etouch.net, Mar 23 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3379.0
Update : 
Retested above issue in latest Canary #67.0.3379.0 build on Mac(10.12.6, 10.13.1, 10.13.4), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Kindly review an attached screencast.

Thank you!
Canary_behavior.mp4
585 KB View Download

Comment 5 by hcarmona@chromium.org, Mar 26 2018

Status: Fixed (was: Started)
►

Sign in to add a comment