Demonstration: https://photos.google.com/share/AF1QipPzFL2xiCxqICXpmduCXPEGW7xygbIkhML4TjdryfzINN_2jJ8klynmd6G8X8tmIQ?key=SEppemdObWdVZ3Z3LXhyN1lQZW9MSUJNWW9jTGZR

Assign as the ChromeOS issue.

Not an enterprise issue - it's a problem with pinned pages on chrome os in general, has nothing to do with managed devices. I'm not sure who the right owner is here, but adding Component:History because it primarily impacts history.

Note that if the page itself refreshes, it is added to history - it's just the initial opening of that pinned page that doesn't get reflected in history.

If you pin Youtube, for instance, any video you watch from that pinned page are not reflected in history either, if I'm not mistaken.

Hello!
This bug is receiving this notice because there has been no acknowledgment of its existence in quite a bit of time.
- If you are currently working on this bug, please provide an update.
- If you are currently affected by this bug, please update with your current symptoms and relevant logs.

If there has been no updates provided by EOD Wednesday, 12/12/18 (5pm EST), this bug will be archived and can be re-opened at any time deemed necessary.

Thank you!

I'm afraid the issue is still there in latest versions of Chrome OS, please see attached.

Deleted: Caso-error3.pdf 310 KB

Caso-error3.pdf 310 KB Download

Hello, the error persists in the version Version 70.0.3538.110 Following the same steps

Assigning to sczs@ to confirm that this is WAI.

It's generally recommended that network traffic monitoring is done via a network Proxy as well as additional resources available via the Admin Console. I don't believe this is the intended use case of this feature but I have looped in someone from the engineering team to confirm this.

Hey sylcat@ I'm sorry I work on Chrome iOS and have no knowledge of the behavior on ChromeOS or who might be the right owner.
ccing sdefresne as a components/history Owner and msramek@ as ChromeOS privacy. They might have a better idea.

Thanks for the update! sdfresne@ is this something you can assist with? Or if not would you happen to know someone who would be a better fit to assist?

I've looked at the HistoryService code and I don't see anything that would prevent saving the navigation to the history. I am unfamiliar with how those pinned tabs work with ChromeOS, but I would tend to think there is some logic that may decide to not send the navigation to the HistoryService.

I think someone more familiar with ChromeOS (ideally someone involved with the pinned tab features) should take a look.

jamescook: as a randomly selected OWNERS from src/chrome/browser/chromeos can you redirect to the correct triage queue for chromeos bugs?

Issue 914960 has been merged into this issue.

I think this is a generic bookmark app / PWA-ish problem. benwells, can you find an owner?

Here's a repro:
* Navigate to a page
* Wipe your history
* Browser menu > More tools > Create shortcut...
* New item created in shelf
* Close browser window
* Right-click on shelf item, set "New tab > New window"
* Click the item. It opens in the desktop PWA frame
* Do some navigations
* Open browser history. None of the navigations are recorded.

The string "Create shortcut..." is IDS_ADD_TO_OS_LAUNCH_SURFACE, tied to a feature extensions::util::IsNewBookmarkAppsEnabled(), which is apparently on all platforms except Mac. I don't have a Windows machine handy, but I wonder if the problem reproduces there as well.

Looks to me like the issue is in HistoryTabHelper: https://cs.chromium.org/chromium/src/chrome/browser/history/history_tab_helper.cc?type=cs&q=chrome/browser/history/history_tab_helper.cc&sq=package:chromium&g=0&l=180

If browser->is_app() is true on desktop, navigations aren't saved to history. Bookmark apps count as browser->is_app(). It looks like this has been the case for >6 years - I assume because we don't want to record navigations in Chrome Apps to history. I think it doesn't make sense to stop navigations in bookmark apps from appearing in history (e.g. Android does not have the same check).

A fix will be slightly involved - we'll need to check the type of app, and ensure if the underlying app is a bookmark app (Extension::from_bookmark() is true), we allow the history to be saved.

We should also consider moving that chunk of code closer to the start of the method so it returns before it makes a bunch of not-used arguments.

+loyso - our new web app container is going to need to think about issues like this one.

Can we just remove that check? Chrome Packaged Apps should not be included in history, but they don't have a browser so won't be checking browser->is_app. All other app types should be in history.

If packaged apps don't have a browser and every other kind of app should be in history, I see no reason for the check to be kept. :)

I've got the trivial fix for this up now.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ef5b44a15160bcc4acdde7b4d073876ecb9b6f

commit 31ef5b44a15160bcc4acdde7b4d073876ecb9b6f
Author: Dominick Ng <dominickn@chromium.org>
Date: Thu Jan 03 04:08:30 2019

Record navigations in extension-based apps to history.

This CL addresses a bug where bookmark apps (including desktop PWAs) do
not have their navigations record to Chrome history.

Chrome Packaged apps do not have a |browser| object, so removing the is_app()
check will not affect them.

BUG= 821685 

Change-Id: I87356b6c6d3dad5e4cc321966bf385975adac995
Reviewed-on: https://chromium-review.googlesource.com/c/1388045
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619581}
[modify] https://crrev.com/31ef5b44a15160bcc4acdde7b4d073876ecb9b6f/chrome/browser/history/history_tab_helper.cc

Tried testing the issue on the reported chrome version #64.0.3282.190 using Mac OS 10.13.6, Ubuntu 17.10 and Windows 10 by following steps as per comment#0 and on chrome version #71.0.3578.98 using Windows 10 as per comment#15. In both cases observed the history gets recorded.

Attached screencasts for reference.
@Dominick Ng: Could you please review attached screencasts and let us know if anything is being missed from our end.
Help us in verifying the fix on latest M-73.
Thanks.!

Deleted: 821685_M64.mp4 3.7 MB

	821685_M64.mp4 3.7 MB View Download

Deleted: 821685_M71.mp4 6.8 MB

	821685_M71.mp4 6.8 MB View Download

#24: You need to install a Progressive Web App, e.g. mobile.twitter.com. The bug will not manifest if you install a shortcut that opens in the browser; it needs to open in a standalone app window.