New issue
Advanced search Search tips

Issue 821675 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'You can clear browsing data from menu' tool tip appears misaligned in chrome://history page.

Reported by rp...@etouch.net, Mar 14 2018

Issue description

Version: 67.0.3369.0 (Official Build) Revision	d21e3816b10d22501455fea1468d56df514ea442-refs/heads/master@{#542817}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.4)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://history page
2. Now drag chrome://history page to LHS such as 'You can clear browsing data from menu' tool tip is seen
3. Observe 'You can clear browsing data from menu' tool tip
 
Actual: 'You can clear browsing data from menu' tool tip appears misaligned 
Expected: 'You can clear browsing data from menu' tool tip should be seen properly

This is regression issue, broken in ‘M 67’ and below is the bisect info :
Good build: 67.0.3368.0  (Revision: 542341).
Bad build: 67.0.3369.0 (Revision: 542817).

You are probably looking for a change made after 542361 (known good), but no later than 542362 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/feb3b5d8fc0436f4ae83736f450544142e9a21f1..b6477fef9acbe00a3e8b58b6963b518b57575ed3

Suspect : https://chromium.googlesource.com/chromium/src/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3

From the CL above, assigning the issue to the concern owner 

@hcarmona- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.



 
Actual_video.mp4
276 KB View Download
Expected_video.mp4
197 KB View Download
Status: Started (was: Assigned)
+Screenshot
fix.png
25.8 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27f4ff5e612d8f7a467aff88d4a23f1bc69aff31

commit 27f4ff5e612d8f7a467aff88d4a23f1bc69aff31
Author: Hector Carmona <hcarmona@chromium.org>
Date: Thu Mar 22 01:01:05 2018

MD History: Align Toolbar Tooltip

Bug:  821675 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I68f3856a2c7dad75219d480a5618417e69e9cfcd
Reviewed-on: https://chromium-review.googlesource.com/969944
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544928}
[modify] https://crrev.com/27f4ff5e612d8f7a467aff88d4a23f1bc69aff31/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html

Comment 4 by avsha...@etouch.net, Mar 22 2018

Labels: TE-Verified-M67 TE-Verified-67.0.3378.0
Update : 
Retested above issue in latest Canary #67.0.3378.0 build on Mac(10.12.6, 10.13.1, 10.13.4), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Tooltip is aligned properly with the history page toolbar. Kindly review an attached screencast.

Thank you!
Canary_behavior.mp4
517 KB View Download
Status: Fixed (was: Started)

Sign in to add a comment