Echo leakage for narrow band render signals in AEC3 |
|||||||||
Issue descriptionFor good echo paths, the AEC3 may leak echo when the render signal has a narrow band characteristic. The spectral leakage in the filter output error term used to compute the adaptation gain causes the filter to diverge for frequency regions neighboring the dominating narrow band. There is functionality in place to handle that this but the effect of that is too mild.
,
Mar 23 2018
I would like to ask for a merge of this into M66. The feature has been tested in Canary for 7 days and performs well in the stats. The feature is only activated beneath an experimental flag so the merge is safe in the sense that the code can be turned off in case any issue would arise.
,
Mar 23 2018
This bug requires manual review: Less than 21 days to go before AppStore submit on M66 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 23 2018
,
Mar 23 2018
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/cda6357a6638c483eea32f683f6f44b2ea9d26ea commit cda6357a6638c483eea32f683f6f44b2ea9d26ea Author: Per Åhgren <peah@webrtc.org> Date: Fri Mar 23 22:43:24 2018 Merge to M66: Corrected the detection of narrowband render signals This CL corrects the bug that only looked at narrowband render signals above 900 Hz and only assumed that the influence of such lasted for 6 blocks, which resulted in filter divergence and echo leakage. (cherry picked from commit 971de07713ad4d35b0969331d6af9daac93ae3e5) TBR: ivoc@webrtc.org, henrik.lundin@webrtc.org Bug: webrtc:9008 , chromium:821670 Change-Id: I9b2635d24b260e9d9a8c5c088ab663e03fb93c42 Reviewed-on: https://webrtc-review.googlesource.com/61800 Commit-Queue: Per Åhgren <peah@webrtc.org> Reviewed-by: Ivo Creusen <ivoc@webrtc.org> Cr-Original-Commit-Position: refs/heads/master@{#22434} Reviewed-on: https://webrtc-review.googlesource.com/64481 Reviewed-by: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/branch-heads/66@{#11} Cr-Branched-From: 12c8110e8c717b7f0f87615d3b99caac2a69fa6c-refs/heads/master@{#22215} [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/echo_remover.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/main_filter_update_gain_unittest.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/render_signal_analyzer.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/render_signal_analyzer.h [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/render_signal_analyzer_unittest.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/shadow_filter_update_gain_unittest.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/subtractor_unittest.cc [modify] https://crrev.com/cda6357a6638c483eea32f683f6f44b2ea9d26ea/modules/audio_processing/aec3/suppression_gain_unittest.cc
,
Mar 23 2018
,
Mar 23 2018
,
Mar 27 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2018
Looks to have been merged already to M66, as per comment 5. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 15 2018