New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821667 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

wifi autotest: Write an autotest to measure authentication, association and IP configuration times

Project Member Reported by kirtika@chromium.org, Mar 14 2018

Issue description

OS: R67

The test-scripts shipped for shill already let you do this, so this is just hooking it up correctly in autotest: 

e.g. `/usr/local/lib/flimflam/test/connect-service GoogleGuest`
on a test image will report time to authenticate, associate and get an IP.

Do this after a reboot and after a suspend. Catch regressions, and define an acceptable range (e.g. auth should be <2 seconds, same for assoc, IP config can take 1-30 seconds depending on whether DHCP packets are heard). 

Brian Norris was looking at slow resume times on a certain vendor's chip, this test may have helped there. Should also be part of AVL suites. 

 
Cc: cernekee@chromium.org briannorris@chromium.org
Components: OS>Systems>Network
Labels: -Pri-3 Pri-2
Labels: -Pri-2 OS-Chrome Pri-1
Owner: zmarcus@google.com
Zach, this will make a good warm-up task for you. 
Reminder to self to walk you through 
(a) /usr/local/lib/flimflam/test/* scripts 
(b) shill unit-tests
(c) AVL spreadsheet where we track the auth/assoc/config times. 

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4b2d27829ac1eddc6140f89f87d0bbb8b943a153

commit 4b2d27829ac1eddc6140f89f87d0bbb8b943a153
Author: Zachary Marcus <zmarcus@google.com>
Date: Sun Jun 24 07:58:16 2018

autotest-server-tests: Add test for wifi shill performance numbers

Adding an ebuild entry for network_WiFi_AssocConfigPerformance

BUG=chromium:821667
TEST=None
Change-Id: I44b7958f6a2071a380f2792eab94f8e6c2b8b942
Reviewed-on: https://chromium-review.googlesource.com/1014669
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/4b2d27829ac1eddc6140f89f87d0bbb8b943a153/chromeos-base/autotest-server-tests-shill/autotest-server-tests-shill-9999.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/61304a906f4bc56335c5d2b63840cf66ac30a35f

commit 61304a906f4bc56335c5d2b63840cf66ac30a35f
Author: Zachary Marcus <zmarcus@google.com>
Date: Mon Jun 25 21:03:46 2018

autotest: network_WiFi_AssocConfigPerformance: Add test to measure perf

Measure authentication, association, and IP configuration times. Write a
test to record that performance over several runs and report back.
network_WiFi_SimpleConnect already measures these times, but add a
separate test to add variations with reboot and suspend. Don't want to
clobber the purpose of SimpleConnect, which is just to check a
connection in various scenarios

CQ-DEPEND=CL:1014669, CL:1065060
BUG=chromium:821667
TEST=test_that -b cave ${DUT_HOSTNAME} network_WiFiAssocConfigPerformance
Change-Id: I9dceb690e257cef654230bc0126012108898197a
Reviewed-on: https://chromium-review.googlesource.com/1014702
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Tested-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/61304a906f4bc56335c5d2b63840cf66ac30a35f/tko/perf_upload/perf_dashboard_config.json
[add] https://crrev.com/61304a906f4bc56335c5d2b63840cf66ac30a35f/server/site_tests/network_WiFi_AssocConfigPerformance/network_WiFi_AssocConfigPerformance.py
[add] https://crrev.com/61304a906f4bc56335c5d2b63840cf66ac30a35f/server/site_tests/network_WiFi_AssocConfigPerformance/control

Cc: -cernekee@chromium.org akhouderchah@chromium.org
Did we file a TODO to get rid of the caching effects here, or is the still-open $subject bug serving for this?

I was wondering, because I'm doing some edits on the AVL template, and I wanted to know what the status was for making network_WiFi_AssocConfigPerformance useful there.

Possible suggestion: can't we just rotate the SSID for the AP to something unknown to the DUT, if we really want to avoid caching? Like, tear down the hostapd instance and start a new one with a new random string.
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".

Sign in to add a comment