"Redeem Chrome Goodies" notification appears when no offers are available
Reported by
n2102410...@gmail.com,
Mar 14 2018
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 10176.76.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.190 Safari/537.36 Platform: 10176.76.0 (Official Build) stable-channel samus Steps to reproduce the problem: I just got the "Chrome Goodies: Redeem them before it is too late" notification. However, clicking on the notification does nothing. If I manually go to the Chromebook website, it shows that there are no offers available for my chromebook. What is the expected behavior? What went wrong? 1. Clicking on the notification does nothing (similar to https://bugs.chromium.org/p/chromium/issues/detail?id=396072) 2. You shouldn't send these notifications in the first place when there are no offers available. Note that issue 396072 is similar, but I figured I should file a new issue, since the notification shouldn't appear in the first place when there are no offers available. Apart from that, the old bug is evidently still not fixed, as clicking on the notification does nothing. Did this work before? N/A Chrome version: 64.0.3282.190 Channel: stable OS Version: 10176.76.0 Flash Version:
,
Mar 19 2018
Reassigning to the Goodies owner.
,
Mar 19 2018
I believe we decided to rip out the notification and it's just a matter of getting it done. It's difficult/impossible to get the notification right without transmitting the ECHO code which we can't do without explicit user permission. I'll see if I can target M68 for the change.
,
Mar 20 2018
stephenlin@ we are seeing more reports coming in from pixelbook users is this. is there a quicker interim solution to turn these off?
,
Mar 20 2018
Alex, maybe we can just make a quick simple change on the ECHO client to not send out any notifications, but leave most of the code in place for when you have more time to make sure it's safe to just rip out. For instance, I think if we just make echo.checkAndSendNotifications return immediately then no notifications will ever be sent. https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/master/echo/main.js#1049
,
Mar 26 2018
I also got this notification today.
,
Mar 27 2018
,
Mar 28 2018
,
Apr 3 2018
I'm making a change on the server side that should disable this message. Will on client side change next.
,
Apr 3 2018
Note that the server change will disable the message for newly activated devices only due to some caching on the client. The client change is necessary to drop the notification completely.
,
Apr 4 2018
,
Apr 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/21155950b72efac96401d61bdf1677aba82bd89f commit 21155950b72efac96401d61bdf1677aba82bd89f Author: Alex Butzier <abutzier@chromium.org> Date: Sat Apr 07 02:50:50 2018
,
Apr 8 2018
https://crrev.com/i/602659 will prevent any notifications being shown from ECHO. This fixes the immediate problem although additional clean up work is still needed. Fix will be in M67.
,
Jul 31
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ovanieva@chromium.org
, Mar 16 2018Owner: yoshiki@chromium.org
Status: Assigned (was: Unconfirmed)