New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821644 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

URLBlacklist policy not working for startup URLs

Project Member Reported by dpa...@chromium.org, Mar 14 2018

Issue description

This seems like a timing issue where the startup URL is successfully loaded before the policies have taken effect.

Repro steps (100% repro, only tried Linux), see screencast too:
 1) Set a policy for URLBlacklist, for example https://www.yahoo.com
 2) Go to chrome://settings and add that address as a startup URL.
 3) Close the browser and re-open.

Expected:
The blocked URL is not loaded.

Actual:
The blocked URL is loaded.

Note that refreshing the page, results in the "blocked" error message finally showing up.
 

Comment 1 by dpa...@chromium.org, Mar 14 2018

out.mp4
1.5 MB View Download

Comment 2 by zmin@chromium.org, Mar 14 2018

Labels: OS-Mac OS-Windows
Owner: georgesak@chromium.org
Status: Assigned (was: Untriaged)
I'm able to repo this on Windows so I think it's at least an issue on desktop (haven't tried ChromeOS yet)

Assign to Georges as this is an old policy and the original owner has left Chrome already.

Comment 3 by dpa...@chromium.org, Mar 14 2018

FYI, I tried this on 64.0.3274.0 (Linux) and it still reproduced, so not a recent regression (perhaps it has always been that way?).

Comment 4 by gov...@chromium.org, Mar 14 2018

dpapad@, could you pls try to repro this on M64 last stable version 64.0.3282.186?

Comment 5 by gov...@chromium.org, Mar 14 2018

Cc: pbomm...@chromium.org abdulsyed@chromium.org blumberg@chromium.org
Labels: M-65 M-66

Comment 6 by dpa...@chromium.org, Mar 14 2018

I am not aware of an easy way to get latest M64 locally, but also don't think is necessary.

This is not working on some M64 version, or M65, or ToT (67.0.3371.0). If it had been fixed and merged into any of previous releases, should be already working on ToT.

Comment 7 by gov...@chromium.org, Mar 14 2018

Labels: M-67
Not considering this as M65 stable blocker per comments #3, #6 and per internal group chat. Thank you.

Comment 8 by dougt@chromium.org, Mar 14 2018

georgesak, my theory is this:

the policy code uses a navigation throttle to enforce what is blocked.
the first time this navigation throttle is called, it accesses a keyed service which holds the actual block list data structure.
it takes time to parse this block list.
the throttle doesn't wait very long before deciding that there isn't anything in the block list, and then allows the url to load

One approach to fix this is to have the PolicyBlacklistService know that url_blacklist_manager_ hasn't started and return DEFER in PolicyBlacklistNavigationThrottle::WillStartRequest until the url_blacklist_manager_  is ready.  When it is ready, you can call the appropriate method on the navigation throttle to continue that request.

Happy to discuss.


Labels: OS-Android
Issue 838943 has been merged into this issue.
Labels: Hotlist-Enterprise-Fixit
I will take a stab at this one.
Cc: nicolaso@chromium.org

Sign in to add a comment