Switch cbuildbot generated links from Milo to Legoland. |
||||||||
Issue descriptionCurrently, when the PreCQ launcher annotates a CL with links the build, it uses Milo buildbot specific build links. We should update it to use Legoland links.
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/565bdc93604af2e2a0d7999321947e6dd80552da commit 565bdc93604af2e2a0d7999321947e6dd80552da Author: Don Garrett <dgarrett@google.com> Date: Wed Mar 14 21:17:39 2018 precq-launcher: Start using Legoland build details page. We intend to move to legoland build links everywhere. Start with the PreCQ launcher, so that it will be safe for it to start using swarming PreCQ builds. BUG= chromium:821618 TEST=run_tests Change-Id: Ie479a6c5a30ad1a320bfb5e2400f7caf72477636 Reviewed-on: https://chromium-review.googlesource.com/961737 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Reviewed-by: Jinjing Liang <jinjingl@google.com> Reviewed-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/565bdc93604af2e2a0d7999321947e6dd80552da/lib/tree_status.py [modify] https://crrev.com/565bdc93604af2e2a0d7999321947e6dd80552da/lib/tree_status_unittest.py [modify] https://crrev.com/565bdc93604af2e2a0d7999321947e6dd80552da/cbuildbot/stages/sync_stages.py
,
Mar 14 2018
,
Mar 14 2018
After going through more code, cbuildbot generally has build link generated buried under multiple levels of abstraction. To be sure I've gotten everything the PreCQ Launcher generates, I'm going to try and update everything I can.
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/942b97f8ecd7dc6cb8d61478b872f1d8c6846f3a commit 942b97f8ecd7dc6cb8d61478b872f1d8c6846f3a Author: Don Garrett <dgarrett@google.com> Date: Fri Mar 16 00:58:34 2018 cbuildbot_run: Switch more build links to Legoland. Switch the cbuildbot_run.ConstructDashboardURL() method to generate Legoland build details URLs if we have a buildbucket_id. This URL is used in a variety of places. Fallback to buildbot if there is no buildbucket_id, and don't change stage log links, which are currently believed to be unused. BUG= chromium:821618 TEST=run_tests Change-Id: I96c1482f4949e438993e3632cbd10975c79ac52b Reviewed-on: https://chromium-review.googlesource.com/963758 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/942b97f8ecd7dc6cb8d61478b872f1d8c6846f3a/cbuildbot/cbuildbot_run.py
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5 commit b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Mar 16 22:50:01 2018 Roll src/third_party/chromite/ 3b75c9d82..3ad8f333d (31 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567 $ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s' 2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."" 2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." 2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2] 2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." 2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket. 2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob" 2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. 2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob 2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland. 2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds. 2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues. 2018-03-14 ihf chromeos_config: add more arcnext experimental coverage. 2018-03-14 ayatane autotest-pre-cq: Remove this [1/2] 2018-03-14 norvez chromeos_config: remove dead code 2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning. 2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation. 2017-09-14 craigb image_test: Remove check that kernel is not ELF. 2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental" 2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq" 2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config 2018-03-13 achuith cbuildbot: Add missing files to index. 2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion 2018-03-13 dgarrett precq-launcher: Start using Legoland build details page. 2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest. 2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq 2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental 2018-03-12 haddowk [chromite] Make guado_moblab important again 2018-03-13 chrome-bot Update config settings by config-updater. 2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite 2018-03-12 yunlian Enable ThinLTO on all AMD64 boards. 2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON. Created with: roll-dep src/third_party/chromite BUG=821930, 822517 , 821615 ,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib6aaddf338307e994865a092ecb322a432148692 Reviewed-on: https://chromium-review.googlesource.com/967273 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543855} [modify] https://crrev.com/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5/DEPS
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/67b4c6acbd3ad56f12c77bd95d93521b5ca3ba1c commit 67b4c6acbd3ad56f12c77bd95d93521b5ca3ba1c Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 24 00:29:44 2018 som_alerts_dispatcher: Switch to Legoland build URLs. Update the build URL used. BUG= chromium:821618 TEST=run_tests Change-Id: If5af7183410f908432c0e44abf3c9035f8df8520 Reviewed-on: https://chromium-review.googlesource.com/963760 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/67b4c6acbd3ad56f12c77bd95d93521b5ca3ba1c/scripts/som_alerts_dispatcher.py
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cead4ad6e9dca5a39e9ad57dd3e5b80af8270d82 commit cead4ad6e9dca5a39e9ad57dd3e5b80af8270d82 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Mar 24 07:23:29 2018 Roll src/third_party/chromite/ a03592f3d..e6139afa1 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a03592f3d2e2..e6139afa10f8 $ git log a03592f3d..e6139afa1 --date=short --no-merges --format='%ad %ae %s' 2018-03-23 chrome-bot Update config settings by config-updater. 2018-03-14 dgarrett som_alerts_dispatcher: Switch to Legoland build URLs. Created with: roll-dep src/third_party/chromite BUG= chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iace3252ba634e64e9c089d36e06a2fca77cdbba6 Reviewed-on: https://chromium-review.googlesource.com/979337 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545680} [modify] https://crrev.com/cead4ad6e9dca5a39e9ad57dd3e5b80af8270d82/DEPS
,
Mar 30 2018
,
Mar 30 2018
,
Apr 6 2018
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/470162f4a95bdc9d6856090a8177a52b8bffa908 commit 470162f4a95bdc9d6856090a8177a52b8bffa908 Author: Don Garrett <dgarrett@google.com> Date: Sat Apr 14 04:37:13 2018 validation_pool: Switch to Legoland build links. Validation pool generates build links from time to time. Switch it to using Legoland where possible. Also, switch most ValidationPool constructors to calling with all keyword arguments to help ensure they are populated as intended. BUG= chromium:821618 TEST=run_tests + validation_pool_unittest --network Change-Id: I88dc9ba862bde7c8a925b914c149976605c77887 Reviewed-on: https://chromium-review.googlesource.com/963759 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/470162f4a95bdc9d6856090a8177a52b8bffa908/cbuildbot/validation_pool.py [modify] https://crrev.com/470162f4a95bdc9d6856090a8177a52b8bffa908/cbuildbot/validation_pool_unittest.py [modify] https://crrev.com/470162f4a95bdc9d6856090a8177a52b8bffa908/cbuildbot/stages/sync_stages.py
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/14212208e57191f83d17533ac2af38ff88d14d33 commit 14212208e57191f83d17533ac2af38ff88d14d33 Author: Don Garrett <dgarrett@google.com> Date: Sat Apr 14 04:37:14 2018 report_stages: Use Logoland build URL for master builder. Switch the master build URL to Legoland build details page. BUG= chromium:821618 TEST=run_tests Change-Id: Ibbc03b5a60e07c8cf3708c7beaf8e9eb78393eda Reviewed-on: https://chromium-review.googlesource.com/963781 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/14212208e57191f83d17533ac2af38ff88d14d33/cbuildbot/stages/report_stages.py
,
Apr 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8957aa60025e2a731d8709694a09ff60a2ada2b0 commit 8957aa60025e2a731d8709694a09ff60a2ada2b0 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 11:37:01 2018 Roll src/third_party/chromite/ 2e290076c..c90ccbc26 (8 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e290076c8be..c90ccbc26d04 $ git log 2e290076c..c90ccbc26 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf chromeos_config: mark eve-arcnext-chrome-pfq not important. 2018-04-13 cmtice [chromite] Add script to set up env for locally testing fuzz targets. 2018-04-13 marcochen soraka: remove sign type - factory and accessory_rwsig 2017-11-03 dgarrett Reland "config_lib: Remove OverrideConfigForTrybot." 2018-04-13 dgarrett buildbucket_lib: Remove _ah from URLs. 2018-04-13 bmgordon cros lint: Look up pylintrc for all python files 2018-03-14 dgarrett report_stages: Use Logoland build URL for master builder. 2018-03-14 dgarrett validation_pool: Switch to Legoland build links. Created with: roll-dep src/third_party/chromite BUG= chromium:832736 , chromium:776955 ,chromium:None,chromium:None,chromium:821618,chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6c3d1f6d83d8bfb7ea269da65c9f09901668cb37 Reviewed-on: https://chromium-review.googlesource.com/1013395 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550893} [modify] https://crrev.com/8957aa60025e2a731d8709694a09ff60a2ada2b0/DEPS
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8957aa60025e2a731d8709694a09ff60a2ada2b0 commit 8957aa60025e2a731d8709694a09ff60a2ada2b0 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Apr 14 11:37:01 2018 Roll src/third_party/chromite/ 2e290076c..c90ccbc26 (8 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/2e290076c8be..c90ccbc26d04 $ git log 2e290076c..c90ccbc26 --date=short --no-merges --format='%ad %ae %s' 2018-04-13 ihf chromeos_config: mark eve-arcnext-chrome-pfq not important. 2018-04-13 cmtice [chromite] Add script to set up env for locally testing fuzz targets. 2018-04-13 marcochen soraka: remove sign type - factory and accessory_rwsig 2017-11-03 dgarrett Reland "config_lib: Remove OverrideConfigForTrybot." 2018-04-13 dgarrett buildbucket_lib: Remove _ah from URLs. 2018-04-13 bmgordon cros lint: Look up pylintrc for all python files 2018-03-14 dgarrett report_stages: Use Logoland build URL for master builder. 2018-03-14 dgarrett validation_pool: Switch to Legoland build links. Created with: roll-dep src/third_party/chromite BUG= chromium:832736 , chromium:776955 ,chromium:None,chromium:None,chromium:821618,chromium:821618 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6c3d1f6d83d8bfb7ea269da65c9f09901668cb37 Reviewed-on: https://chromium-review.googlesource.com/1013395 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#550893} [modify] https://crrev.com/8957aa60025e2a731d8709694a09ff60a2ada2b0/DEPS
,
Jun 12 2018
I think this is done, I don't currently know of any more cases. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dgarr...@chromium.org
, Mar 13 2018