Launch limited PreCQ in swarming. |
|||||
Issue descriptionIn order to stress test swarming a little more, we should start running a limited number of pre-cq builders via swarming. "autotest-pre-cq" and "chromite-pre-cq" are reasonable first choices, since they are mostly ChromeOS Infra team specific.
,
Mar 13 2018
We also need to update the UI links the PreCQ Launcher annotates CLs with to use Legoland, so the links will work for swarming builds.
,
Mar 14 2018
,
Mar 14 2018
Actually, autotest-pre-cq is just broken. Looks like the two reasonable choices are: 1) chromeos-infra-puppet-pre-cq 2) chromite-pre-cq
,
Mar 15 2018
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/742cd23e6fcf2149321b774286606b0d2a51a377 commit 742cd23e6fcf2149321b774286606b0d2a51a377 Author: Don Garrett <dgarrett@google.com> Date: Fri Mar 16 06:44:10 2018 pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. A fairly hacky approach to using swarming when running the chromeos-infra-puppet-pre-cq build config. I think the hack is acceptable, since it's only for very short term use, and a cleaner solution would involve a substantially larger portion of the code base. BUG= chromium:821615 CQ-DEPEND=CL:961737 TEST=run_tests cros tryjob --swarming chromeos-infra-puppet-pre-cq Change-Id: Ifb44f7f9e7fda9951391d6f3fe101aa2fb3e8764 Reviewed-on: https://chromium-review.googlesource.com/961144 Commit-Ready: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/742cd23e6fcf2149321b774286606b0d2a51a377/cbuildbot/stages/sync_stages.py
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/41f8bacb098d11868a02e506347a9f86cfb8ef3e commit 41f8bacb098d11868a02e506347a9f86cfb8ef3e Author: Don Garrett <dgarrett@chromium.org> Date: Fri Mar 16 18:54:46 2018 Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." This reverts commit 742cd23e6fcf2149321b774286606b0d2a51a377. Reason for revert: PreCQLauncher crashing with permission error. Original change's description: > pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. > > A fairly hacky approach to using swarming when running the > chromeos-infra-puppet-pre-cq build config. I think the hack is > acceptable, since it's only for very short term use, and a cleaner > solution would involve a substantially larger portion of the code > base. > > BUG= chromium:821615 > CQ-DEPEND=CL:961737 > TEST=run_tests > cros tryjob --swarming chromeos-infra-puppet-pre-cq > > Change-Id: Ifb44f7f9e7fda9951391d6f3fe101aa2fb3e8764 > Reviewed-on: https://chromium-review.googlesource.com/961144 > Commit-Ready: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Don Garrett <dgarrett@chromium.org> Bug: chromium:821615 Change-Id: Icbc5351ef9408aff4a9ffa1db3b2ff9dd58f6795 Reviewed-on: https://chromium-review.googlesource.com/967041 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/41f8bacb098d11868a02e506347a9f86cfb8ef3e/cbuildbot/stages/sync_stages.py
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/055838a08055f0bbcca1eff0717e1f4a8f6c27cf commit 055838a08055f0bbcca1eff0717e1f4a8f6c27cf Author: Don Garrett <dgarrett@chromium.org> Date: Fri Mar 16 21:07:37 2018 Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." This reverts commit 41f8bacb098d11868a02e506347a9f86cfb8ef3e. Reason for revert: A work around permission change is in place from https://crbug.com/822840, so trying again. Original change's description: > Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." > > This reverts commit 742cd23e6fcf2149321b774286606b0d2a51a377. > > Reason for revert: PreCQLauncher crashing with permission error. > > Original change's description: > > pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. > > > > A fairly hacky approach to using swarming when running the > > chromeos-infra-puppet-pre-cq build config. I think the hack is > > acceptable, since it's only for very short term use, and a cleaner > > solution would involve a substantially larger portion of the code > > base. > > > > BUG= chromium:821615 > > CQ-DEPEND=CL:961737 > > TEST=run_tests > > cros tryjob --swarming chromeos-infra-puppet-pre-cq > > > > Change-Id: Ifb44f7f9e7fda9951391d6f3fe101aa2fb3e8764 > > Reviewed-on: https://chromium-review.googlesource.com/961144 > > Commit-Ready: Don Garrett <dgarrett@chromium.org> > > Tested-by: Don Garrett <dgarrett@chromium.org> > > Reviewed-by: Don Garrett <dgarrett@chromium.org> > > Bug: chromium:821615 > Change-Id: Icbc5351ef9408aff4a9ffa1db3b2ff9dd58f6795 > Reviewed-on: https://chromium-review.googlesource.com/967041 > Reviewed-by: Don Garrett <dgarrett@chromium.org> > Commit-Queue: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> Bug: chromium:821615 Change-Id: Ib0f865fae67a8c49ede90b7e80cc7bcc6443ba90 Reviewed-on: https://chromium-review.googlesource.com/967071 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/055838a08055f0bbcca1eff0717e1f4a8f6c27cf/cbuildbot/stages/sync_stages.py
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3ad8f333d56796e53b0b98d4a8c9346b423985e2 commit 3ad8f333d56796e53b0b98d4a8c9346b423985e2 Author: Don Garrett <dgarrett@chromium.org> Date: Fri Mar 16 21:25:21 2018 Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."" This reverts commit 055838a08055f0bbcca1eff0717e1f4a8f6c27cf. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." > > This reverts commit 41f8bacb098d11868a02e506347a9f86cfb8ef3e. > > Reason for revert: > > A work around permission change is in place from https://crbug.com/822840, so trying again. > > Original change's description: > > Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." > > > > This reverts commit 742cd23e6fcf2149321b774286606b0d2a51a377. > > > > Reason for revert: PreCQLauncher crashing with permission error. > > > > Original change's description: > > > pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. > > > > > > A fairly hacky approach to using swarming when running the > > > chromeos-infra-puppet-pre-cq build config. I think the hack is > > > acceptable, since it's only for very short term use, and a cleaner > > > solution would involve a substantially larger portion of the code > > > base. > > > > > > BUG= chromium:821615 > > > CQ-DEPEND=CL:961737 > > > TEST=run_tests > > > cros tryjob --swarming chromeos-infra-puppet-pre-cq > > > > > > Change-Id: Ifb44f7f9e7fda9951391d6f3fe101aa2fb3e8764 > > > Reviewed-on: https://chromium-review.googlesource.com/961144 > > > Commit-Ready: Don Garrett <dgarrett@chromium.org> > > > Tested-by: Don Garrett <dgarrett@chromium.org> > > > Reviewed-by: Don Garrett <dgarrett@chromium.org> > > > > Bug: chromium:821615 > > Change-Id: Icbc5351ef9408aff4a9ffa1db3b2ff9dd58f6795 > > Reviewed-on: https://chromium-review.googlesource.com/967041 > > Reviewed-by: Don Garrett <dgarrett@chromium.org> > > Commit-Queue: Don Garrett <dgarrett@chromium.org> > > Tested-by: Don Garrett <dgarrett@chromium.org> > > Bug: chromium:821615 > Change-Id: Ib0f865fae67a8c49ede90b7e80cc7bcc6443ba90 > Reviewed-on: https://chromium-review.googlesource.com/967071 > Reviewed-by: Don Garrett <dgarrett@chromium.org> > Commit-Queue: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> Bug: chromium:821615 Change-Id: I77e5e08857c604fe198e15bf6a57ba66bb392c20 Reviewed-on: https://chromium-review.googlesource.com/967072 Reviewed-by: Don Garrett <dgarrett@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Tested-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/3ad8f333d56796e53b0b98d4a8c9346b423985e2/cbuildbot/stages/sync_stages.py
,
Mar 16 2018
More failures that look like: ubmitting tryjob... Successfully sent PUT request to [buildbucket_bucket:master.chromiumos.tryserver] with [config:chromeos-infra-puppet-pre-cq] [buildbucket_id:8951862746346872480]. Tryjob submitted! To view your tryjobs, visit: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8951862746346872480 [1;31m14:23:57: ERROR: <type 'exceptions.TypeError'>: 'NoneType' object is not iterable Traceback (most recent call last): File "/b/c/cbuild/repository/chromite/lib/failures_lib.py", line 229, in wrapped_functor return functor(*args, **kwargs) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 2162, in PerformStage builder_run=self._run) File "/b/c/cbuild/repository/chromite/cbuildbot/validation_pool.py", line 501, in AcquirePool if pool.AcquireChanges(gerrit_query, ready_fn, change_filter): File "/b/c/cbuild/repository/chromite/cbuildbot/validation_pool.py", line 414, in AcquireChanges self, self.candidates, self.non_manifest_changes) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 2119, in ProcessChanges self._LaunchPreCQsIfNeeded(pool, changes) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1968, in _LaunchPreCQsIfNeeded self.LaunchPreCQs(build_id, db, pool, configs, plan) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1534, in LaunchPreCQs config_buildbucket_id_map = self._LaunchTrybots(pool, configs, plan=plan) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1515, in _LaunchTrybots pool, configs, plan, sanity_check_build) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1449, in _LaunchTrybotsReal for config in configs: TypeError: 'NoneType' object is not iterable [0m 14:23:57: INFO: Translating result <type 'exceptions.TypeError'>: 'NoneType' object is not iterable Traceback (most recent call last): File "/b/c/cbuild/repository/chromite/lib/failures_lib.py", line 229, in wrapped_functor return functor(*args, **kwargs) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 2162, in PerformStage builder_run=self._run) File "/b/c/cbuild/repository/chromite/cbuildbot/validation_pool.py", line 501, in AcquirePool if pool.AcquireChanges(gerrit_query, ready_fn, change_filter): File "/b/c/cbuild/repository/chromite/cbuildbot/validation_pool.py", line 414, in AcquireChanges self, self.candidates, self.non_manifest_changes) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 2119, in ProcessChanges self._LaunchPreCQsIfNeeded(pool, changes) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1968, in _LaunchPreCQsIfNeeded self.LaunchPreCQs(build_id, db, pool, configs, plan) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1534, in LaunchPreCQs config_buildbucket_id_map = self._LaunchTrybots(pool, configs, plan=plan) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1515, in _LaunchTrybots pool, configs, plan, sanity_check_build) File "/b/c/cbuild/repository/chromite/cbuildbot/stages/sync_stages.py", line 1449, in _LaunchTrybotsReal for config in configs: TypeError: 'NoneType' object is not iterable
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5 commit b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Fri Mar 16 22:50:01 2018 Roll src/third_party/chromite/ 3b75c9d82..3ad8f333d (31 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3b75c9d82ebf..3ad8f333d567 $ git log 3b75c9d82..3ad8f333d --date=short --no-merges --format='%ad %ae %s' 2018-03-16 dgarrett Revert "Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq."" 2018-03-16 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." 2018-03-14 ayatane autotest-pre-cq: Remove builder and stage [2/2] 2018-03-16 dgarrett Revert "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." 2018-03-15 dgarrett chromeos_config: Move fuzzer builds into new bucket. 2018-03-16 dgarrett Revert "commands: RunBranchUtilTest -> RunLocalTryjob" 2018-03-13 dgarrett pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. 2018-02-07 dgarrett commands: RunBranchUtilTest -> RunLocalTryjob 2018-03-14 dgarrett cbuildbot_run: Switch more build links to Legoland. 2018-03-13 dgarrett swarming_lib: Remove SWARMING_TASK_ID from cmds. 2018-03-08 dgarrett moblab_vm_unitest: Fix lint issues. 2018-03-14 ihf chromeos_config: add more arcnext experimental coverage. 2018-03-14 ayatane autotest-pre-cq: Remove this [1/2] 2018-03-14 norvez chromeos_config: remove dead code 2018-03-09 dgarrett summarize_build_stats: Add blank line at beginning. 2018-01-09 dgarrett cros tryjob: Remove buildbot URL generation. 2017-09-14 craigb image_test: Remove check that kernel is not ELF. 2018-03-15 ihf Revert "chromeos_config: temporarily mark eve-arcnext-paladin experimental" 2018-03-15 ihf Revert "chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq" 2018-03-13 lhchavez chromeos_config: Add betty-arcnext builder config 2018-03-13 achuith cbuildbot: Add missing files to index. 2018-03-13 akeshet completion_stages: add a has_important_slave metric to master completion 2018-03-13 dgarrett precq-launcher: Start using Legoland build details page. 2018-03-08 dgarrett chromite-pre-cq: Disable CidbIntegrationTest. 2018-03-14 akeshet chromeos_config: temporarily experimental eve-arcnext-mst-android-pfq 2018-03-13 akeshet chromeos_config: temporarily mark eve-arcnext-paladin experimental 2018-03-12 haddowk [chromite] Make guado_moblab important again 2018-03-13 chrome-bot Update config settings by config-updater. 2018-03-12 gmeinke chromium-config: replace cros_config_host_py in chromite 2018-03-12 yunlian Enable ThinLTO on all AMD64 boards. 2018-03-12 achuith cbuildbot: Log timing of GenerateUploadJSON. Created with: roll-dep src/third_party/chromite BUG=821930, 822517 , 821615 ,None,821618,821227,None,821664,821930,None,815377,747385,461595,821664,821664,811989,819419,821618,820305,821664,821664,819017,813442,707803,811989 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib6aaddf338307e994865a092ecb322a432148692 Reviewed-on: https://chromium-review.googlesource.com/967273 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543855} [modify] https://crrev.com/b8e7c2d9a192a0e7c441c6f34284fea6ef68dcd5/DEPS
,
Mar 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f2ff9cbcb9732268ad97572adc4d70ed19b151ef commit f2ff9cbcb9732268ad97572adc4d70ed19b151ef Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 17 00:24:25 2018 Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." This is a reland of 742cd23e6fcf2149321b774286606b0d2a51a377 The original hack could crash if the swarming build config was the only build config being tested, and left no non-swarming build configs. This is the normal case for lab puppet changes. Original change's description: > pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq. > > A fairly hacky approach to using swarming when running the > chromeos-infra-puppet-pre-cq build config. I think the hack is > acceptable, since it's only for very short term use, and a cleaner > solution would involve a substantially larger portion of the code > base. > > BUG= chromium:821615 > CQ-DEPEND=CL:961737 > TEST=run_tests > cros tryjob --swarming chromeos-infra-puppet-pre-cq > > Change-Id: Ifb44f7f9e7fda9951391d6f3fe101aa2fb3e8764 > Reviewed-on: https://chromium-review.googlesource.com/961144 > Commit-Ready: Don Garrett <dgarrett@chromium.org> > Tested-by: Don Garrett <dgarrett@chromium.org> > Reviewed-by: Don Garrett <dgarrett@chromium.org> BUG= chromium:821615 TEST=run_tests Change-Id: Ia3694e110d6934d98d287848398dcf73694f3d97 Reviewed-on: https://chromium-review.googlesource.com/967073 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/f2ff9cbcb9732268ad97572adc4d70ed19b151ef/cbuildbot/stages/sync_stages.py
,
Mar 17 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/215eac7d6324a1e6f170b6cc4d354d860a2864b9 commit 215eac7d6324a1e6f170b6cc4d354d860a2864b9 Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 17 01:06:51 2018
,
Mar 17 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/0ebc79a7c2a8bb6b2231a9b37e9050de7e84da1d commit 0ebc79a7c2a8bb6b2231a9b37e9050de7e84da1d Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 17 01:14:11 2018
,
Mar 17 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/51ca8053398776b6fc68c8a823df801451388c49 commit 51ca8053398776b6fc68c8a823df801451388c49 Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 17 01:55:20 2018
,
Mar 17 2018
This is now running and seem to be working. This CL was tested in swarming and submitted: https://crrev.com/i/589347 http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8951850119013329232 This CL is being tested, and I expect it to be rejected. If that works as expected, I'll declare this fixed. https://crrev.com/i/590240
,
Mar 17 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/ca641d4dd5d8e84d1d408d7d61477e3e1afc29db commit ca641d4dd5d8e84d1d408d7d61477e3e1afc29db Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 17 02:36:48 2018
,
Mar 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/708c12f17449158faa58d6191178080fc849e613 commit 708c12f17449158faa58d6191178080fc849e613 Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Sat Mar 17 02:45:33 2018 Roll src/third_party/chromite/ 3ad8f333d..f2ff9cbcb (1 commit) https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ad8f333d567..f2ff9cbcb973 $ git log 3ad8f333d..f2ff9cbcb --date=short --no-merges --format='%ad %ae %s' 2018-03-13 dgarrett Reland "pre_cq_launcher: Swarming for chromeos-infra-puppet-pre-cq." Created with: roll-dep src/third_party/chromite BUG= 821615 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I15450adb1a013377fa94601083205f8316ad3000 Reviewed-on: https://chromium-review.googlesource.com/967515 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543923} [modify] https://crrev.com/708c12f17449158faa58d6191178080fc849e613/DEPS
,
Mar 17 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/7c25953ed4bee9f420e0766a8b5a24f5581ac5cc commit 7c25953ed4bee9f420e0766a8b5a24f5581ac5cc Author: Don Garrett <dgarrett@google.com> Date: Sat Mar 17 03:05:35 2018
,
Mar 19 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dgarr...@chromium.org
, Mar 13 2018