New issue
Advanced search Search tips

Issue 821609 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Support per-analyzer reporting disabling and user whitelists

Project Member Reported by qyears...@chromium.org, Mar 13 2018 
Currently, the Gerrit details for a project have reporting_disabled and whitelisted_groups fields to control who gets gerrit reporting and make it easier to onboard projects incrementally.

In order to make onboarding new analyzers incrementally easier, we could include a similar thing in the function specification. Whether or not reporting is enabled for a particular analyzer on a particular run would then depend on some combination of the project and analyzer config.

whitelisted_group and disable_reporting could be extracted to a new message type (e.g. FilteringRule).

We could create an intermediary state to avoid breaking prod: (1) update config to include both FilteringRule and whitelisted/disabled info, (2) update service to accept either, (3) remove the old config.

Related code search link: 
https://cs.chromium.org/chromium/infra/go/src/infra/tricium/api/v1/config.proto?l=120
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56f6bc94eae3c761aedf9468dbe8d4c0471899e7

commit 56f6bc94eae3c761aedf9468dbe8d4c0471899e7
Author: Chris Hamilton <chrisha@chromium.org>
Date: Thu Mar 15 20:43:30 2018

Fix trailing garbage when pasting from clipboard.

A previous CL used GlobalSize as the explicit size of clipboard data, removing
trailing nulls. This was a fix to open-ended copying logic that would
occasionally read past the end of the buffer for clipboard entries not
containing terminating nulls. It turns out that some clipboard entries
contain much less data than the entire buffer, and don't pad out to the
end with terminating nulls (only seen on Win7 when copying from command line or
other console apps). The fix is to copy until first null or end of the
buffer.

BUG=821609

Change-Id: Id0e733ccf10b0f7d2f7ec401a584d7f14d4fd063
Reviewed-on: https://chromium-review.googlesource.com/964722
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543487}
[modify] https://crrev.com/56f6bc94eae3c761aedf9468dbe8d4c0471899e7/ui/base/clipboard/clipboard_win.cc

Comment 2 by chrisha@chromium.org, Mar 15 2018 

Yup, definitely a mistaken bug number. The above CL was meant for 821690 :/

Comment 3 by qyears...@chromium.org, Jun 15 2018

Components: Infra>Platform>Tricium

Comment 4 by qyears...@chromium.org, Jun 15 2018

Components: -Infra>CodeAnalysis
Labels: -Tricium
►

Sign in to add a comment