New issue
Advanced search Search tips

Issue 821608 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Eng tracking: new overview ui

Project Member Reported by sammiequon@chromium.org, Mar 13 2018

Issue description

This is a tracking bug for the new overview ui.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e50412fb9216127a3818a3682e94633d7af7da66

commit e50412fb9216127a3818a3682e94633d7af7da66
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Mar 14 18:41:45 2018

cros: Convert switch to feature for new overview ui.

Convert to feature which is enabled by default.

Test: manual
Bug:  821608 
Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616
Reviewed-on: https://chromium-review.googlesource.com/961721
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543139}
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/public/cpp/ash_features.h
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/wm/overview/overview_utils.h
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/chrome/browser/about_flags.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e50412fb9216127a3818a3682e94633d7af7da66/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2c5f123950f789593d65aea34ba54abdf8a7f9

commit bc2c5f123950f789593d65aea34ba54abdf8a7f9
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Wed Mar 14 21:40:41 2018

Revert "cros: Convert switch to feature for new overview ui."

This reverts commit e50412fb9216127a3818a3682e94633d7af7da66.

Reason for revert:  crbug.com/821999  enabled test now failing on chromeos

Original change's description:
> cros: Convert switch to feature for new overview ui.
> 
> Convert to feature which is enabled by default.
> 
> Test: manual
> Bug:  821608 
> Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616
> Reviewed-on: https://chromium-review.googlesource.com/961721
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543139}

TBR=sky@chromium.org,sammiequon@chromium.org

Change-Id: I92ce3f93cb88cef92e242fbbd6338cbdac528cdd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  821608 
Reviewed-on: https://chromium-review.googlesource.com/962837
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543205}
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/public/cpp/ash_features.h
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/wm/overview/overview_utils.h
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/chrome/browser/about_flags.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/bc2c5f123950f789593d65aea34ba54abdf8a7f9/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4b36d18b7bf27ff793846ff7d554a0176a87d45

commit e4b36d18b7bf27ff793846ff7d554a0176a87d45
Author: Sammie Quon <sammiequon@google.com>
Date: Fri Mar 16 23:39:32 2018

Reland "cros: Convert switch to feature for new overview ui."

This is a reland of e50412fb9216127a3818a3682e94633d7af7da66

Original change's description:
> cros: Convert switch to feature for new overview ui.
> 
> Convert to feature which is enabled by default.
> 
> Test: manual
> Bug:  821608 
> Change-Id: If513c4d2a6bdfd4197525d7922d99cfc01f4c616
> Reviewed-on: https://chromium-review.googlesource.com/961721
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543139}

Bug:  821608 
Change-Id: Id240ddfa8b5551209c61612e406a4a88d5578d02
Reviewed-on: https://chromium-review.googlesource.com/963585
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543871}
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/public/cpp/ash_features.h
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/wm/overview/overview_utils.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/wm/overview/overview_utils.h
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/ash/wm/splitview/split_view_controller_unittest.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/chrome/browser/about_flags.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/e4b36d18b7bf27ff793846ff7d554a0176a87d45/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)
The flag has been removed so marking as fixed.

Sign in to add a comment