Crash after closing a 2nd embedder widget |
|||
Issue descriptionRepro: 1. Patch https://chromium-review.googlesource.com/c/chromium/src/+/959613 2. Build an run chrome in mash mode 3. Click "Power/Shutdown" icon in system tray bubble that creates a widget to embed a WebContents using 4. Repeat step 3 to create a 2nd window; 5. Close either of the two embedder windows Crash happens at step 5. Looks like window server try to focus the embedded window, whose root window is the window for embed roots and does not have focus client. ==== [59553:59553:0313/143532.469293:FATAL:focus_synchronizer.cc(46)] Check failed: client::GetFocusClient(root). #0 0x7f80e7388a0d base::debug::StackTrace::StackTrace() #1 0x7f80e738703c base::debug::StackTrace::StackTrace() #2 0x7f80e74083fd logging::LogMessage::~LogMessage() #3 0x7f80dc0c054b aura::FocusSynchronizer::SetFocusFromServer() #4 0x7f80dc112bd1 aura::WindowTreeClient::OnWindowFocused() #5 0x7f80dc2601f0 ui::mojom::WindowTreeClientStubDispatch::Accept() #6 0x7f80dc12ce43 ui::mojom::WindowTreeClientStub<>::Accept() #7 0x7f80e58fed28 mojo::InterfaceEndpointClient::HandleValidatedMessage() #8 0x7f80e58fd801 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept()
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f99b42d4da45af887f3a0a6777364ce97551152f commit f99b42d4da45af887f3a0a6777364ce97551152f Author: Scott Violet <sky@chromium.org> Date: Fri Mar 16 16:48:07 2018 aura: make the EmbedRoot's window have a FocusClient This is needed to handle focus changes correctly. The focus client in this case is extremely minimal. BUG= 821602 TEST=covered by test Change-Id: I6e1cbd686edf8e0080b8a21a28c3ddeae4e640a4 Reviewed-on: https://chromium-review.googlesource.com/965445 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543728} [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/mus/embed_root.cc [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/mus/embed_root.h [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/mus/focus_synchronizer.h [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/mus/window_tree_client_unittest.cc [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/test/mus/window_tree_client_private.cc [modify] https://crrev.com/f99b42d4da45af887f3a0a6777364ce97551152f/ui/aura/test/mus/window_tree_client_private.h
,
Mar 20 2018
,
Mar 20 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sky@chromium.org
, Mar 15 2018