New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821599 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 815356



Sign in to add a comment

update_engine now supports hash_sha256 in omaha response, but devserver not yet

Project Member Reported by ahass...@chromium.org, Mar 13 2018

Issue description

With the new update engine aosp merge, update engine now supports hash_sha256 in the omaha response for a package. But devserver does not support it yet. Add this value for devserver.
 
Blocking: 815356
Cc: dgarr...@chromium.org moisesos...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/9e2adaebc313a9d73b19519c69fe90f3c58e33d8

commit 9e2adaebc313a9d73b19519c69fe90f3c58e33d8
Author: Amin Hassani <ahassani@google.com>
Date: Wed Mar 14 21:21:48 2018

autoupdate: Set the hash_sha256 in devserver (omaha) response

The new changes in update_engine requires the new hex based sha256 hash sent by
omaha to be checked. But, currently in devserver we only sent base64 ecndoed
sha256. This CL adds hash_sha256 in the package tag of the response by
calculating the hex based sha256 hash of the payload.

BUG= chromium:821599 
TEST=cros flash

Change-Id: I4449d90513db2dcd1424a6693ec7ce172135d689
Reviewed-on: https://chromium-review.googlesource.com/961586
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/9e2adaebc313a9d73b19519c69fe90f3c58e33d8/autoupdate_lib.py

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/f9265b986d2e3be17338e7bd66c04c6912220f44

commit f9265b986d2e3be17338e7bd66c04c6912220f44
Author: Amin Hassani <ahassani@google.com>
Date: Thu Apr 05 23:45:40 2018

autoupdate: Set the hash_sha256 in devserver (omaha) response

The new changes in update_engine requires the new hex based sha256 hash sent by
omaha to be checked. But, currently in devserver we only sent base64 ecndoed
sha256. This CL adds hash_sha256 in the package tag of the response by
calculating the hex based sha256 hash of the payload.

BUG= chromium:821599 
TEST=cros flash

Change-Id: I4449d90513db2dcd1424a6693ec7ce172135d689
Reviewed-on: https://chromium-review.googlesource.com/961586
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
(cherry picked from commit 9e2adaebc313a9d73b19519c69fe90f3c58e33d8)
Reviewed-on: https://chromium-review.googlesource.com/998656
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/f9265b986d2e3be17338e7bd66c04c6912220f44/autoupdate_lib.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/dev-util/+/d33e68f8190b0173c32f5f48e1e9704217231502

commit d33e68f8190b0173c32f5f48e1e9704217231502
Author: Amin Hassani <ahassani@google.com>
Date: Thu May 03 21:44:44 2018

autoupdate: Set the hash_sha256 in devserver (omaha) response

The new changes in update_engine requires the new hex based sha256 hash sent by
omaha to be checked. But, currently in devserver we only sent base64 ecndoed
sha256. This CL adds hash_sha256 in the package tag of the response by
calculating the hex based sha256 hash of the payload.

BUG= chromium:821599 
TEST=cros flash

Change-Id: I4449d90513db2dcd1424a6693ec7ce172135d689
Reviewed-on: https://chromium-review.googlesource.com/961586
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
(cherry picked from commit 9e2adaebc313a9d73b19519c69fe90f3c58e33d8)
Reviewed-on: https://chromium-review.googlesource.com/1043165
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/d33e68f8190b0173c32f5f48e1e9704217231502/autoupdate_lib.py

Sign in to add a comment