New issue
Advanced search Search tips

Issue 821595 link

Starred by 2 users
Status: Fixed
Owner:
g...@chromium.org
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Task



Sign in to add a comment

Grouping bug: Performance reports for AFDO on Chrome for Linux

Project Member Reported by g...@chromium.org, Mar 13 2018 
https://pinpoint-dot-chromeperf.appspot.com/ is the only thing I can really test Chrome for Linux perf on. Since it apparently posts to bugs for free, this is where I plan to put those reports.

The 'parent issue' for this is  issue 805098 . Not posting the reports directly there as a way to reduce noise on the AFDO bug.

Comment 1 by g...@chromium.org, Mar 13 2018 

Since I didn't think of this earlier, here are the runs so far:

system_health.common_desktop: https://pinpoint-dot-chromeperf.appspot.com/job/16ee436e440000

rasterize_and_record_micro.top_25: https://pinpoint-dot-chromeperf.appspot.com/job/14ece91e440

thread_times.key_silk_cases: https://pinpoint-dot-chromeperf.appspot.com/job/12edd00e440000 && https://pinpoint-dot-chromeperf.appspot.com/job/14da1c4e440000

smoothness.tough_canvas_cases: https://pinpoint-dot-chromeperf.appspot.com/job/14acad5e440000

Comment 2 by g...@chromium.org, Mar 14 2018 

Rerun of thread_times.key_silk_cases: https://pinpoint-dot-chromeperf.appspot.com/job/14ce386e440000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Mar 20 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/14291919440000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Mar 20 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1000c969440000
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Mar 21 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1088d405440000
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Mar 21 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/17d1e44d440000
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Mar 21 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1488d405440000
Project Member

Comment 16 by 42576172...@developer.gserviceaccount.com, Mar 21 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/17b60729440000
Project Member

Comment 17 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/104e7095440000
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/1440fb35440000
Project Member

Comment 22 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1688d405440000
Project Member

Comment 23 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/12b00ac9440000
Project Member

Comment 24 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/16c65c95440000
Project Member

Comment 28 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/1531e44d440000
Project Member

Comment 29 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/134bc3b9440000
Project Member

Comment 30 by 42576172...@developer.gserviceaccount.com, Mar 22 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/12bb9e95440000
Project Member

Comment 32 by 42576172...@developer.gserviceaccount.com, Mar 29 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14b4ed97440000
Project Member

Comment 36 by 42576172...@developer.gserviceaccount.com, Apr 3 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/16bfe7ef440000
Project Member

Comment 37 by 42576172...@developer.gserviceaccount.com, Apr 3 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12a1dfef440000
Project Member

Comment 38 by 42576172...@developer.gserviceaccount.com, Apr 3 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14b5603f440000
Project Member

Comment 40 by 42576172...@developer.gserviceaccount.com, Apr 5 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12e81848c40000
Project Member

Comment 42 by 42576172...@developer.gserviceaccount.com, Apr 6 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/12a2b198c40000
Project Member

Comment 44 by 42576172...@developer.gserviceaccount.com, Apr 6 2018 

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/119cfa84c40000
Project Member

Comment 46 by 42576172...@developer.gserviceaccount.com, Apr 6 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/15869f44c40000
Project Member

Comment 48 by 42576172...@developer.gserviceaccount.com, Apr 6 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/14cb3784c40000
Project Member

Comment 50 by 42576172...@developer.gserviceaccount.com, Apr 19 2018 

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17cf1ed6c40000

Comment 51 by g...@chromium.org, Apr 26 2018

Status: Assigned (was: Untriaged)
Project Member

Comment 52 by bugdroid1@chromium.org, May 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4a5f27eb04fc91e37c491ee8680ad0e37feb5d6

commit b4a5f27eb04fc91e37c491ee8680ad0e37feb5d6
Author: George Burgess IV <gbiv@chromium.org>
Date: Tue May 15 19:28:03 2018

[AFDO] Turn AFDO on by default for Linux official builds

This CL turns AFDO on for official builds of Linux. This appears to be a
<0.5% binary size regression, and should grant a pretty solid
performance gain.

This CL is also expected to increase build times of official builds by
around 12% (wall and CPU time). A memory usage increase of around
210-225MB per TU is also expected.

Depends on install-build-deps.sh change in r557698; it was re-run on
bots in crbug.com/841983, and devs were asked to update in "FYI: Linux
builds of Chromium need to run install-build-deps.sh after #557698".

Bug:  805098 ,  821595 , 837025
Test: See  issue 821595  for perf reports.
Change-Id: I9eafad1d20b897e77566de423f29c11cc8c13e83
Reviewed-on: https://chromium-review.googlesource.com/1025132
Commit-Queue: George Burgess <gbiv@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558806}
[modify] https://crrev.com/b4a5f27eb04fc91e37c491ee8680ad0e37feb5d6/DEPS
[modify] https://crrev.com/b4a5f27eb04fc91e37c491ee8680ad0e37feb5d6/build/config/compiler/BUILD.gn

Comment 53 by g...@chromium.org, May 21 2018

Status: Fixed (was: Assigned)
AFDO is landed, so we're done here.
►

Sign in to add a comment