New issue
Advanced search Search tips

Issue 821592 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-13
OS: Chrome
Pri: 1
Type: Bug-Regression
Team-Accessibility

Blocking:
issue 731255



Sign in to add a comment

WindowService shouldn't install EventRewriter in mus-mode

Project Member Reported by dtseng@chromium.org, Mar 13 2018

Issue description

Search+Left/Right should move focus. Keys are handled via SpokenEventRewriter (c/b/c/accessibility).
 

Comment 1 by sky@chromium.org, Mar 14 2018

Components: Internals>Services>WindowService
Owner: sky@chromium.org
Status: Started (was: Available)
Summary: KeyEvent struct traits don't correctly serialize KeyEvents, which breaks ChromeVox navigation (was: ChromeVox navigation broken)
David reverted the issue that broke this, so I'm morphing this into the reason it broke as that still needs to be fixed. My suspicion is the struct traits for serializing a KeyEvent are wrong, so that when ChromeVox gets the event it gets the wrong event and doesn't navigate.

Comment 2 by sky@chromium.org, Mar 14 2018

Blocking: 731255

Comment 3 by sky@chromium.org, Mar 14 2018

Summary: WindowService shouldn't install EventRewriter in mus-mode (was: KeyEvent struct traits don't correctly serialize KeyEvents, which breaks ChromeVox navigation)
Looks like I was wrong on the reason.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1946cf1f31143f7ec323a2e9bc584985def39368

commit 1946cf1f31143f7ec323a2e9bc584985def39368
Author: Scott Violet <sky@chromium.org>
Date: Wed Mar 14 17:00:04 2018

chromeos: changes Window Service to only install EventRewriter in mash

In mus-mode chrome/ash installs the EventRewriterChromeOS, so the
Window Service shouldn't install it too. The Window Service installed
it in such a way that sticky keys wasn't present, which meant the
EventRewriterChromeOS in the WindowService would change the event so
that when the EventRewriterChromeOS in chrome saw the event it didn't
match.

BUG= 821592 
TEST=covered by tests

Change-Id: Ib5472243bdd0365cd0fc75b31f31faf2aca4e03a
Reviewed-on: https://chromium-review.googlesource.com/962714
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543106}
[modify] https://crrev.com/1946cf1f31143f7ec323a2e9bc584985def39368/services/ui/ws/display_manager.cc

Comment 5 by sky@chromium.org, Mar 14 2018

Status: Fixed (was: Started)

Sign in to add a comment