Issue metadata
Sign in to add a comment
|
WindowService shouldn't install EventRewriter in mus-mode |
||||||||||||||||||||||||
Issue descriptionSearch+Left/Right should move focus. Keys are handled via SpokenEventRewriter (c/b/c/accessibility).
,
Mar 14 2018
,
Mar 14 2018
Looks like I was wrong on the reason.
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1946cf1f31143f7ec323a2e9bc584985def39368 commit 1946cf1f31143f7ec323a2e9bc584985def39368 Author: Scott Violet <sky@chromium.org> Date: Wed Mar 14 17:00:04 2018 chromeos: changes Window Service to only install EventRewriter in mash In mus-mode chrome/ash installs the EventRewriterChromeOS, so the Window Service shouldn't install it too. The Window Service installed it in such a way that sticky keys wasn't present, which meant the EventRewriterChromeOS in the WindowService would change the event so that when the EventRewriterChromeOS in chrome saw the event it didn't match. BUG= 821592 TEST=covered by tests Change-Id: Ib5472243bdd0365cd0fc75b31f31faf2aca4e03a Reviewed-on: https://chromium-review.googlesource.com/962714 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543106} [modify] https://crrev.com/1946cf1f31143f7ec323a2e9bc584985def39368/services/ui/ws/display_manager.cc
,
Mar 14 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sky@chromium.org
, Mar 14 2018Owner: sky@chromium.org
Status: Started (was: Available)
Summary: KeyEvent struct traits don't correctly serialize KeyEvents, which breaks ChromeVox navigation (was: ChromeVox navigation broken)