New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821568 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Task

Blocked on:
issue 805082
issue 815324



Sign in to add a comment

Modify BottomSheet to support CAS

Project Member Reported by mdjones@chromium.org, Mar 13 2018

Issue description

This is a tracking issue for work on converting the bottom sheet to CAS (Chrome Assistive Surface).

Doc: https://docs.google.com/document/d/100tMdX6sFqyBDxjgXd21A56-YkX7at7ffZrBVEz4Ew0
 
Blockedon: 805082 815324
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/823c476ab7b551c60ba6493eddfc69053a85f307

commit 823c476ab7b551c60ba6493eddfc69053a85f307
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Mar 16 00:07:24 2018

[Duplex] Add hidden state to the bottom sheet

This change both adds a new hidden state for the bottom sheet and
allows it to scroll off-screen, synchronized with the top controls,
when in the peeking state. With this patch, if the sheet is hidden,
it will not reappear until Chrome is restarted.

BUG=813373,  821568 

Change-Id: I78b36c19fab6acb0d5ad07d843426eeae4537d10
Reviewed-on: https://chromium-review.googlesource.com/961268
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543563}
[modify] https://crrev.com/823c476ab7b551c60ba6493eddfc69053a85f307/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/823c476ab7b551c60ba6493eddfc69053a85f307/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e4423abeba39ba9a2b7570180140869f22250a1

commit 2e4423abeba39ba9a2b7570180140869f22250a1
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Mar 22 19:24:28 2018

Add concept of priority to BottomSheetContent

This patch adds the concept of priority to content that can be shown
in the bottom sheet. Currently only two priorities are supported: HIGH
and LOW.

BUG= 821568 

Change-Id: Id2473a48618b5095ab9b1cca20831c7547c4d36d
Reviewed-on: https://chromium-review.googlesource.com/969063
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545193}
[modify] https://crrev.com/2e4423abeba39ba9a2b7570180140869f22250a1/chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsBottomSheetContent.java
[modify] https://crrev.com/2e4423abeba39ba9a2b7570180140869f22250a1/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/012fa5cdcc9d428609850758315af5e0a077bbb0

commit 012fa5cdcc9d428609850758315af5e0a077bbb0
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Mar 22 21:39:21 2018

Handle controls offset differently in BottomSheet

In order to avoid complications with the bottom sheet's scroll offset
and the offset generated by the browser controls, the two numbers are
now tracked individually. The getters and setter for the sheet's
offset from the bottom of the screen do not include the browser
controls offset.

BUG= 821568 

Change-Id: Ic722fea76d81b9da13f173fcd51e547f9c24ac79
Reviewed-on: https://chromium-review.googlesource.com/969409
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545260}
[modify] https://crrev.com/012fa5cdcc9d428609850758315af5e0a077bbb0/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d2eb248032f8cf486d38795d0940e3e5354eb80

commit 1d2eb248032f8cf486d38795d0940e3e5354eb80
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Mar 22 23:21:00 2018

Introduce the BottomSheetController

This patch introduces the BottomSheetController which is responsible
for managing content show requests. After this patch, other classes
should not need to call into BottomSheet directly.

BUG= 821568 

Change-Id: Ib91dfd4a5ac2273338efc7bfd650ce1749ba818b
Reviewed-on: https://chromium-review.googlesource.com/971825
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545284}
[add] https://crrev.com/1d2eb248032f8cf486d38795d0940e3e5354eb80/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetController.java
[modify] https://crrev.com/1d2eb248032f8cf486d38795d0940e3e5354eb80/chrome/android/java_sources.gni

Status: Fixed (was: Assigned)
Primary work for this is complete. Follow-up work can use a separate tracking bug.

Sign in to add a comment