New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821567 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

run_chrome_public_test_apk needs rooted device

Project Member Reported by mar...@mwiacek.com, Mar 13 2018

Issue description

run_chrome_public_test_apk is trying to do "setenforce 0" on device (SetEnforce from third_party/catapult/devil/devil/android/device_utils.py), 

Is it expected change and something what is documented or just mistake?


 
Cc: -mikec...@chromium.org -rnep...@chromium.org
This is intentional though not ideal. I think the particular setenforce call you're seeing is from flag_changer (https://codesearch.chromium.org/chromium/src/third_party/catapult/devil/devil/android/flag_changer.py?rcl=3b4e1d958fac9eb94ec57f3cb02ab2029fe56642&l=170).

Even with that changed, though, I'm not sure that our tests would pass on an non-rooted device.

Comment 2 by mar...@mwiacek.com, Mar 13 2018

let's assume that part is working without root - will you be fine for enabling them there?
I'm not sure I understand what you're asking -- fine w/ enabling tests on non-rooted devices?

I'd be fine with doing that if flag-changing works w/o setenforce, though I don't think tests will pass. I don't expect us to invest much in making them run on non-rooted devices, though, or in running non-rooted devices in the fleet. I'm not opposed to it, but we have higher priorities for the foreseeable future.
Cc: sandeepkumars@chromium.org
Labels: Needs-Feedback
@reporter: Could you please respond to comment #3.

Thanks!!
Status: WontFix (was: Unconfirmed)
Closing this issue as there is no action on this issue for long time, closing this issue. Request you to update your Chrome to latest #66.0.3359.158.

Please feel free to file a new issue if the issue is still observed.

Thanks!

Sign in to add a comment