New issue
Advanced search Search tips

Issue 821556 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

chromeos-assets does not install all wallpapers with unibuild

Project Member Reported by sjg@chromium.org, Mar 13 2018

Issue description

The -a flag has been removed. We should add a get-wallpaper command, or similar.

This was missed because code search apparently does not search the chromeos private overlay?


 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/0bb2e958855339dcd3d578bc922c67944c3d7c6f

commit 0bb2e958855339dcd3d578bc922c67944c3d7c6f
Author: Simon Glass <sjg@chromium.org>
Date: Wed Mar 21 05:21:26 2018

chromeos-config: Add support for installing wallpaper files

Add a command to return a list of wallpaper files so we know which ones
need to be installed for use at run-time. Add a special case for the
alternative whitelabel schema as well.

BUG= chromium:821556 
TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-tools \
	chromeos-config-host

Change-Id: Iff33c2ca91a1f06125578756a010f4e9006b483e
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/967007
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/libcros_config/test.dts
[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/cros_config_host/cros_config_host_unittest.py
[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/libcros_config/test.json
[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/cros_config_host/libcros_config_host_unittest.py
[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/libcros_config/test.yaml
[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/cros_config_host/cros_config_host.py
[modify] https://crrev.com/0bb2e958855339dcd3d578bc922c67944c3d7c6f/chromeos-config/cros_config_host/libcros_config_host.py

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 21 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/816aad3adc5d6ec00fd1b4655bf275aec8108ee0

commit 816aad3adc5d6ec00fd1b4655bf275aec8108ee0
Author: Simon Glass <sjg@chromium.org>
Date: Wed Mar 21 20:25:47 2018

Comment 3 by sjg@chromium.org, Mar 26 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment