New issue
Advanced search Search tips

Issue 821544 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 357781



Sign in to add a comment

src/chrome/common/extensions/docs/server2/integration_test.py is broken

Project Member Reported by dbertoni@chromium.org, Mar 13 2018

Issue description

At some point, something changed in the integration testing pipeline and this test broke. It is expected 200s on page loads, but 302s are returned instead.

This is blocking committing a CL to fix  https://crbug.com/357781 .
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08d8c3d278664f12e9f8007eef5ca0a36339fd79

commit 08d8c3d278664f12e9f8007eef5ca0a36339fd79
Author: David Bertoni <dbertoni@chromium.org>
Date: Fri Mar 16 21:44:47 2018

Fixed a test breakage since rendering may return a 302 instead of a 200. Fixed some incorrect closing header tags.

Bug: 821544
Change-Id: I60b4f710a8e7b183550e3f72d7e75dfb964b83bf
Reviewed-on: https://chromium-review.googlesource.com/963082
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543838}
[modify] https://crrev.com/08d8c3d278664f12e9f8007eef5ca0a36339fd79/chrome/common/extensions/docs/server2/integration_test.py
[modify] https://crrev.com/08d8c3d278664f12e9f8007eef5ca0a36339fd79/chrome/common/extensions/docs/templates/articles/linux_hosting.html

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ed86e39ed0093e11c5a6318345e0a8d94cf613b

commit 0ed86e39ed0093e11c5a6318345e0a8d94cf613b
Author: David Bertoni <dbertoni@chromium.org>
Date: Mon Mar 19 20:41:13 2018

[Extensions Docs] Fixed typo in integration test.

Skipping CQ due to timeout failures. See the bug for more info.

No-Try: true
Bug: 821544
Change-Id: I16e9363afa44fdde5fd67391e118bca94440af5b
Reviewed-on: https://chromium-review.googlesource.com/967426
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544149}
[modify] https://crrev.com/0ed86e39ed0093e11c5a6318345e0a8d94cf613b/chrome/common/extensions/docs/server2/integration_test.py

Status: Fixed (was: Assigned)
Status: Available (was: Fixed)
Reopening for possible enhancements to the fix and for more test cleanup.
Status: Assigned (was: Available)

Sign in to add a comment