New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 821538 link

Starred by 3 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Mar 2018
Cc:
█ ymalik@chromium.org
yfried...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Properly resolve View/Launch intents for VR.

Project Member Reported by mthiesse@chromium.org, Mar 13 2018 
We should steal most of the intent resolving code from the 2D Intent dispatcher, with the added Daydream category to disambiguate.

Implicit intents like "am start -a android.intent.action.VIEW -d https://webvr.info/samples/test-slow-render.html?noFrames=true -c com.google.intent.category.DAYDREAM" should resolve properly and launch Chrome in VR.

Comment 1 by mthiesse@chromium.org, Mar 14 2018

Labels: Hotlist-VRB-MVP
Putting this on the hotlist so we don't change how we handle intents post-launch and break apps that intent out to Chrome.

Comment 2 by mthiesse@chromium.org, Mar 14 2018

Owner: mthiesse@chromium.org
Status: Assigned (was: Available)

Comment 4 by mthiesse@chromium.org, Mar 22 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9b03ea833f07ac5862564f57e5abad370b45d0d

commit b9b03ea833f07ac5862564f57e5abad370b45d0d
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Mar 22 20:33:22 2018

VR: Properly implement VR intent handling.

VR Chrome Intents are just like regular Chrome intents with the added
DAYDREAM category, so we route Chrome intents with the DAYDREAM
category to the VR intent dispatcher which starts Chrome in VR.

Design doc: https://docs.google.com/document/d/1Q2ZjJiUvfn2c2dlJQ1qqdcE5vFnvlKz8Xg4ukTokrGQ/edit

Note that autopresent intents as described in the doc are not being
implemented here, and neither are CCT VR intents.

Bug:  821538 
Change-Id: Ifc8b2d1211e7efb630eb934322143ee58b39972e
Reviewed-on: https://chromium-review.googlesource.com/974445
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545234}
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/vr/VrMainActivity.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApi.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrIntentUtils.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockVrDaydreamApi.java
[modify] https://crrev.com/b9b03ea833f07ac5862564f57e5abad370b45d0d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java

Comment 6 by mthiesse@chromium.org, Mar 22 2018

Status: Fixed (was: Started)

Comment 7 by dougman@chromium.org, Mar 22 2018

Labels: Test-Complete

Comment 8 by ymalik@chromium.org, Apr 6 2018 

Issue 776235 has been merged into this issue.
►

Sign in to add a comment