New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821530 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome Browser and Render crashes are flagged as corrupted and removed

Project Member Reported by matthewjoseph@chromium.org, Mar 13 2018

Issue description

Chrome Version: R-65 10323.55.0 Beta

What steps will reproduce the problem?
(1) Recover device with 10323.55.0
(2) Trigger a render crash or browser crash with chrome://crash and chrome://inducebrowsercrashforrealz/
(3) Navigate to chrome://crashes and click 'Start uploading crashes'
(4) Crash reports are not sent

What is the expected result?
Crash reports should be sent succesfully

What happens instead?
Browser and Render crashes are not sent

Notes*

Running cat /var/log/messages | grep crash_ shows that the reports are marked as corrupted and removed:
2018-03-13T17:28:44.477313+00:00 WARNING crash_reporter[5919]: [user] Received crash notification for chrome[1973] sig 4, user 1000 (ignoring call by kernel - chrome crash; waiting for chrome to call us directly)
...
2018-03-13T17:29:31.772018+00:00 NOTICE crash_sender[6638]: Considering metadata /home/chronos/u-6adcbee78812304c067e9cc3a4cb871ddda2cac3/crash/chrome.20180313.102840.5783.meta.
2018-03-13T17:29:31.777461+00:00 NOTICE crash_sender[6645]: Removing corrupted metadata.
2018-03-13T17:29:31.780702+00:00 NOTICE crash_sender[6647]: Considering metadata /home/chronos/u-6adcbee78812304c067e9cc3a4cb871ddda2cac3/crash/chrome.20180313.102844.1973.meta.
2018-03-13T17:29:31.786570+00:00 NOTICE crash_sender[6654]: Removing corrupted metadata.
2018-03-13T17:30:58.852530+00:00 INFO crash_reporter[6792]: libminijail[6792]: mount /dev/log -> /dev/log type ''

Kernel crash logs and powerd logs are sent without issue.  Only render and browser crashes fail to send.

2018-03-13T17:29:30.336565+00:00 NOTICE crash_sender[6545]: Considering metadata /var/spool/crash/powerd.20180313.102831.1643.meta.
2018-03-13T17:29:30.361497+00:00 NOTICE crash_sender[6561]: Current send rate: 1sends/24hrs
2018-03-13T17:29:30.366012+00:00 NOTICE crash_sender[6567]: Scheduled to send in 0s.
2018-03-13T17:29:30.387839+00:00 NOTICE crash_sender[6615]: Sending crash:
2018-03-13T17:29:30.388346+00:00 NOTICE crash_sender[6616]:   Metadata: /var/spool/crash/powerd.20180313.102831.1643.meta (minidump)
2018-03-13T17:29:30.388835+00:00 NOTICE crash_sender[6617]:   Payload: /var/spool/crash/powerd.20180313.102831.1643.dmp
2018-03-13T17:29:30.389404+00:00 NOTICE crash_sender[6618]:   Version: 10323.55.0
2018-03-13T17:29:30.389875+00:00 NOTICE crash_sender[6619]:   Boot mode: dev
2018-03-13T17:29:30.390340+00:00 NOTICE crash_sender[6620]:   Exec name: powerd
2018-03-13T17:29:31.764689+00:00 NOTICE crash_sender[6632]: Crash report receipt ID 848745bc6b548ae9
2018-03-13T17:29:31.766663+00:00 NOTICE crash_sender[6634]: Successfully sent crash /var/spool/crash/powerd.20180313.102831.1643.meta and removing.


Diff between 10323.52.0 and 10323.55.0 show the below CL modified crash report corruption detection: https://crosland.corp.google.com/log/10323.52.0..10323.55.0
-- https://chromium-review.googlesource.com/949543
 

Comment 1 by vapier@chromium.org, Mar 13 2018

Owner: vapier@chromium.org
Status: Started (was: Untriaged)
i don't suppose someone could attack an example .meta data here from Chrome for me to quickly refer to ?  don't have a Chromebook in hand atm.
Labels: -Type-Bug Type-Bug-Regression
Attached is a render crash .meta file
chrome.20180313.122541.4900.meta
2.1 KB Download
Labels: ReleaseBlock-Stable

Comment 5 by vapier@chromium.org, Mar 13 2018

thanks, that helped clarify things quickly.  fix:
  https://chromium-review.googlesource.com/961267
Labels: Merge-Approved-66 Merge-Approved-65
Consider this merge approved for 65 and 66, picking into 65 now so we can try to get a stable RC built.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 14 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/cc1cb2a0cc7eaba3cd5a743cd1181b43c3fd64a3

commit cc1cb2a0cc7eaba3cd5a743cd1181b43c3fd64a3
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Mar 14 00:50:43 2018

crash: crash_sender: whitelist . and - chars in key names

Since Chrome reports include these chars, and they aren't a problem to
allow, whitelist to unbreak Chrome crash reports.

BUG= chromium:821530 
TEST=precq passes

Change-Id: I321361266b75664225782251039aabfe0b1d0905
Reviewed-on: https://chromium-review.googlesource.com/961681
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/cc1cb2a0cc7eaba3cd5a743cd1181b43c3fd64a3/crash-reporter/crash_sender

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2018

Labels: merge-merged-release-R66-10452.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e15c7215f4ee1231fd5e4716c04d7492d9be6d6b

commit e15c7215f4ee1231fd5e4716c04d7492d9be6d6b
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Mar 14 00:55:51 2018

crash: crash_sender: whitelist . and - chars in key names

Since Chrome reports include these chars, and they aren't a problem to
allow, whitelist to unbreak Chrome crash reports.

BUG= chromium:821530 
TEST=precq passes

Change-Id: I321361266b75664225782251039aabfe0b1d0905
Reviewed-on: https://chromium-review.googlesource.com/961682
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>
Commit-Queue: Bernie Thompson <bhthompson@chromium.org>
Tested-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/e15c7215f4ee1231fd5e4716c04d7492d9be6d6b/crash-reporter/crash_sender

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a77aa3a8d5690ab6bcf6adddc735eca38a6f1482

commit a77aa3a8d5690ab6bcf6adddc735eca38a6f1482
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Mar 14 02:00:26 2018

crash: crash_sender: whitelist . and - chars in key names

Since Chrome reports include these chars, and they aren't a problem to
allow, whitelist to unbreak Chrome crash reports.

BUG= chromium:821530 
TEST=precq passes

Change-Id: I321361266b75664225782251039aabfe0b1d0905
Reviewed-on: https://chromium-review.googlesource.com/961267
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Matt Nelson <matthewjoseph@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/a77aa3a8d5690ab6bcf6adddc735eca38a6f1482/crash-reporter/crash_sender

Labels: -Merge-Approved-65 -Merge-Approved-66 Merge-Merged
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on build 10323.62.0

Sign in to add a comment