autoupdater is sending a default and hardcoded appid to incoming requests. |
|||||
Issue descriptionautoupdater_lib.py is sending a default hard coded appid for incoming requests. However, I think omaha sends a response with the same appid given in the client's requests. We need to change this behavior so the response's appid matches the request's. This is needed in the new crbug.com/815356
,
Mar 13 2018
Config wise, we don't set any app ID. Each config belongs to one app ID and that "filtering" by app ID happens before the config gets executed (that's what Omaha uses to identify the product to match against). I wasn't aware of Omaha returning back one app ID or the other, but my wild guess would be that, if it returns one, it'd be the same of the client request because that was the product that got matched. So, in summary, I cannot confirm it but should be easy to test by faking a request to Omaha :)
,
Mar 13 2018
That is probably the case, I checked an omaha returns the same appid. Thanks.
,
Mar 13 2018
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/d7a913a3455a4e857a11889516f9c7bf6204bf23 commit d7a913a3455a4e857a11889516f9c7bf6204bf23 Author: Amin Hassani <ahassani@google.com> Date: Wed Mar 14 21:21:47 2018 autoupdate: Return response with client's app ID Currently in autoupdate we sent a default hard coded app ID to the client. However, this is not the bahvior of omaha, as omaha always, reply with the same app ID requested by the user. This CL, modifes this bahavior in autoupdate to return the app ID associated with the client's request. BUG= chromium:821514 TEST=cros flash Change-Id: I7cd36c8e7ed6e36bed257a5373e62483136b585e Reviewed-on: https://chromium-review.googlesource.com/961585 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/d7a913a3455a4e857a11889516f9c7bf6204bf23/autoupdate_lib.py [modify] https://crrev.com/d7a913a3455a4e857a11889516f9c7bf6204bf23/autoupdate.py
,
Mar 16 2018
,
Apr 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/4835a70dd71d5804db99ed066b7cf61e931866e5 commit 4835a70dd71d5804db99ed066b7cf61e931866e5 Author: Amin Hassani <ahassani@google.com> Date: Thu Apr 05 23:45:42 2018 autoupdate: Return response with client's app ID Currently in autoupdate we sent a default hard coded app ID to the client. However, this is not the bahvior of omaha, as omaha always, reply with the same app ID requested by the user. This CL, modifes this bahavior in autoupdate to return the app ID associated with the client's request. BUG= chromium:821514 TEST=cros flash Change-Id: I7cd36c8e7ed6e36bed257a5373e62483136b585e Reviewed-on: https://chromium-review.googlesource.com/961585 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> (cherry picked from commit d7a913a3455a4e857a11889516f9c7bf6204bf23) Reviewed-on: https://chromium-review.googlesource.com/998655 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/4835a70dd71d5804db99ed066b7cf61e931866e5/autoupdate_lib.py [modify] https://crrev.com/4835a70dd71d5804db99ed066b7cf61e931866e5/autoupdate.py
,
May 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/828edc18ffb3117cb363a729e806503b6c5117e4 commit 828edc18ffb3117cb363a729e806503b6c5117e4 Author: Amin Hassani <ahassani@google.com> Date: Thu May 03 21:44:45 2018 autoupdate: Return response with client's app ID Currently in autoupdate we sent a default hard coded app ID to the client. However, this is not the bahvior of omaha, as omaha always, reply with the same app ID requested by the user. This CL, modifes this bahavior in autoupdate to return the app ID associated with the client's request. BUG= chromium:821514 TEST=cros flash Change-Id: I7cd36c8e7ed6e36bed257a5373e62483136b585e Reviewed-on: https://chromium-review.googlesource.com/961585 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> (cherry picked from commit d7a913a3455a4e857a11889516f9c7bf6204bf23) Reviewed-on: https://chromium-review.googlesource.com/1043166 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/828edc18ffb3117cb363a729e806503b6c5117e4/autoupdate_lib.py [modify] https://crrev.com/828edc18ffb3117cb363a729e806503b6c5117e4/autoupdate.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ahass...@chromium.org
, Mar 13 2018Status: Started (was: Untriageda)