New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821498 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Minimize/dock window options missing from Linux apps

Project Member Reported by tbuck...@chromium.org, Mar 13 2018

Issue description

Chrome version: 66.0.3359.10 dev
OS: Chrome 10452.1.0

The window caption bar for X11 apps is missing the minimize button, and holding down on the maximize/restore button doesn't show the arrows to dock it to the left/right of the screen.
 
Labels: Hotlist-Crostini-Misc
Labels: -Hotlist-Crostini-Misc Hotlist-Crostini-Apps
Labels: Pri-1
Labels: Hotlist-Announce
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d320b360d31f6fa3120e7472861f1833cad743d

commit 7d320b360d31f6fa3120e7472861f1833cad743d
Author: David Reveman <reveman@chromium.org>
Date: Tue Apr 24 14:25:28 2018

exo: Xdg toplevel shell surface can be minimized by default.

We shouldn't require clients to explicitly set that they can be
minimized. The default behavior for toplevel XDG surfaces is that
they can be minimized.

Note: The previous behavior was motivated by the lack of shelf icon
integration, and that making it less obvious how to restore the
window after minimizing it. This is not an issue anymore, with
shelf integration having been added.

Bug:  821498 
Test: Caption for xterm in crostini has minimize button by default
Change-Id: I8a730d8e64dc104f990d70b0e147f182cc06e54d
Reviewed-on: https://chromium-review.googlesource.com/1024818
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553093}
[modify] https://crrev.com/7d320b360d31f6fa3120e7472861f1833cad743d/components/exo/wayland/server.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8f8f9584ddbcf7e4c4e226f7865fad91cacd7bb

commit f8f8f9584ddbcf7e4c4e226f7865fad91cacd7bb
Author: David Reveman <reveman@chromium.org>
Date: Wed Apr 25 12:44:37 2018

exo: Prevent transient windows from being minimized.

It should not be possible to minimize transient dialog windows.
These windows typically disable input for the parent and minimizing
them and leaving the parent in a disabled state can be very confusing.

Bug:  821498 
Test: exo_unittest --gtest_filter=ShellSurface.Minimum
Change-Id: I288b57a4b36f61d6ae0d491796ba45d8c9e44686
Reviewed-on: https://chromium-review.googlesource.com/1027890
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553523}
[modify] https://crrev.com/f8f8f9584ddbcf7e4c4e226f7865fad91cacd7bb/components/exo/shell_surface_base.cc
[modify] https://crrev.com/f8f8f9584ddbcf7e4c4e226f7865fad91cacd7bb/components/exo/shell_surface_unittest.cc

Status: Fixed (was: Assigned)
Components: OS>Systems>Containers

Comment 9 by vapier@chromium.org, May 17 2018

Labels: -Restrict-View-Google
Status: Verified (was: Fixed)
Chrome: 72.0.3626.43.0
Chrome OS: 11316.57.0 beta
Model: kevin

Apps (terminal, leafpad, gedit) with Linux apps now has minimize and maximize options

Sign in to add a comment