New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821490 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 814990



Sign in to add a comment

Re-enable SyncFakeServerTestCase on devices

Project Member Reported by edchin@chromium.org, Mar 13 2018

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/960842
Disabled tests on devices.

These tests have been failing on these device bots:
(iPad Air iOS 10.3.3) on iOS-10.3.3
(iPhone 6s iOS 10.3.3) on iOS-10.3.3

Since March 7, revision:
1cbfed836fceb54df561b43e7cd8e5d65ea41137
 
Owner: ----
Status: Untriaged (was: Assigned)
Please re-triage to appropriate owners, thanks!
These tests are failing on simulators as well.

SyncFakeServerTestCase/testSyncTypedURLDeleteFromClient:
../../ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm:127: error: -[SyncFakeServerTestCase testSyncTypedURLDeleteFromClient] : Exception: AssertionFailedException
Exception Name: AssertionFailedException
Exception Reason: ((chrome_test_util::GetNumberOfSyncEntities(syncer::BOOKMARKS)) == ((0))) failed
Exception Details: No bookmarks should exist before sync tests start.

Comment 3 by sczs@chromium.org, Mar 14 2018

Cc: liaoyuke@chromium.org huangml@chromium.org justincohen@chromium.org
Owner: tschumann@chromium.org
Status: Assigned (was: Untriaged)
tschumann@ could you PTAL. This needs an owner on the Sync team, maybe huangml@ or liaoyuke@ can help out transitioning this :)
Blocking: 814990
Project Member

Comment 5 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91149608bcfbe58d4fa79a2e8d5bc7084253aba6

commit 91149608bcfbe58d4fa79a2e8d5bc7084253aba6
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon May 14 07:30:12 2018

Disabling failing sync EG test

This CL disable a sync EG test failing almost consistently on iPhone
simulator iOS 10 and which is flaky on other configuration.
As all the other tests of this test suite are disabled, I am disabling
it instead of marking it as flaky, as there is probably something wrong
with the whole test suite.

Bug: 821490
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5bada13c540bc3d95c2082109d3e9299b873cc39
Reviewed-on: https://chromium-review.googlesource.com/1054233
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558221}
[modify] https://crrev.com/91149608bcfbe58d4fa79a2e8d5bc7084253aba6/ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm

Sign in to add a comment