New issue
Advanced search Search tips

Issue 821471 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
sadrul@chromium.org
riajiang@chromium.org
jamescook@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Make autoclick app work in mash

Project Member Reported by jamescook@chromium.org, Mar 13 2018 
Now that the window service is rolling out Ben suggested that we investigate making some of our smaller mojo apps work under mus, rather than waiting for mash. This would help other teams launch small features as mojo apps without having to wait for the full mash conversion.

I'm going to investigate autoclick. Things to do:

1. Make it actually generate clicks. erg@ had to introduce a trusted event-generation interface to make remoting work (RemoteEventDispatcher), so I'll try using that.

2. Figure out what to do to get it to open a widget, paint, etc.

3. Change the launching code to look for feature Mus in addition to Mash.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1be333db85f3cf2adc9a191c84b8df11a96c9e4

commit c1be333db85f3cf2adc9a191c84b8df11a96c9e4
Author: James Cook <jamescook@chromium.org>
Date: Wed Mar 14 15:21:54 2018

cros: Clean up AutoclickControllerCommonDelegate

Specify the coordinate system in variable names for points.

Bug: 821471
Change-Id: I5368b85e6c1c36f5295eee10b96074e5d3b30403
Reviewed-on: https://chromium-review.googlesource.com/961663
Reviewed-by: Ria Jiang <riajiang@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543088}
[modify] https://crrev.com/c1be333db85f3cf2adc9a191c84b8df11a96c9e4/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/c1be333db85f3cf2adc9a191c84b8df11a96c9e4/ash/autoclick/common/autoclick_controller_common_delegate.h
[modify] https://crrev.com/c1be333db85f3cf2adc9a191c84b8df11a96c9e4/ash/components/autoclick/autoclick_application.cc
[modify] https://crrev.com/c1be333db85f3cf2adc9a191c84b8df11a96c9e4/ash/components/autoclick/autoclick_application.h
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8990ce90516cfafd75f241d270e5489c0fc6e7

commit ef8990ce90516cfafd75f241d270e5489c0fc6e7
Author: James Cook <jamescook@chromium.org>
Date: Wed Mar 14 21:06:36 2018

cros: Make autoclick work under mash

Generate synthetic clicks and dispatch them via the window service.
Add the remote event dispatcher interface to a new "accessibility"
capability, available only to trusted apps.

Bug: 821471,  628665 
Test: Use autoclick on multiple displays with different scale factors
Change-Id: I61352a0849a96a2bc0ae14d0b8afcca051ba67e2
Reviewed-on: https://chromium-review.googlesource.com/961668
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543190}
[modify] https://crrev.com/ef8990ce90516cfafd75f241d270e5489c0fc6e7/ash/autoclick/common/autoclick_controller_common_delegate.h
[modify] https://crrev.com/ef8990ce90516cfafd75f241d270e5489c0fc6e7/ash/components/autoclick/DEPS
[modify] https://crrev.com/ef8990ce90516cfafd75f241d270e5489c0fc6e7/ash/components/autoclick/autoclick_application.cc
[modify] https://crrev.com/ef8990ce90516cfafd75f241d270e5489c0fc6e7/ash/components/autoclick/autoclick_application.h
[modify] https://crrev.com/ef8990ce90516cfafd75f241d270e5489c0fc6e7/ash/components/autoclick/manifest.json
[modify] https://crrev.com/ef8990ce90516cfafd75f241d270e5489c0fc6e7/services/ui/manifest.json

Comment 3 by jamescook@chromium.org, Mar 15 2018

Status: Assigned (was: Started)
I think touch HUD is a better first choice than autoclick for a mus mojo app. Putting this one on hold, pending discussion of how to do mus mojo apps in the first place.

Comment 4 by jamescook@chromium.org, Apr 19 2018

Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Comment 5 by jamescook@chromium.org, Aug 6

Cc: jamescook@chromium.org
Labels: -Pri-1 Proj-Mustash Pri-3
Owner: ----
Status: Untriaged (was: Assigned)
Summary: Make autoclick app work in mash (was: Make autoclick app work in both mus and mash)
We went with touch hud and shortcut viewer. Autoclick is lower priority.

Comment 6 by sky@chromium.org, Aug 15

Labels: -Proj-Mustash Proj-Mash
►

Sign in to add a comment