Issue metadata
Sign in to add a comment
|
Android's Settings>Accessibility>Force enable zoom is not applied to new tabs |
||||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3369.0 OS: Android 7.0.0 Nexus 6 Noticed here: crbug.com/820391#c5 What steps will reproduce the problem? (1) Visit a page with an element with 'touch-action: pan-y;' (or any other value which prevents pinch zooming) (2) Attempt to pinch zoom the element (3) Observe that pinch is prevented (4) Enable Settings>Accessibility>Force enable zoom (5) Attempt to pinch zoom the element (6) Observe that pinch is allowed (7) Close the tab and open the page in a new tab (8) Attempt to pinch zoom the element What is the expected result? Since the Settings>Accessibility>Force enable zoom is still set, the pinch zoom should be allowed What happens instead? The pinch zoom is prevented. If at this point you open and close the settings menu, the setting will be applied to the new tab.
,
Mar 20 2018
Issue 821861 has been merged into this issue.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9cb0c3986c31a56341e7df5131d7346f79e5e4d4 commit 9cb0c3986c31a56341e7df5131d7346f79e5e4d4 Author: chaopeng <chaopeng@chromium.org> Date: Wed Mar 21 19:03:48 2018 Update the force_enable_zoom state to recreated input router in RenderWidgetHostImpl This issue is caused by force_enable_zoom is not updated to the recreated input router when open the new tab. In this patch, we record the force_enable_zoom in RenderWidgetHostImpl, then update the state to new input router when we create. Bug: 821447 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I33308abe484de70f1e4d2189de4896a04b05d7ef Reviewed-on: https://chromium-review.googlesource.com/961781 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#544791} [modify] https://crrev.com/9cb0c3986c31a56341e7df5131d7346f79e5e4d4/content/browser/renderer_host/input/input_router_impl.h [modify] https://crrev.com/9cb0c3986c31a56341e7df5131d7346f79e5e4d4/content/browser/renderer_host/input/legacy_input_router_impl.h [modify] https://crrev.com/9cb0c3986c31a56341e7df5131d7346f79e5e4d4/content/browser/renderer_host/input/touch_action_filter.h [modify] https://crrev.com/9cb0c3986c31a56341e7df5131d7346f79e5e4d4/content/browser/renderer_host/render_widget_host_impl.cc [modify] https://crrev.com/9cb0c3986c31a56341e7df5131d7346f79e5e4d4/content/browser/renderer_host/render_widget_host_impl.h [modify] https://crrev.com/9cb0c3986c31a56341e7df5131d7346f79e5e4d4/content/browser/renderer_host/render_widget_host_unittest.cc
,
Mar 22 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by mcnee@chromium.org
, Mar 13 2018Components: Blink>Input
Owner: chaopeng@chromium.org
Status: Assigned (was: Untriaged)