VR: Chrome crashes when exiting VR while native dialog is open |
|||
Issue descriptionChrome Version: 67.0.3368.0 OS: Android N What steps will reproduce the problem? (1) Go to https://permission.site (2) Enter VR (3) Click Camera (4) While the permission dialog is open exit VR by pressing the X button What is the expected result? Cleanly exit VR What happens instead? Chrome crashes Trace: FATAL:VrShellImpl_jni.h(269)] Check failed: native. CloseAlertDialog Stack Trace: RELADDR FUNCTION FILE:LINE 000cd78d logging::LogMessage::~LogMessage() /usr/local/google/code/chromium/src/base/logging.cc:594:29 00fdcabd Java_org_chromium_chrome_browser_vr_1shell_VrShellImpl_nativeCloseAlertDialog /usr/local/google/code/chromium/src/out/Debug/gen/chrome/browser/android/vr/vr_shell_jni_headers/vr_shell/jni/VrShellImpl_jni.h:269:3
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3937f71c1abac2f3c9fc65d4db6157e96e832b31 commit 3937f71c1abac2f3c9fc65d4db6157e96e832b31 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Wed Mar 21 15:39:19 2018 Fix Chrome crash when exiting VR Cancel dialogs before destroying their View. Bug: 821443 Change-Id: Ifb0eb47cc60efa3e0b7e6354754d5db0fef38cda Reviewed-on: https://chromium-review.googlesource.com/969584 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#544712} [modify] https://crrev.com/3937f71c1abac2f3c9fc65d4db6157e96e832b31/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Mar 21 2018
,
Mar 22 2018
Verified on build 67.0.3378.0, looks good. We also have an automated test to cover this scenarios.
,
Apr 5 2018
Issue 822159 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tiborg@chromium.org
, Mar 14 2018