Avoid jni call to check whether notification channels should be used |
||
Issue descriptionSee the TODO at the top of NotificationSettingsBridge.java - now that we can check sdk_int from native we should do this and avoid an unnecessary call from C++ -> Java.
,
Mar 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fe5951fa23c0717b1a3041608dded61f9eb4251 commit 2fe5951fa23c0717b1a3041608dded61f9eb4251 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Mar 19 12:57:33 2018 [Android] Remove unnecessary JNI call. Use BuildInfo directly to check the SDK version in NotificationSettings. Bug: 821431 Change-Id: Ie3ca8b6dc2cf200ab06d3e1aa6820bca341db1c5 Reviewed-on: https://chromium-review.googlesource.com/966284 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#544015} [modify] https://crrev.com/2fe5951fa23c0717b1a3041608dded61f9eb4251/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationSettingsBridge.java [modify] https://crrev.com/2fe5951fa23c0717b1a3041608dded61f9eb4251/chrome/browser/notifications/notification_channels_provider_android.cc
,
Mar 19 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by rayankans@chromium.org
, Mar 16 2018