New issue
Advanced search Search tips

Issue 821409 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.9% regression in system_health.memory_mobile at 542226:542283

Project Member Reported by hjd@google.com, Mar 13 2018

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Mar 13 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=821409

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d14325747ffde7eae9a1db49c82fae0e7e99b81db247449225a4dca20e0e03ec


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Mar 14 2018

Cc: toyoshim@chromium.org isherman@chromium.org
Owner: toyoshim@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14cc01ae440000

ResourceLoadScheduler: remove stale configurations by toyoshim@chromium.org
https://chromium.googlesource.com/chromium/src/+/a3d458c7e9c8ebf21833bbaa48ee4e4159a516dc

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -isherman@chromium.org
I kicked another bisect.
My change just stop running memory report code path.
So, it should not affect actual memory usage in a bad way.

If another bisect still points my CL, probably it's because my change just affects GC timing, memory allocation order, or something?
 Issue 821869  has been merged into this issue.
Components: Blink>Loader
Cc: isherman@chromium.org
 Issue 821868  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/12a86fee440000

ResourceLoadScheduler: remove stale configurations by toyoshim@chromium.org
https://chromium.googlesource.com/chromium/src/+/a3d458c7e9c8ebf21833bbaa48ee4e4159a516dc

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -isherman@chromium.org
Issue 822189 has been merged into this issue.
Status: WontFix (was: Assigned)
Let me close this as WontFix.

Just stop reporting memory metrics caused performance improvement/regression, depending on platform.

Even regression in some micro benchmarks is significant, it does not look trustworthy.
Issue 821791 has been merged into this issue.
Issue 821435 has been merged into this issue.

Sign in to add a comment