New issue
Advanced search Search tips

Issue 821397 link

Starred by 1 user
Status: Fixed
Owner:
mattcary@chromium.org
Closed: Mar 2018
Cc:
lizeb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

CCT background tab does not use spare web contents

Project Member Reported by mattcary@chromium.org, Mar 13 2018 
See attached trace. There are are two renderer processes, when there should be just a single one. The second renderer is created for a background tab, which should have taken the spare renderer which is instead unused.

This only occurs for the background tab---other uses of loadURL from custom tabs have been confirmed to use the spare renderer as expected.
trace.tgz
1.3 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0d842c16cd2f8e67ae2689c2d906e1855b1b571

commit b0d842c16cd2f8e67ae2689c2d906e1855b1b571
Author: Matthew Cary <mattcary@chromium.org>
Date: Wed Mar 14 17:23:40 2018

Custom Tabs: use spare web contents when initially hidden.

This is necessary for the background tab to use the spare web contents.

Bug:  821397 
Change-Id: I9f140134179d258e012ca749d28c109fee671320
Reviewed-on: https://chromium-review.googlesource.com/960903
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543114}
[modify] https://crrev.com/b0d842c16cd2f8e67ae2689c2d906e1855b1b571/chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java
[modify] https://crrev.com/b0d842c16cd2f8e67ae2689c2d906e1855b1b571/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/b0d842c16cd2f8e67ae2689c2d906e1855b1b571/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java

Comment 2 by mattcary@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
►

Sign in to add a comment