Add EDID fields manufacturer id, product id, year of manufacture to chrome.system.display private Apps API |
||||
Issue descriptionThis is the impl bug for DD go/js-edid-chromeos, essentially covering wiring up those said fields (maybe more, maybe obfuscated, see discussion in [1]), for the sole purpose of the chrome private (i.e. extensions) API chrome.system.display [2] [1] https://groups.google.com/a/google.com/d/msg/chrome-design-docs/7Dx7Fb0Zn1M/W8YUB2toBgAJ [2] https://developer.chrome.com/apps/system_display
,
Mar 14 2018
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a5c7f821954b7d7601f50273b873702f301b8ce commit 1a5c7f821954b7d7601f50273b873702f301b8ce Author: Miguel Casas <mcasas@chromium.org> Date: Wed Mar 14 16:42:20 2018 ui/display and ui/display/util OWNERS update This CL adds an OWNERS file to //ui/display/util: git shortlog ui/display/util --numbered --summary 5 Miguel Casas-Sanchez 5 robert.bradford 2 Daniel Bratell 2 afakhry 2 thomasanderson [...] I was going to add dnicoara@ to it but he seems more a //ui/display OWNER: git shortlog ui/display/ --numbered --summary 51 kylechar 31 dnicoara 27 dnicoara@chromium.org 21 robliao 16 Christopher Cameron 16 oshima So I added him there. Also Component. Bug: 821393 Change-Id: I695ac3948355783f19d0f31096f5ca8e37aa9eab Reviewed-on: https://chromium-review.googlesource.com/960577 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#543103} [modify] https://crrev.com/1a5c7f821954b7d7601f50273b873702f301b8ce/ui/display/OWNERS [add] https://crrev.com/1a5c7f821954b7d7601f50273b873702f301b8ce/ui/display/util/OWNERS
,
Mar 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccc278752073be87774c2cd0d671de056d8589b0 commit ccc278752073be87774c2cd0d671de056d8589b0 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Mar 14 21:24:16 2018 Add two binary files to edid parser fuzzer corpus This CL adds two extra EDIDs (namely an eve and an HP z32x) for the edid_parser_fuzzer test. Bug: 821393 Change-Id: Ia3242cd6df142a789e074ddaa6b4df8162adbd5d Reviewed-on: https://chromium-review.googlesource.com/963222 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#543197} [add] https://crrev.com/ccc278752073be87774c2cd0d671de056d8589b0/ui/display/util/fuzz_corpus/eve [add] https://crrev.com/ccc278752073be87774c2cd0d671de056d8589b0/ui/display/util/fuzz_corpus/hpz32x
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b90891e6365514190162e1f6370a541a66f3aaa commit 9b90891e6365514190162e1f6370a541a66f3aaa Author: Miguel Casas <mcasas@chromium.org> Date: Thu Mar 15 22:12:25 2018 wire EDID data to DisplayUnitInfo Chrome api This CL wires 3 display/monitor fields from EDID parsing to the Chrome private API where they surface, as described in the DD [1], namely: 1- manufacturer id 2- product id 3- year of manufacture. (Note that ToT Ozone DRM already parses this list's 1 and 2; this CL adds code to parse 3). A diagram of the touched areas is in the DD [1] extracted for quick access in: https://i.imgur.com/yx8H0R3.jpg (also [2]). but in a nutshell: Ozone DRM creates a DisplaySnapshot from the EDID, and passes it to Browser Process via Mojo and/or IPC (being migrated); in Browser DisplayChangeObserver transforms that snapshot into a ManagedDisplayInfo, and in turn passes it to the DisplayManager that creates a Display that is used later on upon request by DisplayInfoProviderChromeOS to fill in the JS data struct. There's a bit of confusion on ToT between product_id and product_code, so this CL follows the spec and aligns them all, i.e. EDID parser produces a |product_code|, which is a pack of the manufacturer id and product id. Unittests extended, tested on soraka+simplechrome. [1] go/js-edid-chromeos [2] https://imgur.com/a/aqNDD Bug: 821393 Change-Id: Ia219b4eeb92cf3eae3e58046340f1b81c34c9ea2 Reviewed-on: https://chromium-review.googlesource.com/959547 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543512} [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ash/display/display_color_manager_chromeos.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ash/display/display_error_observer_chromeos_unittest.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/chrome/browser/extensions/display_info_provider_chromeos.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/chrome/browser/extensions/display_info_provider_chromeos_unittest.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/extensions/common/api/system_display.idl [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/display.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/display.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/manager/chromeos/display_change_observer.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/manager/chromeos/display_change_observer.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/manager/fake_display_snapshot.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/manager/fake_display_snapshot.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/manager/managed_display_info.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/manager/managed_display_info.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/mojo/display_snapshot.mojom [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/mojo/display_snapshot_struct_traits.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/mojo/display_snapshot_struct_traits.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/mojo/display_struct_traits_unittest.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/types/display_constants.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/types/display_snapshot.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/types/display_snapshot.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/util/edid_parser.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/util/edid_parser.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/util/edid_parser_fuzzer.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/display/util/edid_parser_unittest.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/ozone/common/gpu/ozone_gpu_message_params.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/ozone/common/gpu/ozone_gpu_messages.h [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/ozone/platform/drm/common/drm_util.cc [modify] https://crrev.com/9b90891e6365514190162e1f6370a541a66f3aaa/ui/ozone/platform/drm/common/drm_util_unittest.cc
,
Mar 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7744aabb8412e53b2d1fc211dcb8d08f95ad2aab commit 7744aabb8412e53b2d1fc211dcb8d08f95ad2aab Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Thu Mar 22 00:17:34 2018 Add Edid data to chrome:system This CL adds Edid information, when available, to a new "monitor info" entry in chrome:system https://i.imgur.com/vgFZM19.png (one monitor) [1] https://i.imgur.com/oDxceMz.png (tow monitors) [2] [1] https://imgur.com/a/hkXx4 [2] https://imgur.com/a/SUtq7 Bug: 821393 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9775aab6d2b4a51ec9453aa070ce9acbcb4d5989 Reviewed-on: https://chromium-review.googlesource.com/965582 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Greg Levin <glevin@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#544916} [add] https://crrev.com/7744aabb8412e53b2d1fc211dcb8d08f95ad2aab/chrome/browser/feedback/system_logs/log_sources/DEPS [modify] https://crrev.com/7744aabb8412e53b2d1fc211dcb8d08f95ad2aab/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc [modify] https://crrev.com/7744aabb8412e53b2d1fc211dcb8d08f95ad2aab/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.h
,
Mar 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/51c63d34a01e9d5c3269b71f5306c53bc86147c6 commit 51c63d34a01e9d5c3269b71f5306c53bc86147c6 Author: Felix Ekblom <felixe@chromium.org> Date: Fri Mar 23 21:50:45 2018 [autotest] Add test for Edid in chrome.system.display BUG= chromium:821393 TEST=Ran test on local DUT Change-Id: Id6c724c22c3cac19dd54764a7b116015cf68a361 Reviewed-on: https://chromium-review.googlesource.com/973228 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Felix Ekblom <felixe@chromium.org> Reviewed-by: Denis Tosic <dtosic@chromium.org> [add] https://crrev.com/51c63d34a01e9d5c3269b71f5306c53bc86147c6/client/site_tests/display_DisplayContainEdid/control [add] https://crrev.com/51c63d34a01e9d5c3269b71f5306c53bc86147c6/client/site_tests/display_DisplayContainEdid/display_DisplayContainEdid.py [modify] https://crrev.com/51c63d34a01e9d5c3269b71f5306c53bc86147c6/client/cros/multimedia/display_info.py
,
Mar 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0cc180e889c26c280942e181d067bf889e2adfba commit 0cc180e889c26c280942e181d067bf889e2adfba Author: Miguel Casas <mcasas@chromium.org> Date: Sat Mar 24 19:31:32 2018 Add edid-decode package to chromeos-base/chromeos-chrome ebuild files Added edid-decode package to chromeos-base/chromeos-chrome ebuild files; this will allow in a subsequent CL to run it as part of chrome:system to include the parsed EDID blobs in the system report (not that the blob is already available, albeit not parsed, under "modetest"). The binary size increase is minimal (~8KB I think). Change-Id: I1e5b62c551a4d330d06c004c13b6a1f97f6d2630 Bug: 821393 Reviewed-on: https://chromium-review.googlesource.com/974653 Commit-Ready: Miguel Casas <mcasas@chromium.org> Tested-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/0cc180e889c26c280942e181d067bf889e2adfba/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Mar 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/574e86d6b60bc301b96cc47465c9208ff17001ec commit 574e86d6b60bc301b96cc47465c9208ff17001ec Author: Miguel Casas <mcasas@chromium.org> Date: Tue Mar 27 20:57:45 2018 cleanup: Correct FakeDisplaySnapshot product_id --> product_code This CL corrects references to "product id" to "product code" in FakeDisplaySnapshot and its uses. Rationale: crrev.com/c/959547 corrected the naming "product id" (which comes out of the EDID blob) with "product code" (which is a mishmash of the manufacturer id, the display name hashed and an index), but left this class out for clarity. Bug: 821393 Change-Id: I1c49c431a2e6a74e07092786df814f3e9f68311e Reviewed-on: https://chromium-review.googlesource.com/982036 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#546250} [modify] https://crrev.com/574e86d6b60bc301b96cc47465c9208ff17001ec/ash/display/display_color_manager_unittest.cc [modify] https://crrev.com/574e86d6b60bc301b96cc47465c9208ff17001ec/ui/display/manager/fake_display_snapshot.cc [modify] https://crrev.com/574e86d6b60bc301b96cc47465c9208ff17001ec/ui/display/manager/fake_display_snapshot.h
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/54a58a647eda0cdab78a46434fb1e950180009e2 commit 54a58a647eda0cdab78a46434fb1e950180009e2 Author: Felix Ekblom <felixe@chromium.org> Date: Wed Mar 28 03:35:07 2018 autotest: Add display_DisplayContainEdid to ebuild BUG= chromium:821393 TEST=Test run locally, no testing of ebuild changes performed. Change-Id: I8b70d11a44e69f63ee89be39d7eb35eda0753490 Reviewed-on: https://chromium-review.googlesource.com/980253 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Felix Ekblom <felixe@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/54a58a647eda0cdab78a46434fb1e950180009e2/chromeos-base/autotest-chrome/autotest-chrome-9999.ebuild
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b603cc658cfe26a384f325f0e44afca07905052 commit 2b603cc658cfe26a384f325f0e44afca07905052 Author: Miguel Casas <mcasas@chromium.org> Date: Fri Mar 30 02:48:17 2018 gfx::ColorSpace::ToString() - print primaries ISO chromatic adaptation matrix This CL changes the implementation of the said method to print out the primaries coordinates instead of the Chromatic adaptation matrix, if CUSTOM primaries are used. The former is more informative than the latter. Example output with primaries triangle (edid and recalculated) can be found in https://i.imgur.com/p5q9uyY.png (https://imgur.com/a/gdj62). Bug: 821393 Change-Id: I690d2d6df1ece0ca75e4dcbbdb42bbd092eb234c Reviewed-on: https://chromium-review.googlesource.com/985316 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#547083} [modify] https://crrev.com/2b603cc658cfe26a384f325f0e44afca07905052/ui/gfx/color_space.cc
,
Mar 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8d4e54f08e1fc9e6c52a711be329b7d4915e57df commit 8d4e54f08e1fc9e6c52a711be329b7d4915e57df Author: Miguel Casas <mcasas@chromium.org> Date: Fri Mar 30 02:51:34 2018 debugd: add edid-decode on edid blobs This CL adds edid-decode on the edid blobs under /sys/class/drm-card0-* to the debugd. These EDID blobs have a serial number, this is removed before parsing (same as modetest does on ToT). BUG= chromium:821393 TEST=manually visit chrome://system Change-Id: I52721ac5197498b1a3645e1d7b58b945a9878fb4 Reviewed-on: https://chromium-review.googlesource.com/980680 Commit-Ready: Miguel Casas <mcasas@chromium.org> Tested-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/8d4e54f08e1fc9e6c52a711be329b7d4915e57df/debugd/src/log_tool.cc
,
Apr 5 2018
Note to self: #12 is in CrOs SDK 10530.0.0
,
Apr 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc0f49d77d09b465611339be74f687ccffb0ec5e commit fc0f49d77d09b465611339be74f687ccffb0ec5e Author: Miguel Casas <mcasas@chromium.org> Date: Fri Apr 06 18:13:37 2018 Edid: make a class out of the edid parsing functions This CL refactors the multiple individual functions of edid_parser.* into a single EdidParser class that parses an EDID blob passed on ctor, populating the necessary/available fields. This simplifies extending this parser (which has happened and is expected to happen again), and simplifies the client APIs and the unittests. The client contract is changed a bit, since EdidParser won't tell if the parsing failed, but this is not really impactful since the current users ignore this booleans anyhow. Erroneous parsing is signalled via error values. Besides that, a notable change is that now we're parsing the whole EDID whereas on ToT this was somewhat on demand. But anyway drm_util always wanted all those parsings, and EDIDParserX11, which only needed one on ToT, is expected to work on Linux, where walking a 128B array should not be very demanding. Also EDIDParserX11 had two unused methods, removed. Change-Id: Id38a02dad1bc4ba55a3f7041034098dac5153020 Bug: 821393 Reviewed-on: https://chromium-review.googlesource.com/970085 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#548858} [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/manager/chromeos/display_change_observer.cc [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/util/edid_parser.cc [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/util/edid_parser.h [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/util/edid_parser_fuzzer.cc [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/util/edid_parser_unittest.cc [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/util/x11/edid_parser_x11.cc [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/display/util/x11/edid_parser_x11.h [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/ozone/platform/drm/common/drm_util.cc [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/ozone/platform/drm/common/drm_util.h [modify] https://crrev.com/fc0f49d77d09b465611339be74f687ccffb0ec5e/ui/ozone/platform/drm/common/drm_util_unittest.cc
,
Apr 10 2018
It looks like the bit positions for extracting the LSBs of the Gx and Wx coordinates are incorrect: see https://chromium-review.googlesource.com/1005534.
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/116a900389f9a00fe8cfe21c2e50a312f47edf63 commit 116a900389f9a00fe8cfe21c2e50a312f47edf63 Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Mon Apr 16 21:53:21 2018 Fix the byte positions for Gx and Wx in the EDID parser. This CL corrects two erroneous byte positions during EDID parsing, namely for Green and White LSByte positions. Affected unit tests are fixed. Bug: 821393 Change-Id: Ica3c54258e0d58b55bd5c5779e9ef6b6f5e4a610 Reviewed-on: https://chromium-review.googlesource.com/1005534 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551133} [modify] https://crrev.com/116a900389f9a00fe8cfe21c2e50a312f47edf63/ui/display/util/edid_parser.cc [modify] https://crrev.com/116a900389f9a00fe8cfe21c2e50a312f47edf63/ui/display/util/edid_parser_unittest.cc [modify] https://crrev.com/116a900389f9a00fe8cfe21c2e50a312f47edf63/ui/ozone/platform/drm/common/drm_util_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/116a900389f9a00fe8cfe21c2e50a312f47edf63 commit 116a900389f9a00fe8cfe21c2e50a312f47edf63 Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Mon Apr 16 21:53:21 2018 Fix the byte positions for Gx and Wx in the EDID parser. This CL corrects two erroneous byte positions during EDID parsing, namely for Green and White LSByte positions. Affected unit tests are fixed. Bug: 821393 Change-Id: Ica3c54258e0d58b55bd5c5779e9ef6b6f5e4a610 Reviewed-on: https://chromium-review.googlesource.com/1005534 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#551133} [modify] https://crrev.com/116a900389f9a00fe8cfe21c2e50a312f47edf63/ui/display/util/edid_parser.cc [modify] https://crrev.com/116a900389f9a00fe8cfe21c2e50a312f47edf63/ui/display/util/edid_parser_unittest.cc [modify] https://crrev.com/116a900389f9a00fe8cfe21c2e50a312f47edf63/ui/ozone/platform/drm/common/drm_util_unittest.cc
,
Aug 15
Marking as Fixed, right, felixe@ ?
,
Aug 16
Correct, thank you!
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/55b7c842d80b837b975fa860c2ef79115929d7b9 commit 55b7c842d80b837b975fa860c2ef79115929d7b9 Author: Miguel Casas <mcasas@chromium.org> Date: Thu Aug 16 07:30:16 2018 debugd: fix typo in edid-decode crrev.com/c/980680 landed an edid-decode entry, but there's a typo that insidiously sneaked in and breaks it. This CL fixes it. BUG= chromium:821393 TEST=manually visit chrome://system Change-Id: I665d066788d36d15f5fd207e00dac0bbfa515720 Reviewed-on: https://chromium-review.googlesource.com/1175940 Commit-Ready: Miguel Casas <mcasas@chromium.org> Tested-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/55b7c842d80b837b975fa860c2ef79115929d7b9/debugd/src/log_tool.cc
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1b8d27987bcb01a7dc0ed25a8aa757c90c929ab2 commit 1b8d27987bcb01a7dc0ed25a8aa757c90c929ab2 Author: Miguel Casas <mcasas@chromium.org> Date: Wed Aug 22 02:27:49 2018 debugd: fix edid-decode sed regexp crrev.com/c/980680 landed an edid-decode but apparently the regexp wasn't to the liking of sed. This CL dumbs it down so that it works :-) BUG= chromium:821393 TEST=manually visit chrome://system Change-Id: I86b1da0a44fbd79120468f9f07b00edcbcc34750 Reviewed-on: https://chromium-review.googlesource.com/1179619 Commit-Ready: Miguel Casas <mcasas@chromium.org> Tested-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/1b8d27987bcb01a7dc0ed25a8aa757c90c929ab2/debugd/src/log_tool.cc
,
Aug 22
#21 landed as 10991.0.0 and chrome:system - edid-decode entry seems to work ! |
||||
►
Sign in to add a comment |
||||
Comment 1 by mcasas@chromium.org
, Mar 13 2018