New issue
Advanced search Search tips

Issue 821377 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Nov 27
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on:
issue 768586


Sign in to add a comment

Clang format issue: Splitting method reference in Java

Project Member Reported by vabr@chromium.org, Mar 13 2018 
This is being reported in b/74582688. Copy of the description below.

vabr@ will monitor the internal bug and update TODOs in code appropriately.


Your suggested formatting:
  ThreadUtils.runOnUiThread(this::update);

clang-format's current output:
  ThreadUtils.runOnUiThread(this ::update);

Additional information:
The space seems weird, given that this::update is a single entity.
Notes:
* This is about Java, not C++.
* Seen in a Chromium checkout.

Comment 1 by vabr@chromium.org, Mar 20 2018

Owner: ----
With the clang-format bug reported, I'm afraid I cannot do anything more to fix this until clang-format is fixed. Happy to remove the TODOs from the code once that happens, but removing from my bug queue until then.

Comment 2 by smaier@chromium.org, Nov 27

Blockedon: 768586
Labels: clang-format
Status: Fixed (was: ExternalDependency)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0b0b9951e8cbd329b351b3286ddecf5ca7634d0

commit a0b0b9951e8cbd329b351b3286ddecf5ca7634d0
Author: Vaclav Brozek <vabr@chromium.org>
Date: Wed Nov 28 09:56:10 2018

Remove clang directives working around  bug 821377 

The bug was fixed, the directives are no longer needed.

Bug:  821377 
Change-Id: Ieb92e60118dc5bc519154db60957b06319471a5f
Reviewed-on: https://chromium-review.googlesource.com/c/1352359
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611621}
[modify] https://crrev.com/a0b0b9951e8cbd329b351b3286ddecf5ca7634d0/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/DialogManager.java
[modify] https://crrev.com/a0b0b9951e8cbd329b351b3286ddecf5ca7634d0/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/ExportFlow.java
►

Sign in to add a comment