New issue
Advanced search Search tips

Issue 821375 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Mar 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q1



Sign in to add a comment

Adaptive Toolbar: Change blur background

Project Member Reported by gambard@chromium.org, Mar 13 2018 
The content view of the blur effect shouldn't have any color.
Per  issue 807778  
Toolbar background color: light blur effect only (i.e. [UIBlurEffect effectWithStyle: UIBlurEffectStyleLight])
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c270cd2956a17a2551986414ac09580283b1ce4

commit 9c270cd2956a17a2551986414ac09580283b1ce4
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Mar 13 15:09:44 2018

Remove toolbar's blur colored background

This CL removes the background color on the blur content view.

Bug:  821375 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2378bb075927bf5ba7ffd8a7a69bbc90c5328377
Reviewed-on: https://chromium-review.googlesource.com/960036
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542800}
[modify] https://crrev.com/9c270cd2956a17a2551986414ac09580283b1ce4/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm
[modify] https://crrev.com/9c270cd2956a17a2551986414ac09580283b1ce4/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm
[modify] https://crrev.com/9c270cd2956a17a2551986414ac09580283b1ce4/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.h
[modify] https://crrev.com/9c270cd2956a17a2551986414ac09580283b1ce4/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm

Comment 2 by gambard@chromium.org, Mar 13 2018

NextAction: 2018-03-14
Status: Fixed (was: Assigned)

Comment 3 by monor...@bugs.chromium.org, Mar 14 2018 

The NextAction date has arrived: 2018-03-14

Comment 4 by cmasso@google.com, Mar 14 2018

NextAction: ----
►

Sign in to add a comment