New issue
Advanced search Search tips

Issue 821372 link

Starred by 1 user
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Mar 2018
Cc:
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Media Engagement: do not use per-frame High MEI bit

Project Member Reported by mlamouri@chromium.org, Mar 13 2018 
High MEI bit is set per frame so when walking up the frame tree, it can be used at the top frame level. It may be better to have the information only available on the main frame and properly sync it with remote frames (for OOPIF).

This is a WIP CL that does this: https://chromium-review.googlesource.com/c/chromium/src/+/919162

However, it doesn't propagates the info so the remote frames will not be aware of the bit.

Comment 1 by beccahughes@chromium.org, Mar 13 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bf47e0b8d6a0c15b1d366358924c10ff3da747a

commit 7bf47e0b8d6a0c15b1d366358924c10ff3da747a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Mar 20 14:44:17 2018

Media Engagement: do not use per-frame High MEI bit

This moves the high MEI bit from Document to Page.

BUG= 821372 

Change-Id: I51ba39c7251a9c511cab29db028e6f6bf7167124
Reviewed-on: https://chromium-review.googlesource.com/964526
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544360}
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/exported/WebViewImpl.h
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/html/media/AutoplayPolicy.cpp
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/html/media/AutoplayUmaHelper.cpp
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/html/media/HTMLMediaElementTest.cpp
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/page/Page.cpp
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/Source/core/page/Page.h
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/public/web/WebLocalFrame.h
[modify] https://crrev.com/7bf47e0b8d6a0c15b1d366358924c10ff3da747a/third_party/WebKit/public/web/WebView.h

Comment 3 by beccahughes@chromium.org, Mar 20 2018

Status: Fixed (was: Started)
►

Sign in to add a comment