New issue
Advanced search Search tips

Issue 821354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

HoverButton doesn't show hover effect on Windows and Linux

Project Member Reported by tangltom@chromium.org, Mar 13 2018

Issue description

When hovering over hover buttons in the user menu or in other bubbles, there is no hover effect on Windows and Linux.
 
crrev.com/c/930522 seems to have removed the SetShowHighlightOnFocus(true) call.
Working on a CL to fix this.
Thanks tangltom@ for stepping up to fix something I broke!
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d953b6afdeae86ef9ce30fc520931d371f3e3f88

commit d953b6afdeae86ef9ce30fc520931d371f3e3f88
Author: Thomas Tangl <tangltom@chromium.org>
Date: Wed Mar 14 11:03:17 2018

Fix highlighting behavior of HoverButton

This CL fixes the highlighting behavior of
HoverButton by turning on highlight on focus.

Bug:  821354 
Change-Id: I3d89aa1febd2dc1cd4e82d2291983eb09e7fbab4
Reviewed-on: https://chromium-review.googlesource.com/960024
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543047}
[modify] https://crrev.com/d953b6afdeae86ef9ce30fc520931d371f3e3f88/chrome/browser/ui/views/hover_button.cc

Status: Fixed (was: Started)
No worries patricialor@. Was just a small slip through.
Labels: TE-Verified-M67 TE-Verified-67.0.3371.0
Able to reproduce this issue on 67.0.3370.0 using Ubuntu 14.04 and Windows 10, Hence verifying the fix on latest canary 67.0.3371.0.

Observing hover effect when hovering on buttons in profile menu. Attaching screenshot for reference.

As the fix is working as expected, adding TE-Verified labels.

Thanks!
821354 in 67.0.3371.0.png
221 KB View Download

Sign in to add a comment