Not only the suggestion list is affected, but the entry titles as well.
Other sites that use 'Open Sans' web font with font-weight:bold are also affected.

Deleted: good.png 83.1 KB

	good.png 83.1 KB View Download

Deleted: bad.png 66.0 KB

	bad.png 66.0 KB View Download

Sorry for the late response. I was busy investigating some other perf issues assigned to my @google.com account (which I mainly use) last week. I'll put this as my first priority next week.

My investigation shows that this is exactly the same issue as skbug.com/6886

Two possible solutions as mentioned in the original bug: 

1. improve our stroker
2. detect double-edges and switch back to AAA in those cases (review.skia.org/65840)

reed@ and caryclark@ are OOO this week so we may wait until next week to see which way we shall choose.

Here's the CL that should improve our stroker and solve this issue: https://skia-review.googlesource.com/c/skia/+/117182

Here's another approach to fix this issue: https://skia-review.googlesource.com/c/skia/+/117727

What's the required time to get this fixed?

All the solutions so far have downsides and we may need more time and discussions to find a solution that's good for the long term and more general cases.

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/54aefc74103a5c1810a7cc074746915c78ab3132

commit 54aefc74103a5c1810a7cc074746915c78ab3132
Author: Yuqian Li <liyuqian@google.com>
Date: Wed Apr 11 18:32:27 2018

Add private fIsBadForDAA bit to SkPath

Bug:  chromium:821353 
Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4
Reviewed-on: https://skia-review.googlesource.com/120201
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Reed <reed@google.com>

[modify] https://crrev.com/54aefc74103a5c1810a7cc074746915c78ab3132/src/core/SkScan_AntiPath.cpp
[modify] https://crrev.com/54aefc74103a5c1810a7cc074746915c78ab3132/src/core/SkPath.cpp
[modify] https://crrev.com/54aefc74103a5c1810a7cc074746915c78ab3132/src/core/SkDraw.cpp
[modify] https://crrev.com/54aefc74103a5c1810a7cc074746915c78ab3132/src/core/SkScalerContext.cpp
[modify] https://crrev.com/54aefc74103a5c1810a7cc074746915c78ab3132/src/core/SkPathPriv.h
[modify] https://crrev.com/54aefc74103a5c1810a7cc074746915c78ab3132/include/core/SkPath.h

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61

commit ed5e069dbb0b2ef49e22b9d17af3875e3682cd61
Author: Yuqian Li <liyuqian@google.com>
Date: Wed Apr 11 18:37:29 2018

Revert "Add private fIsBadForDAA bit to SkPath"

This reverts commit 54aefc74103a5c1810a7cc074746915c78ab3132.

Reason for revert: Forget the guard flag. Pixel tests would fail.

Original change's description:
> Add private fIsBadForDAA bit to SkPath
> 
> Bug:  chromium:821353 
> Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4
> Reviewed-on: https://skia-review.googlesource.com/120201
> Commit-Queue: Yuqian Li <liyuqian@google.com>
> Reviewed-by: Mike Reed <reed@google.com>

TBR=caryclark@google.com,liyuqian@google.com,reed@google.com

Change-Id: I2fe7cfcc3a80a51415f72d656da95a894a3240a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:821353 
Reviewed-on: https://skia-review.googlesource.com/120505
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>

[modify] https://crrev.com/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61/src/core/SkScan_AntiPath.cpp
[modify] https://crrev.com/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61/src/core/SkPath.cpp
[modify] https://crrev.com/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61/src/core/SkDraw.cpp
[modify] https://crrev.com/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61/src/core/SkScalerContext.cpp
[modify] https://crrev.com/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61/src/core/SkPathPriv.h
[modify] https://crrev.com/ed5e069dbb0b2ef49e22b9d17af3875e3682cd61/include/core/SkPath.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ab03fe975c537e4daf31ef51c74553b5aba67ca

commit 8ab03fe975c537e4daf31ef51c74553b5aba67ca
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Apr 12 06:59:07 2018

Roll src/third_party/skia/ ff7fa50f0..c6c5eade8 (26 commits)

https://skia.googlesource.com/skia.git/+log/ff7fa50f0c95..c6c5eade823a

$ git log ff7fa50f0..c6c5eade8 --date=short --no-merges --format='%ad %ae %s'
2018-04-11 fmalita Reland "Fix handling of MaskFilter matrices"
2018-04-11 angle-skia-autoroll Roll third_party/externals/angle2/ 785b20b7a..2dadd1d08 (11 commits)
2018-04-11 benjaminwagner Upgrade Windows Skolo bots.
2018-04-11 reed remove unused/dumb methods from SkRect
2018-04-11 reed Clean-up paints for drawImage (etc.) to enforce that we always ignore stroking and patheffects.
2018-04-11 caryclark more path is rect bugs
2018-04-11 mtklein skcms→9334796 reject non-XYZ/Lab PCS profiles
2018-04-11 liyuqian Revert "Add private fIsBadForDAA bit to SkPath"
2018-04-11 mtklein skcms→56f2a09 add sRGB profile and ApproximatelyEqualProfiles()
2018-04-11 liyuqian Add private fIsBadForDAA bit to SkPath
2018-04-11 robertphillips Add Vulkan to the DDL bots
2018-04-11 mtklein roll to particular targets
2018-04-11 benjaminwagner Switch to latest Windows Intel Skylake GPU driver.
2018-04-11 fmalita Fix SkTCopyOnFirstWrite copy semantics
2018-04-11 reed no need to tile draws that don't involve paths
2018-04-11 mtklein skcms→91a8958 Detect and canonicalize identity tables
2018-04-11 mtklein skcms→307ec0f remove a layer of nesting in skcms_Curve
2018-04-10 robertphillips Fix alpha threshold image filter GPU implementation
2018-04-10 egdaniel Remove guard around getBackendTexture/RenderTarget calls
2018-04-11 robertphillips Revert "Fix handling of MaskFilter matrices"
2018-04-10 angle-skia-autoroll Roll third_party/externals/angle2/ 0ce016c1b..785b20b7a (7 commits)
2018-04-10 fmalita Fix handling of MaskFilter matrices
2018-04-10 robertphillips Get ViaDDL working with Vulkan
2018-04-10 brianosman skcms→e753c6d disable -Wdouble-promotion
2018-04-10 egdaniel Move GrBackendRenderTarget over to new system of getting backed infos
2018-04-10 liyuqian Remove unused field fBitmapBytes

Created with:
  roll-dep src/third_party/skia
BUG= chromium:824145 , chromium:821353 , chromium:821353 


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: I206b007db0efd69b539806f5ba806bb8d4956d6d
Reviewed-on: https://chromium-review.googlesource.com/1008972
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#550059}
[modify] https://crrev.com/8ab03fe975c537e4daf31ef51c74553b5aba67ca/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997bf7ed26db3d5dd46d68bfd188bd6c8c68d24a

commit 997bf7ed26db3d5dd46d68bfd188bd6c8c68d24a
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Apr 12 15:08:12 2018

Add SK_SUPPORT_LEGACY_PATH_DAA_BIT

Bug:  chromium:821353 

Change-Id: I69a86f539e5e7d3b038fd085abfbba0826eb04bc
Reviewed-on: https://chromium-review.googlesource.com/1008043
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550201}
[modify] https://crrev.com/997bf7ed26db3d5dd46d68bfd188bd6c8c68d24a/skia/config/SkUserConfig.h

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/9438790b66fd2193a47971f66c44f7cec80a795a

commit 9438790b66fd2193a47971f66c44f7cec80a795a
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Apr 12 16:24:40 2018

Reland "Add private fIsBadForDAA bit to SkPath"

This reverts commit ed5e069dbb0b2ef49e22b9d17af3875e3682cd61.

Reason for revert: add the guard flag

Original change's description:
> Revert "Add private fIsBadForDAA bit to SkPath"
> 
> This reverts commit 54aefc74103a5c1810a7cc074746915c78ab3132.
> 
> Reason for revert: Forget the guard flag. Pixel tests would fail.
> 
> Original change's description:
> > Add private fIsBadForDAA bit to SkPath
> > 
> > Bug:  chromium:821353 
> > Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4
> > Reviewed-on: https://skia-review.googlesource.com/120201
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com
> 
> Change-Id: I2fe7cfcc3a80a51415f72d656da95a894a3240a4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  chromium:821353 
> Reviewed-on: https://skia-review.googlesource.com/120505
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>

TBR=caryclark@google.com,liyuqian@google.com,reed@google.com

Change-Id: Iebf7caf9ca74f305dec25b1b6512e93cb41cc8ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:821353 
Reviewed-on: https://skia-review.googlesource.com/120620
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>

[modify] https://crrev.com/9438790b66fd2193a47971f66c44f7cec80a795a/src/core/SkScan_AntiPath.cpp
[modify] https://crrev.com/9438790b66fd2193a47971f66c44f7cec80a795a/src/core/SkPath.cpp
[modify] https://crrev.com/9438790b66fd2193a47971f66c44f7cec80a795a/src/core/SkDraw.cpp
[modify] https://crrev.com/9438790b66fd2193a47971f66c44f7cec80a795a/src/core/SkScalerContext.cpp
[modify] https://crrev.com/9438790b66fd2193a47971f66c44f7cec80a795a/src/core/SkPathPriv.h
[modify] https://crrev.com/9438790b66fd2193a47971f66c44f7cec80a795a/include/core/SkPath.h

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/22e601f8c37b044ad9004e837db58164a7b311bb

commit 22e601f8c37b044ad9004e837db58164a7b311bb
Author: Yuqian Li <liyuqian@google.com>
Date: Fri Apr 13 00:01:44 2018

Limit our IsBadForDAA for stroke width > 0 and <= 2

Now, according to our gold, we probably are overkilling the DAA.
That could be bad for performance.

Bug: skia:6886  chromium:821353 
Change-Id: I92bb4cbedb106f7fbd7e01e8107773d413e2da52
Reviewed-on: https://skia-review.googlesource.com/121260
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>

[modify] https://crrev.com/22e601f8c37b044ad9004e837db58164a7b311bb/src/core/SkScalerContext.cpp

Update:-
 Re-tested this issue on Windows(7,8,8.1,10) and Mac(10.12.6,10.13.1) machines using latest Chrome Canary build# 67.0.3396.0 and Issue is still reproducible i.e. Font text doesn't appear properly in suggestion list.

Please find the attached screen-cast for the same.

Thanks..!

Deleted: LatestCanary_behavior.mov 5.3 MB

	LatestCanary_behavior.mov 5.3 MB View Download

Yes, the fix is only landed in Skia, but not in Chrome yet. We need to do a massive rebaseline for Chrome's layout tests before merging it into Chrome.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb

commit db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 13 20:04:30 2018

Roll src/third_party/skia/ c6c5eade8..21dfd8467 (29 commits)

https://skia.googlesource.com/skia.git/+log/c6c5eade823a..21dfd846724a

$ git log c6c5eade8..21dfd8467 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit)
2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2
2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits)
2018-04-12 reed can't abort looper loop, as saveCount won't be balanced
2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size
2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot
2018-04-12 caryclark son of path is rect bug
2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler
2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface.
2018-04-12 reed check for non-finite values output by clipper
2018-04-12 brianosman Fail fast when trying to make a texture that's too large
2018-04-12 djsollen Include shadow ops in the debugger.
2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath"
2018-04-12 reed add conservative bounds to raster tiling
2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices
2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot
2018-04-12 caryclark another rect is path fix
2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS
2018-04-11 csmartdalton Implement Sk2f Load2
2018-04-11 csmartdalton ccpr: Blacklist ANGLE again
2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode
2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows
2018-04-11 csmartdalton Implement Sk4f min/max
2018-04-11 liyuqian Remove obsolete comment
2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS.
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits)
2018-04-11 caryclark fix bm gm
2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together

Created with:
  roll-dep src/third_party/skia
BUG= chromium:824145 , chromium:821353 ,chromium:818693,chromium:820245,chromium:820470, chromium:824145 ,chromium:815092


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: Ic83a9e3addd0c3593736a5bd03a4b4b2d37b7c51
Reviewed-on: https://chromium-review.googlesource.com/1011738
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550739}
[modify] https://crrev.com/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb/DEPS

The fix should be in the master branch now. Should I cherry-pick the multiple CLs into M66? If so, is there any doc/instruction on how to do that step by step? (Sorry, I'm not very familiar with the cherry-pick process, especially when there are multiple CLs.)

You should only need to merge the Skia changes, since we don't rebaseline tests on Chrome release branches.

Could you list the Skia changes needed for the fix, and add Merge-Request-67/Merge-Request-66 to trigger the merge review here?

* Merge-Request-67/Merge-Request-66 labels :)

The two skia CLs that need to be merged are:

1. https://skia.googlesource.com/skia/+/9438790b66fd2193a47971f66c44f7cec80a795a
2. https://skia.googlesource.com/skia/+/22e601f8c37b044ad9004e837db58164a7b311bb

Also, depending on whether the guard flag SK_SUPPORT_LEGACY_PATH_DAA_BIT is in M66 or M67, shall we also consider whether to cherry-pick the CL that removes this guard flag:

https://chromium-review.googlesource.com/c/chromium/src/+/1010511

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

How safe the CLs listed at #18 are to merge to M67? Will the be fully safe?

+ abdulsyed@ for M66 merge review.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997bf7ed26db3d5dd46d68bfd188bd6c8c68d24a

commit 997bf7ed26db3d5dd46d68bfd188bd6c8c68d24a
Author: Yuqian Li <liyuqian@google.com>
Date: Thu Apr 12 15:08:12 2018

Add SK_SUPPORT_LEGACY_PATH_DAA_BIT

Bug:  chromium:821353 

Change-Id: I69a86f539e5e7d3b038fd085abfbba0826eb04bc
Reviewed-on: https://chromium-review.googlesource.com/1008043
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550201}
[modify] https://crrev.com/997bf7ed26db3d5dd46d68bfd188bd6c8c68d24a/skia/config/SkUserConfig.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb

commit db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb
Author: skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 13 20:04:30 2018

Roll src/third_party/skia/ c6c5eade8..21dfd8467 (29 commits)

https://skia.googlesource.com/skia.git/+log/c6c5eade823a..21dfd846724a

$ git log c6c5eade8..21dfd8467 --date=short --no-merges --format='%ad %ae %s'
2018-04-13 angle-skia-autoroll Roll third_party/externals/angle2/ ed8d5ec73..cc1293775 (1 commit)
2018-04-12 liyuqian Limit our IsBadForDAA for stroke width > 0 and <= 2
2018-04-12 csmartdalton ccpr: Actually blacklist ANGLE
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 14f4817c4..ed8d5ec73 (8 commits)
2018-04-12 reed can't abort looper loop, as saveCount won't be balanced
2018-04-12 egdaniel Don't create lazy proxys if their width/height is greater than max tex size
2018-04-12 robertphillips Actually generate the gm images on the DDL1 bot
2018-04-12 caryclark son of path is rect bug
2018-04-12 ethannicholas workaround for buggy macOS GLSL shader compiler
2018-04-12 egdaniel Delete getRenderTargetHandle call on SkSurface.
2018-04-12 reed check for non-finite values output by clipper
2018-04-12 brianosman Fail fast when trying to make a texture that's too large
2018-04-12 djsollen Include shadow ops in the debugger.
2018-04-11 liyuqian Reland "Add private fIsBadForDAA bit to SkPath"
2018-04-12 reed add conservative bounds to raster tiling
2018-04-12 reed always clear the looper when we're unrolling it, to not confused devices
2018-04-11 robertphillips Disable CCPR and the small path renderer on DDL1 bot
2018-04-12 caryclark another rect is path fix
2018-04-11 robertphillips Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS
2018-04-11 csmartdalton Implement Sk2f Load2
2018-04-11 csmartdalton ccpr: Blacklist ANGLE again
2018-04-11 robertphillips Allow SkImage_Gpu to fail some requests in DDL mode
2018-04-11 cwallez update_meta_config: Use new LUCI optional GPU trybot on Windows
2018-04-11 csmartdalton Implement Sk4f min/max
2018-04-11 liyuqian Remove obsolete comment
2018-04-11 benjaminwagner Upgrade PixelC and NexusPlayer OS.
2018-04-12 angle-skia-autoroll Roll third_party/externals/angle2/ 2dadd1d08..14f4817c4 (2 commits)
2018-04-11 caryclark fix bm gm
2018-04-12 mtklein skcms→1654786 concat gamut transform matrices together

Created with:
  roll-dep src/third_party/skia
BUG= chromium:824145 , chromium:821353 ,chromium:818693,chromium:820245,chromium:820470, chromium:824145 ,chromium:815092


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=borenet@chromium.org

Change-Id: Ic83a9e3addd0c3593736a5bd03a4b4b2d37b7c51
Reviewed-on: https://chromium-review.googlesource.com/1011738
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550739}
[modify] https://crrev.com/db0f55c0a0e90c982b77e44229aaa3d4ba2f3cdb/DEPS

govind@: I think the CLs in #18 are pretty safe, but probably not fool-proof. Are we now testing them using label merge-merged-testbranch ?

Pls ignore comment #22 with label merge-merged-testbranch , pls see bug 833979 for more details.

I think the CLs in #18 are pretty safe, but probably not fool-proof
 -> If they are not fully safe, are they critical to merge to M67? I see this is a regression on M66 and M66 went to stable today without these merges.

> are they critical to merge

The bug affects Chrome WebStore and all sites that use OpenSans bold - a popular font - quite likely other web fonts too, so you can expect lots of people noticing obviously worsened font rendering.

Maybe it'd be simpler to disable DAA completely in 66/67?

I'm open to all options. All I can say is that the CLs are probably 99% safe (<1% chance to have problem). If 66 is stable, maybe we couldn't do much? Considering 67 is just branched, maybe we'll have enough time to test those CLs after getting merged?

Maybe I'll leave the final decision to PMs as this is a tradeoff between our clients' need and potential risks.

Approving merge to M67 branch 3396 for CLs listed at #18 per comment #27. Please merge ASAP.

+abdulsyed@ (M66 Release TPM) for M66 merge review,.

Pls merge your change to M67 branch 3396 ASAP so we can pick it up for next M67 Dev/Beta release.

If already merged to M67 and nothing is pending, pls remove "Merge=Approved-67" label. Thank you.

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d

commit b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d
Author: Yuqian Li <liyuqian@google.com>
Date: Wed Apr 18 19:13:54 2018

Reland "Add private fIsBadForDAA bit to SkPath"

This reverts commit ed5e069dbb0b2ef49e22b9d17af3875e3682cd61.

Reason for revert: add the guard flag

Original change's description:
> Revert "Add private fIsBadForDAA bit to SkPath"
> 
> This reverts commit 54aefc74103a5c1810a7cc074746915c78ab3132.
> 
> Reason for revert: Forget the guard flag. Pixel tests would fail.
> 
> Original change's description:
> > Add private fIsBadForDAA bit to SkPath
> > 
> > Bug:  chromium:821353 
> > Change-Id: Ic6585e76df692bb1853d0990d75f0e8d1dee22f4
> > Reviewed-on: https://skia-review.googlesource.com/120201
> > Commit-Queue: Yuqian Li <liyuqian@google.com>
> > Reviewed-by: Mike Reed <reed@google.com>
> 
> TBR=caryclark@google.com,liyuqian@google.com,reed@google.com
> 
> Change-Id: I2fe7cfcc3a80a51415f72d656da95a894a3240a4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  chromium:821353 
> Reviewed-on: https://skia-review.googlesource.com/120505
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Yuqian Li <liyuqian@google.com>

TBR=caryclark@google.com,liyuqian@google.com,reed@google.com

Change-Id: Iebf7caf9ca74f305dec25b1b6512e93cb41cc8ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:821353 
Reviewed-on: https://skia-review.googlesource.com/120620
Commit-Queue: Yuqian Li <liyuqian@google.com>
Reviewed-by: Yuqian Li <liyuqian@google.com>
(cherry picked from commit 9438790b66fd2193a47971f66c44f7cec80a795a)
Reviewed-on: https://skia-review.googlesource.com/122101

[modify] https://crrev.com/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d/src/core/SkScan_AntiPath.cpp
[modify] https://crrev.com/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d/src/core/SkPath.cpp
[modify] https://crrev.com/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d/src/core/SkDraw.cpp
[modify] https://crrev.com/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d/src/core/SkScalerContext.cpp
[modify] https://crrev.com/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d/src/core/SkPathPriv.h
[modify] https://crrev.com/b9bfe22cb9ac7c1ebb0dccc3e09941fd72084c3d/include/core/SkPath.h

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ee5ecf3313c28d3dc44b2caa984170c9858166ba

commit ee5ecf3313c28d3dc44b2caa984170c9858166ba
Author: Yuqian Li <liyuqian@google.com>
Date: Wed Apr 18 19:57:48 2018

Limit our IsBadForDAA for stroke width > 0 and <= 2

Now, according to our gold, we probably are overkilling the DAA.
That could be bad for performance.

Bug: skia:6886  chromium:821353 
Change-Id: I92bb4cbedb106f7fbd7e01e8107773d413e2da52
Reviewed-on: https://skia-review.googlesource.com/121260
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Yuqian Li <liyuqian@google.com>
(cherry picked from commit 22e601f8c37b044ad9004e837db58164a7b311bb)
Reviewed-on: https://skia-review.googlesource.com/122102
Reviewed-by: Yuqian Li <liyuqian@google.com>
Reviewed-by: Mike Reed <reed@google.com>

[modify] https://crrev.com/ee5ecf3313c28d3dc44b2caa984170c9858166ba/src/core/SkScalerContext.cpp

Is cl listed at #32 need a merge to M67? If nothing is pending for M67, pls remove "Merge-Approved-67" label. Thank you.

I think the CL in #32 is already merged to M67. I do need to merge one more CL though. I'll remove the label after that.

CL list at #32 landed in trunk 73 minutes back so it is not yet merge to M67. 
Are you planning to merge this cl to M67 once it is baked in canary?

@goving the CLs in c#31/c#32 are cherry-picks, landed in Skia's m67 branch (not trunk).

* sorry, meant @govind :)

Ok, got it. Thank you fmalita@.
liyuqian@, pls request a merge for new CL once change is baked in canary?

https://skia-review.googlesource.com/c/skia/+/122160 merged to chrome/m67. Removing Merge-Approved-67

Let's verify this in Dev tomorrow. I'm not inclined to take this in M66 Stable, since this is not a functional blocker or a critical issue. 

Confirmed with liyuqian@ and we'll target the fix for M67.