New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821347 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: Bug
M-X

Blocking:
issue 774955



Sign in to add a comment

Regression:Save Password dialog for chrome does not appear for 'Evernote Web Clipper' extension

Reported by vineetha...@etouch.net, Mar 13 2018

Issue description

Chrome Version: 65.0.3325.162(Official Build)Revision 5d04e9e9c8ce31bee0923a8c326a7e9e19c492a3-refs/branch-heads/3325@{#695}(32/64 bit)
OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) OS

Test URL: https://chrome.google.com/webstore/search/evernote?hl=en-GB

What steps will reproduce the problem?
(1) Launch Chrome, navigate to above URL and add 'Evernote Web Clipper' extension to chrome.
(2) Now click on the extension icon to open a Sign in overlay.
(3) Sign in with valid credentials and observe.

Actual Result: Save Password dialog for chrome does not appear.
Expected Result: Save Password dialog should appear and password should get saved to chrome.

This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect,
Good build: 64.0.3260.0(Revision: 514067)
Bad build: 64.0.3261.0(Revision: 514329)

You are probably looking for a change made after 514116 (known good), but no later than 514117 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/04f1082efb63369e19ace6dde8b62c8702303b88..6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e

Suspect: https://chromium.googlesource.com/chromium/src/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e

@tapted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. This issue is also seen on M66 Dev(build #66.0.3359.26), M67 Canary(build #67.0.3368.0).
2. The issue is not seen on Linux(14.04 LTS) OS.


Thank You!

 
ActualVideo.mov
3.7 MB View Download
ExpectedVideo.mov
6.8 MB View Download

Comment 1 by tapted@chromium.org, Mar 14 2018

Cc: bsep@chromium.org ellyjo...@chromium.org vasi...@chromium.org
Components: UI>Browser>Passwords
Labels: Proj-HarmonyDialogs Proj-MacViews
reporter: can you clarify whether this is a regression on Windows (i.e. did it ever work there?). It's unlikely that CL changed things significantly on Windows.

(elly/vasilii: 2 busy sheriff shifts have put me way behind on things - I won't be able to look at this immediately.)

It's possible the anchoring is not working properly in popups (or maybe just extension popups).
Screenshot from 2018-03-14 11-50-02.png
91.8 KB View Download
Owner: vasi...@chromium.org
Labels: -Target-65 -Target-66
MacViews triage: vasilii@, how is this looking? Let's target a fix at M67.
Labels: -Pri-1 Pri-2
It's not a high priority because the window is gone quickly anyway.
Labels: MacViews-Dialogs

Comment 6 by gov...@chromium.org, Mar 27 2018

Labels: -M-65 M-67

Comment 7 by gov...@chromium.org, Mar 29 2018

Are we still targeting this for M67 based on comment #4?
I'll analyse it for M67.

Comment 9 by gov...@chromium.org, Mar 29 2018

** Bulk Edit **

There are only two M67 dev releases left on 04/03 & 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you.
** Bulk Edit **

There is only one dev release left 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you.

FYI: Change/Fix has to be landed in trunk latest by 4:00 PM PT, Friday (04/06) so we can pick it up for next week dev release. 
The password manager works on this site. But the bubble is incorrectly anchored.
Screen Shot 2018-04-04 at 16.53.11.png
71.1 KB View Download
New positioning.
Screen Shot 2018-04-06 at 14.13.52.png
58.9 KB View Download
Blocking: 774955
Labels: -M-67 -Target-67
I have a pending fix for alignment here https://chromium-review.googlesource.com/c/chromium/src/+/998163

I verified that the bubble appears if the window stays in the screen. In the original reproduction case it doesn't appear because the window closes before we show it. Probably the macviews bubble has longer animation or it's just slower. Anyway, it doesn't make sense to debug the race condition because we can't assume that 0.5sec is just enough to click 'Save' in the bubble. We should handle this case somehow differently. Thus, I'm leaving the bug open.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d

commit 9d05ec002dd34b7cb4b9d661aed08bbc70a7959d
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Apr 09 10:39:24 2018

Align password bubble properly on Mac.

The case when there was no omnibox wasn't handled properly. The bubble should be top-center aligned with the window.

Bug: 821347
Change-Id: I6af3395da3cbf6f399625c4020015941c5e0b092
Reviewed-on: https://chromium-review.googlesource.com/998163
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549143}
[modify] https://crrev.com/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm
[modify] https://crrev.com/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d/ui/views/bubble/bubble_border_unittest.cc

Can this be marked as fixed if nothing else is pending?
Labels: -Type-Bug-Regression Type-Bug
I didn't really fix it. We need to rethink the UX flow for such a use case. It's not high priority and doesn't block anything.
Labels: M-X
Owner: ----
Status: Available (was: Assigned)
Cc: nepper@chromium.org
Labels: -Proj-MacViews

Sign in to add a comment