Regression:Save Password dialog for chrome does not appear for 'Evernote Web Clipper' extension
Reported by
vineetha...@etouch.net,
Mar 13 2018
|
|||||||||||
Issue descriptionChrome Version: 65.0.3325.162(Official Build)Revision 5d04e9e9c8ce31bee0923a8c326a7e9e19c492a3-refs/branch-heads/3325@{#695}(32/64 bit) OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) OS Test URL: https://chrome.google.com/webstore/search/evernote?hl=en-GB What steps will reproduce the problem? (1) Launch Chrome, navigate to above URL and add 'Evernote Web Clipper' extension to chrome. (2) Now click on the extension icon to open a Sign in overlay. (3) Sign in with valid credentials and observe. Actual Result: Save Password dialog for chrome does not appear. Expected Result: Save Password dialog should appear and password should get saved to chrome. This is regression issue broken in ‘M-64’ and providing the bisect using per-revision bisect, Good build: 64.0.3260.0(Revision: 514067) Bad build: 64.0.3261.0(Revision: 514329) You are probably looking for a change made after 514116 (known good), but no later than 514117 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/04f1082efb63369e19ace6dde8b62c8702303b88..6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e Suspect: https://chromium.googlesource.com/chromium/src/+/6b6e8fe1fcf17e0545c688d1bfda16d6f79fd97e @tapted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. This issue is also seen on M66 Dev(build #66.0.3359.26), M67 Canary(build #67.0.3368.0). 2. The issue is not seen on Linux(14.04 LTS) OS. Thank You!
,
Mar 14 2018
,
Mar 26 2018
MacViews triage: vasilii@, how is this looking? Let's target a fix at M67.
,
Mar 26 2018
It's not a high priority because the window is gone quickly anyway.
,
Mar 26 2018
,
Mar 27 2018
,
Mar 29 2018
Are we still targeting this for M67 based on comment #4?
,
Mar 29 2018
I'll analyse it for M67.
,
Mar 29 2018
** Bulk Edit ** There are only two M67 dev releases left on 04/03 & 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you.
,
Apr 3 2018
** Bulk Edit ** There is only one dev release left 04/10 before M67 branch on 04/12. Please try to land the fix ASAP to trunk so we can move forward with 50%-50% experiment on M67 Canary/Dev (if possible at all). Thank you. FYI: Change/Fix has to be landed in trunk latest by 4:00 PM PT, Friday (04/06) so we can pick it up for next week dev release.
,
Apr 4 2018
The password manager works on this site. But the bubble is incorrectly anchored.
,
Apr 6 2018
New positioning.
,
Apr 6 2018
I have a pending fix for alignment here https://chromium-review.googlesource.com/c/chromium/src/+/998163 I verified that the bubble appears if the window stays in the screen. In the original reproduction case it doesn't appear because the window closes before we show it. Probably the macviews bubble has longer animation or it's just slower. Anyway, it doesn't make sense to debug the race condition because we can't assume that 0.5sec is just enough to click 'Save' in the bubble. We should handle this case somehow differently. Thus, I'm leaving the bug open.
,
Apr 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d commit 9d05ec002dd34b7cb4b9d661aed08bbc70a7959d Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Apr 09 10:39:24 2018 Align password bubble properly on Mac. The case when there was no omnibox wasn't handled properly. The bubble should be top-center aligned with the window. Bug: 821347 Change-Id: I6af3395da3cbf6f399625c4020015941c5e0b092 Reviewed-on: https://chromium-review.googlesource.com/998163 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549143} [modify] https://crrev.com/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d/chrome/browser/ui/cocoa/tab_dialogs_views_mac.mm [modify] https://crrev.com/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d/ui/views/bubble/bubble_border.cc [modify] https://crrev.com/9d05ec002dd34b7cb4b9d661aed08bbc70a7959d/ui/views/bubble/bubble_border_unittest.cc
,
Apr 9 2018
Can this be marked as fixed if nothing else is pending?
,
Apr 9 2018
I didn't really fix it. We need to rethink the UX flow for such a use case. It's not high priority and doesn't block anything.
,
Apr 17 2018
,
May 14 2018
,
Jun 21 2018
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by tapted@chromium.org
, Mar 14 2018Components: UI>Browser>Passwords
Labels: Proj-HarmonyDialogs Proj-MacViews
91.8 KB
91.8 KB View Download