Issue metadata
Sign in to add a comment
|
Regression : 'Search' icon is not visible for the first suggestion entry in omnibox.
Reported by
avsha...@etouch.net,
Mar 13 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 67.0.3368.0 (Official Build) 0f36d3901569535a63173a1835f8dfbcf7b66d60-refs/heads/master@{#542340} 32/64-bit OS : Windows(7,8,8.1,10), Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, open NTP and hit 'Ctrl' + 'E' keys. 2. Press down arrow key from keyboard and observe the 'Search' icon (Magnifying glass) for the first suggestion in omnibox. Actual Result : 'Search' icon is not visible for the first suggestion in omnibox. Expected Result : 'Search' icon should be visible for every suggestion shown in omnibox. This is a regression issue, broken in M-67 and providing the bisect results using per-revision script : Good Build : 67.0.3366.0 (Revision : 541889) Bad Build : 67.0.3367.0 (Revision : 542330) You are probably looking for a change made after 541956 (known good), but no later than 541957 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/e8c5b2a752c2ff431178877754c07e13bfb12873..8ec2a06321af1ec8b42cecd1df8f29d254b5b52b Suspect : https://chromium.googlesource.com/chromium/src/+/8ec2a06321af1ec8b42cecd1df8f29d254b5b52b @Dave : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : 1. This issue is not observed on Mac(10.12.6, 10.13.1, 10.13.4) OS
,
Mar 14 2018
The color of the icon was white and wasn't being updated when selection changed. (and white on white is not visible). CL at https://chromium-review.googlesource.com/c/chromium/src/+/962680
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6240b88a0fc429b7cf58cd396c1a2927a78190c4 commit 6240b88a0fc429b7cf58cd396c1a2927a78190c4 Author: Dave Schuyler <dschuyler@chromium.org> Date: Thu Mar 15 19:25:27 2018 [Omnibox] set color of icons on invalidate This Cl updates the color of icons in invalidate (e.g. selection or theme changes). Bug: 821342 Change-Id: Icbd861b443ed9d0125121641f94e1ec6aeb1865c Reviewed-on: https://chromium-review.googlesource.com/962680 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#543468} [modify] https://crrev.com/6240b88a0fc429b7cf58cd396c1a2927a78190c4/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
,
Mar 15 2018
,
Mar 16 2018
Update : Verified above issue in latest Canary #67.0.3372.0 build on Windows(7,8,8.1,10) and Linux(14.04 LTS) OS and the issue is fixed. 'Search' icon is clearly visible for the first suggestion entry in omnibox. Kindly review an attached screencast. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dschuyler@chromium.org
, Mar 14 2018