XML/XSLT transform error when XML has encoding windows-1251 and exceeds 32k
Reported by
dea...@gmail.com,
Mar 13 2018
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.146 Safari/537.36 Example URL: Steps to reproduce the problem: 1. Create XML with corresponding XSLT template 2. Add windows-1251 encoding attribute to XML 3. Add 32k+ content to XML 4. XSLT transformation fails What is the expected behavior? XSLT should produce content What went wrong? After update to Chrome.65 XSLT breaks on XML files with encoding of windows-1251 and size 32k+. With encoding windows-1252 or utf-8 XSLT works just fine. Example file in attach. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes 64 Does this work in other browsers? Yes Chrome version: 65.0.3325.146 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version:
,
Mar 13 2018
,
Mar 14 2018
Unable to reproduce this issue on reported version 65.0.3325.146 using Windows 7 with steps mentioned below. 1. Launched 65.0.3325.146 and opened index file -- observed blank page with no content, no error in console 2. Opened .xslt file and observed some content. Attaching screencast for reference. @Reorter: Please check the video and let us know if we miss anything. If possible please guide us on reproducing this issue with a screencast. Any further information on reproducing this will help in further investigation of bug. Thanks!
,
Mar 14 2018
1. Launched 65.0.3325.146 and opened index file -- observed blank page with no content, no error in console Yep, it is an error. This XML/XSLT should produce string: "It's works!" If you remove some text from XML, so XML file size will be less than 32Kb, the XSLT will produce that string. Also, if you just change encoging string in the XML from encoding="windows-1251" to encoding="windows-1252" or to encoding="utf-8", the test page will works too.
,
Mar 14 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 14 2018
Hi,
I have noticed the same problem. Was working fine with version 64 and then updated to version 65 (within 10 minutes). We also narrowed it down to a 32Kb problem.
var xProc= new XSLTProcessor();
xProc.importStylesheet(xsl);
var result=xProc.transformToDocument(xml);
result returns null if xml document is larger than 32Kb. Style sheet size seems irellevant and output document size also seems irellevant.
,
Mar 15 2018
Able to reproduce this issue on reported version 65.0.3325.146, on latest stable 65.0.3325.168, on latest beta 66.0.3359.33 and on latest canary 67.0.3371.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.3. Observations: 1. Issue is seen from M-60 -- Not observing It's works! text. 2. Even on changing from encoding="windows-1251" to encoding="windows-1252" or to encoding="utf-8" -- Not observing It's works! text. 3. Even on making XML file size to 25 kb -- Not observing It's works! text. 4. Issue is seen in safari and chrome -- checked with encoding="windows-1251" 5. It's works! text is seen in firefox and IE. As issue is reproducible from M-60, considering this issue as Non-Regression and marking as Untriaged and removing Needs-Bisect label. Could someone from Blink>XML team please have a look at this issue.
,
Mar 15 2018
Hi, Some more info: when my xml document is UTF-8, no problem at all. When my xml document is ISO-8859-1 and > 32Kb, broken. I tried the following workaround and it works. 1-Convert ISO-8859-1 document to string 2-parse it into new document 3-apply style sheet var xmlString=new XMLSerializer().serializeToString(xml.documentElement); var parser = new DOMParser(); var newXml=parser.parseFromString(xmlString,'text/xml'); var xProc= new XSLTProcessor(); xProc.importStylesheet(xsl); var result=xProc.transformToDocument(newXml); result returns valid document So the problem is definitively with the encoding. Thanks you.
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4be2115e0abf80619cbf702d0619520d0c4c868d commit 4be2115e0abf80619cbf702d0619520d0c4c868d Author: Stephen Chenney <schenney@chromium.org> Date: Fri Mar 16 18:30:55 2018 Revert "Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c" This reverts commit c0a946a4dec56ce5906a78f6e0b0c1f9e12c70b6. Reason for revert: Breaks content all over the web. Bug: 820163 , 822673 , 820561 , 812148 , 821333 Original change's description: > Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c > > This fixes a number of bugs found on clusterfuzz. > > Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 > Bug: 790944 > Bug: 793715 > Bug: 796804 > Bug: 799707 > Reviewed-on: https://chromium-review.googlesource.com/897220 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533953} TBR=dcheng@chromium.org,scottmg@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790944 , 793715 , 796804 , 799707 Change-Id: Ic6b934d384229b9cf9092d559b865bbe8f278f38 Reviewed-on: https://chromium-review.googlesource.com/966684 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#543766} [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/README.chromium [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/chromium/chromium-issue-628581.patch [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/linux/xml2-config [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/HTMLparser.c [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/configure.ac [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/libxml2.spec [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/parser.c [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/parserInternals.c [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/win32/Makefile.msvc [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/win32/configure.js [delete] https://crrev.com/431c6dbf0a42d0c31c7dccd6553c6c496f1042a0/third_party/libxml/src/win32/libxml2.rc [modify] https://crrev.com/4be2115e0abf80619cbf702d0619520d0c4c868d/third_party/libxml/src/xmlIO.c
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f92ca1175c89aec344326778c755ba57ef4d314 commit 0f92ca1175c89aec344326778c755ba57ef4d314 Author: Stephen Chenney <schenney@chromium.org> Date: Fri Mar 16 18:50:19 2018 Revert "Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c" M-65 stable merge. This reverts commit c0a946a4dec56ce5906a78f6e0b0c1f9e12c70b6. Reason for revert: Breaks content all over the web. Bug: 820163 , 822673 , 820561 , 812148 , 821333 Original change's description: > Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c > > This fixes a number of bugs found on clusterfuzz. > > Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 > Bug: 790944 > Bug: 793715 > Bug: 796804 > Bug: 799707 > Reviewed-on: https://chromium-review.googlesource.com/897220 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533953} TBR=dcheng@chromium.org,scottmg@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790944 , 793715 , 796804 , 799707 Change-Id: Ic6b934d384229b9cf9092d559b865bbe8f278f38 Reviewed-on: https://chromium-review.googlesource.com/966684 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543766}(cherry picked from commit 4be2115e0abf80619cbf702d0619520d0c4c868d) Reviewed-on: https://chromium-review.googlesource.com/967021 Cr-Commit-Position: refs/branch-heads/3325@{#714} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/README.chromium [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/chromium/chromium-issue-628581.patch [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/linux/xml2-config [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/HTMLparser.c [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/configure.ac [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/libxml2.spec [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/parser.c [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/parserInternals.c [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/win32/Makefile.msvc [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/win32/configure.js [delete] https://crrev.com/483290671a61fdd75600a7b7f5e4a940ba814e9b/third_party/libxml/src/win32/libxml2.rc [modify] https://crrev.com/0f92ca1175c89aec344326778c755ba57ef4d314/third_party/libxml/src/xmlIO.c
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a1c705833b375b124b014159dcadda02a80e9b commit 54a1c705833b375b124b014159dcadda02a80e9b Author: Stephen Chenney <schenney@chromium.org> Date: Fri Mar 16 19:00:42 2018 Revert "Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c" This reverts commit c0a946a4dec56ce5906a78f6e0b0c1f9e12c70b6. M-66 merge. Reason for revert: Breaks content all over the web. Bug: 820163 , 822673 , 820561 , 812148 , 821333 Original change's description: > Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c > > This fixes a number of bugs found on clusterfuzz. > > Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 > Bug: 790944 > Bug: 793715 > Bug: 796804 > Bug: 799707 > Reviewed-on: https://chromium-review.googlesource.com/897220 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533953} TBR=dcheng@chromium.org,scottmg@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790944 , 793715 , 796804 , 799707 Change-Id: Ic6b934d384229b9cf9092d559b865bbe8f278f38 Reviewed-on: https://chromium-review.googlesource.com/966684 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543766}(cherry picked from commit 4be2115e0abf80619cbf702d0619520d0c4c868d) Reviewed-on: https://chromium-review.googlesource.com/966962 Cr-Commit-Position: refs/branch-heads/3359@{#288} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/README.chromium [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/chromium/chromium-issue-628581.patch [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/linux/xml2-config [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/HTMLparser.c [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/configure.ac [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/libxml2.spec [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/parser.c [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/parserInternals.c [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/win32/Makefile.msvc [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/win32/configure.js [delete] https://crrev.com/11b924f8c4a7c84bfb46e8df78e7ef8d330dc907/third_party/libxml/src/win32/libxml2.rc [modify] https://crrev.com/54a1c705833b375b124b014159dcadda02a80e9b/third_party/libxml/src/xmlIO.c
,
Mar 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8901956103e21b8c3461b779e99cd5d7f50f3ad commit d8901956103e21b8c3461b779e99cd5d7f50f3ad Author: Stephen Chenney <schenney@chromium.org> Date: Fri Mar 16 19:19:12 2018 Revert "Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c" This reverts commit c0a946a4dec56ce5906a78f6e0b0c1f9e12c70b6. Canary build branch merge. Reason for revert: Breaks content all over the web. Bug: 820163 , 822673 , 820561 , 812148 , 821333 Original change's description: > Roll libxml to 707ad080e61014ab4a6d60dc12875e233c1f673c > > This fixes a number of bugs found on clusterfuzz. > > Change-Id: Id2fa1d96e55be1e0483c135c20c20b90a068f4c3 > Bug: 790944 > Bug: 793715 > Bug: 796804 > Bug: 799707 > Reviewed-on: https://chromium-review.googlesource.com/897220 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Scott Graham <scottmg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533953} TBR=dcheng@chromium.org,scottmg@chromium.org,joelhockey@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790944 , 793715 , 796804 , 799707 Change-Id: Ic6b934d384229b9cf9092d559b865bbe8f278f38 Reviewed-on: https://chromium-review.googlesource.com/966684 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543766}(cherry picked from commit 4be2115e0abf80619cbf702d0619520d0c4c868d) Reviewed-on: https://chromium-review.googlesource.com/966690 Cr-Commit-Position: refs/branch-heads/3372@{#1} Cr-Branched-From: ad7f48548867b059f459e13c53bb8e2e96027381-refs/heads/master@{#543592} [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/README.chromium [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/chromium/chromium-issue-628581.patch [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/linux/xml2-config [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/HTMLparser.c [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/configure.ac [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/libxml2.spec [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/parser.c [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/parserInternals.c [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/win32/Makefile.msvc [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/win32/configure.js [delete] https://crrev.com/ad7f48548867b059f459e13c53bb8e2e96027381/third_party/libxml/src/win32/libxml2.rc [modify] https://crrev.com/d8901956103e21b8c3461b779e99cd5d7f50f3ad/third_party/libxml/src/xmlIO.c
,
Mar 19 2018
Dupe this one too?
,
Mar 19 2018
,
Mar 20 2018
Able to reproduce this issue on reported version hence verifying the fix on 65.0.3325.181. Same behavior is seen in 65.0.3325.181 on opening attached xml file given in comment#0. i.e.;Not observing any "It's works!" text on loading xml file. Attaching screenshot for reference. @schenney:Request you please help in verifying the fix on latest M-65 [65.0.3325.181]. Thanks!
,
Mar 21 2018
@schenney: Gentle Ping!! Issue is still seen in 65.0.3325.181 and latest M-66 66.0.3359.45. Could you please help us in confirming the fix.
,
Mar 21 2018
I confirm that fix works for my case. Thank you all! :) Windows, version: 65.0.3325.181 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by viswa.karala@chromium.org
, Mar 13 2018