New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 821326 link

Starred by 1 user
Status: Fixed
Owner:
khorimoto@chromium.org
Closed: Mar 2018
Cc:
█ jlklein@chromium.org
█ jordynass@chromium.org
█ jhawkins@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move //components/multidevice into //chromeos/services

Project Member Reported by blundell@chromium.org, Mar 13 2018 
All services (in the servicification sense) within //components are moving into //components/services. We have left //components/multidevice alone as it is targeted to move out of //components entirely into //chromeos/services. This move should happen to remove this wart :).

Comment 1 by khorimoto@chromium.org, Mar 13 2018

Cc: jordynass@chromium.org jlklein@chromium.org jhawkins@chromium.org
FYI, this will be part of the MultiDevice API setup.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cf73f85575ff47e38413957dc23532ce86abe03

commit 3cf73f85575ff47e38413957dc23532ce86abe03
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Mar 29 00:03:29 2018

[CrOS MultiDevice] Move DeviceSync service to //chromeos/services.

This service is only intended to be used in CrOS. Its old location
(//components/multidevice) has been removed.

Bug:  821326 , 824568,  752273 
Change-Id: Icbef4d23e73640eb5d3b92db9d19e519b8a50959
Reviewed-on: https://chromium-review.googlesource.com/982896
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546668}
[modify] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/BUILD.gn
[add] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/BUILD.gn
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/DEPS
[add] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/OWNERS
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_client_factory_impl.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_client_factory_impl.h
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_enroller_factory_impl.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_enroller_factory_impl.h
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_token_fetcher_impl.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_token_fetcher_impl.h
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/cryptauth_token_fetcher_impl_unittest.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/device_sync_impl.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/device_sync_impl.h
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/device_sync_service.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/device_sync_service.h
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/device_sync_service_unittest.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/fake_device_sync_observer.cc
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/fake_device_sync_observer.h
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/manifest.json
[add] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/public/mojom/BUILD.gn
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/public/mojom/OWNERS
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/public/mojom/constants.mojom
[rename] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/chromeos/services/device_sync/public/mojom/device_sync.mojom
[modify] https://crrev.com/3cf73f85575ff47e38413957dc23532ce86abe03/components/BUILD.gn
[delete] https://crrev.com/fba415eb6d82add7996bd5f2ba40adf720b4a2c3/components/multidevice/BUILD.gn
[delete] https://crrev.com/fba415eb6d82add7996bd5f2ba40adf720b4a2c3/components/multidevice/OWNERS
[delete] https://crrev.com/fba415eb6d82add7996bd5f2ba40adf720b4a2c3/components/multidevice/README.md
[delete] https://crrev.com/fba415eb6d82add7996bd5f2ba40adf720b4a2c3/components/multidevice/service/BUILD.gn
[delete] https://crrev.com/fba415eb6d82add7996bd5f2ba40adf720b4a2c3/components/multidevice/service/OWNERS
[delete] https://crrev.com/fba415eb6d82add7996bd5f2ba40adf720b4a2c3/components/multidevice/service/public/interfaces/BUILD.gn

Comment 3 by khorimoto@chromium.org, Mar 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment