Issue metadata
Sign in to add a comment
|
Regression:Overlay of 'keep dangerous file' in chrome://downloads/ closes after crashing the page manually.
Reported by
vku...@etouch.net,
Mar 13 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 67.0.3368.0 (Official Build) Revision 0f36d3901569535a63173a1835f8dfbcf7b66d60-refs/heads/master@{#542340}(32/64-bit) OS:Windows (7,8,8.1,10),Linux (14.04 LTS) What steps will reproduce the problem? (1)Launch chrome and navigate to http://www.provos.org/tmp/content.exe (2)Press Ctrl+J to open downloads > click 'keep dangerous file' such that overlay appears (3)Now crash the page manually via chrome://kill and observe overlay. Actual: Overlay of 'keep dangerous file' closes after crashing the page manually via chrome://kill. Expected: Overlay of 'keep dangerous file' should not close after crashing the page manually via chrome://kill. This is a regression issue broken in 'M66' and below is the manual bisect info Good Build: 66.0.3344.0(Revision:535593) Bad Build: 66.0.3345.0(Revision:536026) Note: Issue not seen on Mac(10.13.1, 10.12.6, 10.13.4) OS
,
Apr 11 2018
,
Apr 12 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2837c5891e07d0cd2afe61537b08706d2fef71e1 commit 2837c5891e07d0cd2afe61537b08706d2fef71e1 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Apr 13 20:18:58 2018 WebView should not hide its NativeViewHost when showing a crash overlay. In r535735 we made WebView responsible for showing an overlay (like a sad tab) when the WebContents has crashed. When the overlay was showing we hid the NativeViewHost to be safe (using SetVisible(false)). This had the unintended consequence of closing modal dialogs such as a cookie dialog or dangerous download warning dialog. In testing, it seems safe to not actually hide |holder_|, the NativeViewHost. The overlay is absolute-positioned on top of it, and it's not possible to focus the WebContents. This was more or less true in the previous Sad Tab implementation where it was displayed in a Widget on top of the WebView instead of as a child View. Bug: 826248 , 821312 Change-Id: I748afeff1ac8d7e1fa18ccafe709706f803ae6cc Reviewed-on: https://chromium-review.googlesource.com/1008621 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#550742} [modify] https://crrev.com/2837c5891e07d0cd2afe61537b08706d2fef71e1/ui/views/controls/webview/webview.cc
,
Apr 16 2018
,
Apr 16 2018
,
Apr 16 2018
This bug requires manual review: We are only 0 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 16 2018
M66 Stable release is tomorrow. Why is this critical to land for 66 vs waiting until 67?
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2837c5891e07d0cd2afe61537b08706d2fef71e1 commit 2837c5891e07d0cd2afe61537b08706d2fef71e1 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Apr 13 20:18:58 2018 WebView should not hide its NativeViewHost when showing a crash overlay. In r535735 we made WebView responsible for showing an overlay (like a sad tab) when the WebContents has crashed. When the overlay was showing we hid the NativeViewHost to be safe (using SetVisible(false)). This had the unintended consequence of closing modal dialogs such as a cookie dialog or dangerous download warning dialog. In testing, it seems safe to not actually hide |holder_|, the NativeViewHost. The overlay is absolute-positioned on top of it, and it's not possible to focus the WebContents. This was more or less true in the previous Sad Tab implementation where it was displayed in a Widget on top of the WebView instead of as a child View. Bug: 826248 , 821312 Change-Id: I748afeff1ac8d7e1fa18ccafe709706f803ae6cc Reviewed-on: https://chromium-review.googlesource.com/1008621 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#550742} [modify] https://crrev.com/2837c5891e07d0cd2afe61537b08706d2fef71e1/ui/views/controls/webview/webview.cc
,
Apr 23 2018
This doesn't appear to be critical for stable. Let's target this for M67. Dmazzoni@ - can you please confirm? |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Mar 13 2018Owner: dmazz...@chromium.org
Status: Assigned (was: Unconfirmed)