New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821309 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 795980



Sign in to add a comment

Pull xcode with CIPD for WebRTC

Project Member Reported by phoglund@chromium.org, Mar 13 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/1288c59c352c18bddef9bc7783a8bde38d30f5a4

commit 1288c59c352c18bddef9bc7783a8bde38d30f5a4
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Tue Mar 13 10:05:38 2018

Switch to using CIPD for downloading xcode; xcode 9.0 -> 9.2.

Bug:  chromium:821309 
Change-Id: If304e08c2f7b1beb26325c334c2f1894c5f290f7
Reviewed-on: https://webrtc-review.googlesource.com/61421
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22397}
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json
[modify] https://crrev.com/1288c59c352c18bddef9bc7783a8bde38d30f5a4/tools_webrtc/ios/tryserver.webrtc/ios_rel.json

Blocking: 795980
Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/4160441178a0c8e2abed065dfa040523e1b3af46

commit 4160441178a0c8e2abed065dfa040523e1b3af46
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Tue Mar 13 12:15:50 2018

Revert "Switch to using CIPD for downloading xcode; xcode 9.0 -> 9.2."

This reverts commit 1288c59c352c18bddef9bc7783a8bde38d30f5a4.

Reason for revert: 'ios_api_framework' builder uses global `lipo` which is not available

Original change's description:
> Switch to using CIPD for downloading xcode; xcode 9.0 -> 9.2.
> 
> Bug:  chromium:821309 
> Change-Id: If304e08c2f7b1beb26325c334c2f1894c5f290f7
> Reviewed-on: https://webrtc-review.googlesource.com/61421
> Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22397}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I8fbfc7872eb6e6c3f0e18dec39e130d5af9e3cd8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:821309 
Reviewed-on: https://webrtc-review.googlesource.com/61460
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22399}
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json
[modify] https://crrev.com/4160441178a0c8e2abed065dfa040523e1b3af46/tools_webrtc/ios/tryserver.webrtc/ios_rel.json

Status: Assigned (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/3133857266925d4bc66e0bddef8c9a1fefc3a060

commit 3133857266925d4bc66e0bddef8c9a1fefc3a060
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Tue Mar 13 13:43:52 2018

Temporarily disable ios_api_framework.

It needs a recipe update + testing so let's not stop CQ CLs
for now.

TBR=oprypin@webrtc.org

Bug:  chromium:821309 
Change-Id: If06faddcb11e9fcc03e6910f137e42fac0b1beee
Reviewed-on: https://webrtc-review.googlesource.com/61428
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22400}
[modify] https://crrev.com/3133857266925d4bc66e0bddef8c9a1fefc3a060/infra/config/cq.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70

commit fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70
Author: Patrik Höglund <phoglund@chromium.org>
Date: Wed Mar 14 09:41:37 2018

Fix ios_framework_api bot.

This recipe does a lot of things the ios recipe does, but it doesn't
build using the ios recipe code. This fixes the code so that the
correct xcode is downloaded. This removes FORCE_MAC_TOOLCHAIN
since the cipd mechanism supersedes it.

Possible follow-up: put a .json next to the others and make this
recipe read it, so the xcode version is just in one place.

Bug:  chromium:821309 
Change-Id: Id9766febfc054698f8d4e2cc6eac6433df67cd8b
Reviewed-on: https://chromium-review.googlesource.com/960030
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>

[modify] https://crrev.com/fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70/scripts/slave/README.recipes.md
[modify] https://crrev.com/fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70/scripts/slave/recipes/webrtc/ios_api_framework.py
[modify] https://crrev.com/fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70/scripts/slave/recipes/webrtc/ios_api_framework.expected/build_ok.json
[modify] https://crrev.com/fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70/scripts/slave/recipes/webrtc/ios_api_framework.expected/build_failure.json
[modify] https://crrev.com/fdae1d7fe7b63f1c93b1278f7829f1e9fa5c9e70/scripts/slave/recipes/webrtc/ios_api_framework.expected/trybot_build.json

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/2f639aca849f60a16e89b6954b8720e41f6e80eb

commit 2f639aca849f60a16e89b6954b8720e41f6e80eb
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Wed Mar 14 09:46:12 2018

Reland: Switch to using CIPD for downloading xcode; xcode 9.0 -> 9.2.

I have landed https://cr-rev.appspot.com/c/960030 now, which should
fix the borked framework bot.

Bug:  chromium:821309 
Change-Id: I0396360b8bb23d664ed1de8f2bbc1af88f3151ed
Reviewed-on: https://webrtc-review.googlesource.com/61427
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22416}
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios32_sim_ios9_dbg.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios10_dbg.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios11_dbg.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios64_sim_ios9_dbg.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios_arm64_dbg.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios_arm64_rel.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios_dbg.json
[modify] https://crrev.com/2f639aca849f60a16e89b6954b8720e41f6e80eb/tools_webrtc/ios/tryserver.webrtc/ios_rel.json

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/ea4a4cf7cbf0cca129bff7f1b68d2f080dbc7a9e

commit ea4a4cf7cbf0cca129bff7f1b68d2f080dbc7a9e
Author: Patrik Höglund <phoglund@webrtc.org>
Date: Wed Mar 14 12:09:52 2018

Revert "Temporarily disable ios_api_framework."

This reverts commit 3133857266925d4bc66e0bddef8c9a1fefc3a060.

Reason for revert: bot fixed.

Original change's description:
> Temporarily disable ios_api_framework.
> 
> It needs a recipe update + testing so let's not stop CQ CLs
> for now.
> 
> TBR=oprypin@webrtc.org
> 
> Bug:  chromium:821309 
> Change-Id: If06faddcb11e9fcc03e6910f137e42fac0b1beee
> Reviewed-on: https://webrtc-review.googlesource.com/61428
> Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#22400}

TBR=phoglund@webrtc.org,oprypin@webrtc.org

Change-Id: I38f5685bb6e5d2fe8a8cce51ca9bab1132a4db8e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:821309 
Reviewed-on: https://webrtc-review.googlesource.com/61740
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22421}
[modify] https://crrev.com/ea4a4cf7cbf0cca129bff7f1b68d2f080dbc7a9e/infra/config/cq.cfg

Status: Fixed (was: Assigned)

Sign in to add a comment