New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821297 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 26 days ago
Closed: Dec 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Spatnav cannot navigate inside scrollable area if the scrollable area is focused

Project Member Reported by junho092...@lge.com, Mar 13 2018

Issue description

We can make scrollable area as focusable by giving tabindex property.

What steps will reproduce the problem?
(1) ./chrome --enable-spatial-navigation
(2) Open attached html file
(3) Hit tab key. Scrollable area should get focus.
(4) Hit down key.

What is the expected result?
An element inside scrollable area should get focus.

What happens instead?
An element at bottom get focus.

I suggest that we should do following navigation order if a navigable container is focused element:
1) Search a focusable element inside the container.
2) Scroll the container.
3) Search a focusable element outside the container (as focused element).
 
snav_scrollalbe_with_focusable_attribute.html
679 bytes View Download

Comment 1 by hu...@vewd.com, Mar 13 2018

Status: Available (was: Untriaged)
Summary: Spatnav cannot navigate inside scrollable area if the scrollable area is focused (was: Spatnav cannot navigate inside scrollable area when if the scrollable area is focused.)
Sounds good! I like that navigation order. I updated https://bit.ly/snav2 to emphasize these steps.

Comment 3 by hu...@vewd.com, Apr 5 2018

Owner: junho092...@lge.com
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d17b741996e047d7aaf439dcb22ef7359e8f52b

commit 0d17b741996e047d7aaf439dcb22ef7359e8f52b
Author: JunHo Seo <junho0924.seo@lge.com>
Date: Thu Dec 06 14:43:43 2018

Snav: Search inside focused scroll containers

Previously, spatial navigation could not navigate inside a focused
container. This change makes spatnav first search (or scroll) a
focused scroll container, before searching outside of it:

(1) Search for focusable elements inside any focused container.
(2) If step (1) couldn't find a candidate, try to scroll the container.
(3) If step (2) couldn't scroll, search for focusable elements outside
    the container.

This follows the design document: https://bit.ly/snav2.

Bug:  821297 
Change-Id: I81ab360dac5ee865e34c0f840378c9a637a8fe89
Reviewed-on: https://chromium-review.googlesource.com/c/960185
Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
Cr-Commit-Position: refs/heads/master@{#614341}
[modify] https://crrev.com/0d17b741996e047d7aaf439dcb22ef7359e8f52b/third_party/blink/renderer/core/page/focus_controller.cc
[modify] https://crrev.com/0d17b741996e047d7aaf439dcb22ef7359e8f52b/third_party/blink/web_tests/fast/spatial-navigation/resources/snav-testharness.js
[modify] https://crrev.com/0d17b741996e047d7aaf439dcb22ef7359e8f52b/third_party/blink/web_tests/fast/spatial-navigation/snav-div-scrollable-but-without-focusable-content.html
[add] https://crrev.com/0d17b741996e047d7aaf439dcb22ef7359e8f52b/third_party/blink/web_tests/fast/spatial-navigation/snav-dont-search-focused-offscreen-scroller.html
[add] https://crrev.com/0d17b741996e047d7aaf439dcb22ef7359e8f52b/third_party/blink/web_tests/fast/spatial-navigation/snav-search-focused-scroller-first.html

Status: Fixed (was: Started)

Sign in to add a comment