New issue
Advanced search Search tips

Issue 821289 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

LayoutObject::ShowLineTreeForThis() is broken

Project Member Reported by xiaoche...@chromium.org, Mar 13 2018 
Chrome Version: ToT at r542739
OS: Linux

What steps will reproduce the problem?
(1) Add a ShowLineTreeForThis() call somewhere in the code
(2) Navigate to "data:text/html, foo" and do something to trigger the call

What is the expected result?

Line tree is dumped

What happens instead?

Line tree is not dumped. Only the root LayoutBlockFlow is dumped.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ca16cd378b8304c1afa039cbe627fd49ccf780

commit c4ca16cd378b8304c1afa039cbe627fd49ccf780
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Mar 14 06:57:34 2018

Make ShowLineTreeForThis work on RootInlineBox and children-inline LayoutBlockFlow

When calling ShowLineTreeForThis() on RootInlineBox and children-
inline LayoutBlockFlow, the existing code searches for inline
structures in a wrong LayoutBlock, which is the block container of
the inline formatting context instead of the inline formatting
context itself.

This patch fixes the issue.

Bug:  821289 
Change-Id: Icba7ee2b036649df5caba75050b4267188a8dbda
Reviewed-on: https://chromium-review.googlesource.com/961797
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543022}
[modify] https://crrev.com/c4ca16cd378b8304c1afa039cbe627fd49ccf780/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/c4ca16cd378b8304c1afa039cbe627fd49ccf780/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/c4ca16cd378b8304c1afa039cbe627fd49ccf780/third_party/WebKit/Source/core/layout/line/InlineBox.cpp

Comment 2 by xiaoche...@chromium.org, Mar 14 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment