New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821284 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 836369



Sign in to add a comment

Extensions are no longer allowed to autoplay videos (using YouTube iframe API)

Reported by gabr...@gsdb.net, Mar 13 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.146 Safari/537.36

Steps to reproduce the problem:
Please see attached extension
-------------------------------

(manifest.json)
[...] "content_security_policy": "script-src 'self' https://www.youtube.com https://s.ytimg.com [...]

(player.html)
<script src="https://www.youtube.com/iframe_api"></script>

(player.js)
var player;
function onYouTubeIframeAPIReady() {
    player = new YT.Player('player', {
        playerVars: {
            autoplay: 1
        },
        videoId: 'ZDSvSuPBThw'
    });
}

-------------------------------

It works perfectly with Chrome Stable 65.0.3325.146

It does NOT work with Chrome Dev 66.0.3346.8 or Canary 67.0.3368.1

What is the expected behavior?
The video should be played automatically

What went wrong?
The video does not play automatically as of Chrome Dev 66.0.3346.8

Did this work before? Yes 65.0.3325.146

Does this work in other browsers? Yes

Chrome version: 66.0.3346.8  Channel: dev
OS Version: 16.04.4
Flash Version: 

 Issue 514102  may be related
 
extension-test.zip
1.5 KB Download

Comment 1 by gabr...@gsdb.net, Mar 13 2018

That page may have something to do with this issue: https://developers.google.com/web/updates/2017/09/autoplay-policy-changes
Labels: Needs-Bisect Needs-Triage-M66
Cc: vamshi.kommuri@chromium.org
Components: Blink>Media
Labels: -Pri-2 -Needs-Bisect FoundIn-66 Triaged-ET FoundIn-67 M-66 Target-67 Target-66 hasbisect OS-Mac OS-Windows Pri-1
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 66.0.3346.8, latest dev 66.0.3359.26 and on the latest canary 67.0.3370.0 using Ubuntu 14.04, Windows 10 and Mac 10.13.1

Bisect information:
===================
Good Build: 66.0.3325.162
Bad Build:  66.0.3326.0


Our Observations while bisecting:
Bad:  65.0.3325.0
Good: 65.0.3325.162
Bad:  66.0.3326.0

Providing Manual Change Log:
https://chromium.googlesource.com/chromium/src/+log/65.0.3325.0..65.0.3325.146?pretty=fuller&n=10000
Suspecting: https://chromium-review.googlesource.com/c/chromium/src/+/887203
Note: The above CL is based on the range provided just under "Bisect information".

@Mounir Lamouri: Please help in assigning it to others if this is not related to your change.

Thanks!
Cc: johnpallett@chromium.org mlamouri@chromium.org
Owner: beccahughes@chromium.org
+johnpallet FYI

I thought that chrome extensions and chrome apps were allowed to autoplay. At least, I thought I wrote code that did just that. Pages in a <webview> are not allowed to autoplay -- could this be the problem here?

Assigning to beccahughes@ to have a look.
Components: -Blink>Media Blink>Media>Autoplay
Status: Started (was: Assigned)
Confirmed. YouTube is playing in an <iframe>.
I am using YouTube Iframe API with autoplay. 
It is playing with Chrome  65.0.3325.146.
It's not auto play with Chrome 66.0.3359.81 beta.
It's also auto play on other browsers.

I expect to auto play videos with sound.

Is there any way to achieve this programmatically with chrome 'autoplay policy'?

Thanks,
Prashant
 Issue 831606  has been merged into this issue.
Labels: ReleaseBlock-Stable
As we are seeing multiple reports being filed with the same issue, Hence adding "ReleaseBlock-Stable" for M-66.

Thanks!
There is a pending CL to fix this: https://chromium-review.googlesource.com/c/chromium/src/+/962803

Comment 11 by josh@arreya.com, Apr 12 2018

@beccahughes Will this fix have any effect on WebViews in an extension? As in:  crbug.com/829861 
No it will not
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da69b74240b086dde47ec9f729a243ea5b81021

commit 3da69b74240b086dde47ec9f729a243ea5b81021
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Apr 13 19:05:06 2018

Autoplay: Rename media enagement mojo api

The current MediaEnagementClient sends a bit to the renderer if the
page has a high MEI score. We would like to use this for other
things too but we need to send across more information (this is
a precursor CL to crrev.com/c/962803).

In order to do this properly this CL renames the existing interfaces
to use a generic 'AutoplayConfiguration' name and sends flags
instead of a single bool.

BUG= 821284 

Change-Id: I509e35f52c57ae79817dc59eaa4a81fcf51e6310
Reviewed-on: https://chromium-review.googlesource.com/1010716
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550709}
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/chrome/browser/DEPS
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/content/renderer/render_frame_impl.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/public/BUILD.gn
[add] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/public/platform/autoplay.mojom
[delete] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/third_party/blink/public/platform/media_engagement.mojom
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/autoplay_policy.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/html_media_element_test.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/page/page.h

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79adc2fa9d165278cb54e61ad5f2c356fe96ce62

commit 79adc2fa9d165278cb54e61ad5f2c356fe96ce62
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Apr 16 17:19:03 2018

Autoplay: Allow autoplay in extension iframes

If an extension has an <iframe> it should be allowed to autoplay.

BUG= 821284 

Change-Id: I1e11cbdef6a81acf5ea3e6d3dcaadc8c13464c16
Reviewed-on: https://chromium-review.googlesource.com/962803
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551018}
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/autoplay_browsertest.cc
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/chrome_extension_web_contents_observer.h
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/extension_webkit_preferences.cc
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_hosted_app/main.html
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_hosted_app/main.js
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/frame.html
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/frame.js
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/main.html
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/main.js
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/manifest.json
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/third_party/blink/public/platform/autoplay.mojom
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/third_party/blink/renderer/core/html/media/autoplay_policy.h

Labels: Merge-Request-67 Merge-Request-66
Project Member

Comment 16 by sheriffbot@chromium.org, Apr 16 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: We are only 0 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Rejected-66
This change just landed in trunk. It hasn't baked in canary yet. I'm not comfortable taking this change in since M66 Stable release is tomorrow. What is the full impact to users and how critical is it?
Project Member

Comment 18 by sheriffbot@chromium.org, Apr 17 2018

Labels: -Merge-Request-67 Merge-Review-67
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
How are changes listed at #13 and #14 looking canary before we approve merge to M67?
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da69b74240b086dde47ec9f729a243ea5b81021

commit 3da69b74240b086dde47ec9f729a243ea5b81021
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Apr 13 19:05:06 2018

Autoplay: Rename media enagement mojo api

The current MediaEnagementClient sends a bit to the renderer if the
page has a high MEI score. We would like to use this for other
things too but we need to send across more information (this is
a precursor CL to crrev.com/c/962803).

In order to do this properly this CL renames the existing interfaces
to use a generic 'AutoplayConfiguration' name and sends flags
instead of a single bool.

BUG= 821284 

Change-Id: I509e35f52c57ae79817dc59eaa4a81fcf51e6310
Reviewed-on: https://chromium-review.googlesource.com/1010716
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550709}
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/chrome/browser/DEPS
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/content/renderer/render_frame_impl.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/public/BUILD.gn
[add] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/public/platform/autoplay.mojom
[delete] https://crrev.com/17471a72481450aea238e1db90918254a3a5a453/third_party/blink/public/platform/media_engagement.mojom
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/autoplay_policy.h
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/html/media/html_media_element_test.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/3da69b74240b086dde47ec9f729a243ea5b81021/third_party/blink/renderer/core/page/page.h

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79adc2fa9d165278cb54e61ad5f2c356fe96ce62

commit 79adc2fa9d165278cb54e61ad5f2c356fe96ce62
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Apr 16 17:19:03 2018

Autoplay: Allow autoplay in extension iframes

If an extension has an <iframe> it should be allowed to autoplay.

BUG= 821284 

Change-Id: I1e11cbdef6a81acf5ea3e6d3dcaadc8c13464c16
Reviewed-on: https://chromium-review.googlesource.com/962803
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551018}
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/autoplay_browsertest.cc
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/chrome_extension_web_contents_observer.h
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/browser/extensions/extension_webkit_preferences.cc
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_hosted_app/main.html
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_hosted_app/main.js
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/frame.html
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/frame.js
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/main.html
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/main.js
[add] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/chrome/test/data/extensions/autoplay_iframe/manifest.json
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/third_party/blink/public/platform/autoplay.mojom
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/79adc2fa9d165278cb54e61ad5f2c356fe96ce62/third_party/blink/renderer/core/html/media/autoplay_policy.h

We haven't seen any reported issues
Labels: -Merge-Review-67 Merge-Approved-67
Approving merge to M67 branch 3396 for CLs listed at #13 and #14 per comment #22. Please merge ASAP. Thank you.
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 18 2018

Labels: -merge-approved-67 merge-merged-3396
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26465ecf347048aef2e0c6677315b605aacff52d

commit 26465ecf347048aef2e0c6677315b605aacff52d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Apr 18 23:24:30 2018

Autoplay: Rename media enagement mojo api

The current MediaEnagementClient sends a bit to the renderer if the
page has a high MEI score. We would like to use this for other
things too but we need to send across more information (this is
a precursor CL to crrev.com/c/962803).

In order to do this properly this CL renames the existing interfaces
to use a generic 'AutoplayConfiguration' name and sends flags
instead of a single bool.

BUG= 821284 

Change-Id: I509e35f52c57ae79817dc59eaa4a81fcf51e6310
Reviewed-on: https://chromium-review.googlesource.com/1010716
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550709}(cherry picked from commit 3da69b74240b086dde47ec9f729a243ea5b81021)
Reviewed-on: https://chromium-review.googlesource.com/1018045
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#113}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/chrome/browser/DEPS
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/content/renderer/render_frame_impl.h
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/public/BUILD.gn
[add] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/public/platform/autoplay.mojom
[delete] https://crrev.com/e183c23c575cb74b46401e44dd56ab900c3caa04/third_party/blink/public/platform/media_engagement.mojom
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/public/web/web_view.h
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/exported/web_view_impl.h
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/html/media/autoplay_policy.h
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/html/media/html_media_element_test.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/page/page.cc
[modify] https://crrev.com/26465ecf347048aef2e0c6677315b605aacff52d/third_party/blink/renderer/core/page/page.h

Project Member

Comment 25 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64f285f445160ca7ecc423a6a59aa2b360e8080d

commit 64f285f445160ca7ecc423a6a59aa2b360e8080d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Apr 18 23:25:01 2018

Autoplay: Allow autoplay in extension iframes

If an extension has an <iframe> it should be allowed to autoplay.

BUG= 821284 

Change-Id: I1e11cbdef6a81acf5ea3e6d3dcaadc8c13464c16
Reviewed-on: https://chromium-review.googlesource.com/962803
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551018}(cherry picked from commit 79adc2fa9d165278cb54e61ad5f2c356fe96ce62)
Reviewed-on: https://chromium-review.googlesource.com/1018162
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#114}
Cr-Branched-From: 9ef2aa869bc7bc0c089e255d698cca6e47d6b038-refs/heads/master@{#550428}
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/browser/extensions/autoplay_browsertest.cc
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/browser/extensions/chrome_extension_web_contents_observer.cc
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/browser/extensions/chrome_extension_web_contents_observer.h
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/browser/extensions/extension_webkit_preferences.cc
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_hosted_app/main.html
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_hosted_app/main.js
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_iframe/frame.html
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_iframe/frame.js
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_iframe/main.html
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_iframe/main.js
[add] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/chrome/test/data/extensions/autoplay_iframe/manifest.json
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/third_party/blink/public/platform/autoplay.mojom
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/third_party/blink/renderer/core/html/media/autoplay_policy.cc
[modify] https://crrev.com/64f285f445160ca7ecc423a6a59aa2b360e8080d/third_party/blink/renderer/core/html/media/autoplay_policy.h

Cc: josa...@chromium.org
Labels: OS-Chrome
Labels: M-67

Comment 28 by josa...@google.com, Apr 23 2018

Discussed with Abdul, we are willing to take this in M66 considering the verification and bake time looking good and impact to CrOS

Abdul, please confirm (aka update to merge-approved)
Beccahughes@ is currently checking how fix looks in today's dev and previous canaries. 
It looks like this may have caused another bug ( http://crbug.com/836369 ) so we might want to hold off on this for now :|

Comment 31 by josa...@google.com, Apr 24 2018

ok, please update when new solution is confirmed, we can then evaluate for an M66 stable refresh
Per comment #30, this caused another bug ( http://crbug.com/836369 ) so we need to revert M67 merges listed at #24 & #25, correct?
Since 67 is still in dev we should probably try to merge the fix instead.
Labels: ReleaseBlock-Beta
Plan is to promote current dev version (67.0.3396.18) to Beta on this Thursday (04/26).

If we don't have safe fix ready to be merged to M67 by EOD this Friday, pls plan to revert from M67. Marking as "RBB" for next week M67 beta for tracking purpose. Thank you.
Pls request a merge to M67 once safe fix is available to merge. Thank you.

Comment 36 Deleted

Blockedon: 836369
Fix merge requested in 836369
Labels: -M-66
Removing M66, lets target M67 for this fix. 
M67 merge is approved here - https://bugs.chromium.org/p/chromium/issues/detail?id=836369#c14. Pls merge and mark the bug as fixed if nothing else is pending here.
Status: Fixed (was: Started)
Fix is cherry picked to M67.

Sign in to add a comment