New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 821275 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - last_checked_out_revision should be included in try job report

Project Member Reported by lijeffrey@chromium.org, Mar 13 2018

Issue description

Flake try jobs return last_checked_out_revision in the report, which is not accounted for in the FlakeTryJobReport dto.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/99f4ab9d46672253ecf2f507dfe5ba4a4bc044b9

commit 99f4ab9d46672253ecf2f507dfe5ba4a4bc044b9
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed Mar 14 05:59:49 2018

[Findit] Flake Analyzer - Inherit FlakeTryJobReport from TryJobReport

last_checked_out_revision is returned as part of the flake try job report,
which isn't accounted for in the corresponding dto leading to assertion errors.
This change refactors (slightly) TryJobReport into its own dto, but leaves compile
and test try job reports intact which should be refactored separately.

Bug:  821275 
Change-Id: Icdd6a86c6ca89011f8b0890331b55abac5aeb42b
Reviewed-on: https://chromium-review.googlesource.com/959727
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/99f4ab9d46672253ecf2f507dfe5ba4a4bc044b9/appengine/findit/services/parameters.py
[modify] https://crrev.com/99f4ab9d46672253ecf2f507dfe5ba4a4bc044b9/appengine/findit/dto/flake_try_job_report.py
[modify] https://crrev.com/99f4ab9d46672253ecf2f507dfe5ba4a4bc044b9/appengine/findit/pipelines/flake_failure/test/run_flake_try_job_pipeline_test.py
[add] https://crrev.com/99f4ab9d46672253ecf2f507dfe5ba4a4bc044b9/appengine/findit/dto/try_job_report.py

Status: Verified (was: Assigned)

Sign in to add a comment