New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 821271 link

Starred by 2 users
Status: Fixed
Owner:
schenney@chromium.org
Closed: Jul 31
Cc:
█ sindhu.chelamcherla@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Background image disappears on zoom < 100%

Reported by oleg...@yandex-team.ru, Mar 13 2018 
Chrome Version       : 66.0.3359.26
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
URLs (if applicable) : Page in attachment
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox:
    IE/Edge: OK

What steps will reproduce the problem?
1. Open attached page in Chrome. Gray stripe on green.
2. Reduce scale to < 100%.

What is the expected result?
Page proportionally downscales.


What happens instead of that?
Gray stripe disappear.


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.26 Safari/537.36
ok_nan.html
543 bytes View Download

Comment 1 by oleg...@yandex-team.ru, Mar 13 2018 

If we set breakpoint in blink::Image::DrawPattern we'll see division by zero (repeat_spacing.Width() / scale.Width()) resulting in NaN(IND) at flags.shader_.tile_ and further NaNs in various matrices etc.

Comment 2 by viswa.karala@chromium.org, Mar 13 2018

Labels: Needs-Triage-M66

Comment 3 by sindhu.chelamcherla@chromium.org, Mar 14 2018

Cc: sindhu.chelamcherla@chromium.org
Components: Blink>Layout
Labels: -Pri-3 Triaged-ET M-67 Target-67 FoundIn-67 OS-Linux OS-Mac Pri-2
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on reported version 66.0.3359.26 and on latest canary 67.0.3370.0 using Windows 10, Mac 10.13.3 and Ubuntu 14.04 with given HTML file. On zooming out gray stripe disappears.

This issue is seen from M-60. Hence considering this issue as Non-Regression and marking as Untriaged.

Thanks!

Comment 4 by e...@chromium.org, Mar 16 2018

Components: -Blink>Layout Blink>Paint
Reassigning to Paint based on comment 1.

Comment 5 by schenney@chromium.org, Mar 16 2018

Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by schenney@chromium.org, Jun 8 2018 

Thanks for the bisect. The problem would be in the WebKit roll, with about 80 changes in it. Something there will be a background image change.

I'll make sure this is fixed as I totally refactor the background image code.

Comment 8 by f...@opera.com, Jun 8 2018 

I'd guess it was caused by 0f879d4a39561d10a2aa2d8d1a22a5eff3391b3a (and we now compute a tile-width of zero (in ApplySubPixelHeuristicToImageSize presumably.)

Comment 9 by schenney@chromium.org, Jul 31

Status: Fixed (was: Assigned)
I think this is now fixed, although we do get cracks sometimes as we scale down.
►

Sign in to add a comment