New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 52 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 923807

Blocking:
issue 754910

Restricted
  • Only users with EditIssue permission may comment.



Sign in to add a comment
link

Issue 821270: Re-enable SharedArrayBuffer + Atomics

Reported by bradnelson@chromium.org, Mar 13 2018 Project Member

Issue description

With site isolation enabled, we can re-enabled SharedArrayBuffer.
 

Comment 1 by jfb@chromium.org, Mar 28 2018

Cc: jfb@chromium.org

Comment 2 by robertvi...@gmail.com, Apr 21 2018

Will this likely be landing in Chrome 67?

Comment 3 by hablich@chromium.org, Apr 24 2018

It is a possibility.

Comment 4 by machtin....@gmail.com, Apr 28 2018

Unfortunately, still not enabled by default in chrome 68 dev.

Comment 5 by bradnelson@google.com, Apr 30 2018

Current plan is to re-enable post M67 launch via Finch, pending strong enough stability signals on site-isolation.
This is to avoid whiplashing the API on and off if site-isolation doesn't stick.

Comment 6 by bradnelson@chromium.org, Apr 30 2018

Cc: -nattestad@chromium.org -hablich@chromium.org -bradnelson@chromium.org lafo...@chromium.org danno@chromium.org titzer@chromium.org

Comment 7 by rekt...@gmail.com, Jun 10 2018

How does site-isolation permit this? Any chance site isolation is to be eanbled in Chrome 69?

Comment 8 by rekt...@gmail.com, Jun 10 2018

Also is there a site isolation enablement ticket that can be linked? I did some searching but there were a lot of results & it was hard for me to filter through them with confidence.

Comment 9 by lafo...@chromium.org, Jun 11 2018

Cc: bradnelson@chromium.org
Labels: -Pri-2 M-67 Restrict-AddIssueComment-EditIssue OS-Chrome OS-Linux OS-Mac OS-Windows Pri-1
Owner: dschuff@chromium.org
Site isolation enforces a process boundary for origins, which mitigates a certain class of vulnerabilities related to Spectre.

As for timing please see comment #5.

Comment 10 by palmer@chromium.org, Jun 11 2018

#7: For more information on Site Isolation and side-channel attacks, and how `SharedArrayBuffer` is involved, please see https://chromium.googlesource.com/chromium/src/+/master/docs/security/side-channel-threat-model.md#Site-Isolation. We are hoping to leave Site Isolation on by default in Chrome 67.

Comment 11 by hablich@chromium.org, Jun 19 2018

Blocking: 754910

Comment 12 by vdje...@fb.com, Jun 20 2018

Cc: vdje...@fb.com

Comment 13 by vdje...@fb.com, Jun 20 2018

Labels: DevRel-Facebook

Comment 14 by dschuff@chromium.org, Jul 31 2018

Status: Fixed (was: Assigned)
Site Isolation is now on for all desktop platforms, and SharedArrayBuffer is now re-enabled on all channels for those same platforms. When Site Isolation ships on Android, SAB can be re-enabled there too.

Comment 15 by creis@chromium.org, Aug 2

Components: Internals>Sandbox>SiteIsolation

Comment 16 by bugdroid1@chromium.org, Aug 16

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dbb4407b8a64dd9463ae34b1e9c19475acc1128

commit 4dbb4407b8a64dd9463ae34b1e9c19475acc1128
Author: Ben Smith <binji@chromium.org>
Date: Thu Aug 16 00:20:30 2018

Enable SharedArrayBuffer by default on non-android

It is currently enabled via finch for these platforms on 67+.

Bug:  chromium:821270 
Change-Id: Id402c71a8b9d108bbe0d8bca7fc585aff201241a
Reviewed-on: https://chromium-review.googlesource.com/1159358
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583458}
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/content/public/common/content_features.cc
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/crypto/random-values-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/crypto/subtle/importKey-badParameters-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/crypto/worker-random-values-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/beacon/beacon-basic-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/css/fontface-arraybuffer-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/encoding/api/sharedarraybuffer.html
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/events/constructors/midi-message-event-constructor-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/files/blob-constructor-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/workers/worker-atomics-wait-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/workers/worker-sharedarraybuffer-transfer-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/fast/xmlhttprequest/xmlhttprequest-send-sharedarraybuffer.html
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/http/tests/push_messaging/resources/pushmessagedata-worker.js
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/http/tests/websocket/send-arraybufferview-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/resources/global-interface-listing-worklet.js
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/crypto/random-values-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/crypto/subtle/importKey-badParameters-expected.txt
[rename] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/nested-worker-success-dedicatedworker-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/css/fontface-arraybuffer-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/dom/geometry-interfaces-dom-matrix-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/events/constructors/midi-message-event-constructor-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/files/blob-constructor-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/workers/worker-atomics-wait-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/fast/workers/worker-sharedarraybuffer-transfer-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces-worklet-scope-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/http/tests/websocket/send-arraybufferview-expected.txt
[rename] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/webaudio/dom-exceptions-expected.txt
[add] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/android/webmidi/send-messages-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/resources/global-interface-listing.js
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-platform-specific-expected.txt
[modify] https://crrev.com/4dbb4407b8a64dd9463ae34b1e9c19475acc1128/third_party/WebKit/LayoutTests/webmidi/send-messages-expected.txt

Comment 17 by hablich@chromium.org, Jan 21

Blockedon: 923807

Sign in to add a comment